[PHP] Querying DB in functions.php

February 25, 2013

I am trying to make a query from functions.php, but I get the following error:

Warning: mysqli_fetch_array() expects parameter 1 to be mysqli_result, boolean given in .../functions.php on line 60

Here is functions.php:

&lt;?php

function inline($symbol){

        GLOBAL $dbc;

        require_once ('mysqli_connect.php');

        $inline_display = "error";

        $q = "SELECT rating WHERE symbol = '$symbol'";
        $r = mysqli_query($dbc, $q);

        while ($row = mysqli_fetch_array($r)){

            $rating = $row['rating'];

        }

        if($rating == 1)
            $inline_display = "$symbol - &lt;font color=\"#ff0000\"&gt;&lt;b&gt;Avoid&lt;/b&gt;&lt;/font&gt;";
        if($rating == 2)
            $inline_display = "$symbol - &lt;font color=\"#990000\"&gt;&lt;b&gt;Risky&lt;/b&gt;&lt;/font&gt;";
        if($rating == 3)
            $inline_display = "$symbol - &lt;font color=\"#666666\"&gt;&lt;b&gt;Neutral&lt;/b&gt;&lt;/font&gt;";
        if($rating == 4)
            $inline_display = "$symbol - &lt;font color=\"#006600\"&gt;&lt;b&gt;Compelling Buy&lt;/b&gt;&lt;/font&gt;";
        if($rating == 5)
            $inline_display = "$symbol - &lt;font color=\"#ff6600\"&gt;&lt;b&gt;Top Pick&lt;/b&gt;&lt;/font&gt;";

        return $inline_display;

    }
?&gt;

This is the page that calls the function:

&lt;html&gt;
&lt;body&gt;

&lt;?php
    //require_once ('mysqli_connect.php');
    include ('functions.php');

    $symbol = "XOM";
    echo inline($symbol);



?&gt;

&lt;/body&gt;
&lt;/html&gt;

And here is mysqli_connect.php:

&lt;?php

// Set the database access information as constants:
DEFINE ('DB_USER', 'user');
DEFINE ('DB_PASSWORD', 'pass');
DEFINE ('DB_HOST', 'host');
DEFINE ('DB_NAME', 'db');

// Make the connection:
$dbc = @mysqli_connect (DB_HOST, DB_USER, DB_PASSWORD, DB_NAME) OR die ('Could not connect to MySQL: ' . mysqli_connect_error() );

// Set the encoding...
mysqli_set_charset($dbc, 'utf8');

// Use this next option if your system doesn't support mysqli_set_charset().
//mysqli_query($dbc, 'SET NAMES utf8');



?&gt;

I think my problem has something to do with making $dbc a global variable, but I haven't been able to resolve the issue. What am I doing wrong?

32,574 · February 25, 2013

you have the database connection commented out.

Edit: i've never used "mysqli_fetch_array" myself, so i don't know the advantages of that compared to 'mysql_fetch_array" and "mysql_query" vs "mysqli_query"

1,547 · February 25, 2013

Your SQL syntax is incorrect so mysqli_query is returning false instead of a result set:

$q = "SELECT rating WHERE symbol = '$symbol'";[/CODE]

Should be:
[CODE]$q = "SELECT rating FROM &lt;table_name&gt; WHERE symbol = '$symbol'";

However, using global variables and requiring files inside functions are bad practices. A (slightly) better way would be to pass the database handle as a parameter to the inline function, also, watch out for SQL Injection if symbol is going to be user generated.

On 25/02/2013 at 19:08, Andrew Lyle said:

i've never used "mysqli_fetch_array" myself, so i don't know the advantages of that compared to 'mysql_fetch_array" and "mysql_query" vs "mysqli_query"

mysql_* functions are deprecated and will be removed in future versions of PHP, no new scripts should use them (use Mysqli or PDO).

Sign In

[PHP] Querying DB in functions.php

Question

generalt

Link to comment

Share on other sites

2 answers to this question

Recommended Posts

Andrew Lyle Global Moderator

Link to comment

Share on other sites

ZakO

Link to comment

Share on other sites

Recently Browsing 0 members

Similar Content

WordPress-Theme Twenty Twenty Four-customizing: how to do that - a Gutenberg special question...

Save 20% on a 1-Yr Subscription to SQLPro for MySQL

how to redirect to an url

QNAP issues patch for an RCE security vulnerability affecting PHP in NAS Drive management

Get this Dynamic 2022 Data & IT Security Training Bundle at 97% off

Posts

Recent Achievements

Popular Contributors

Tell a friend

Company

Community

Social

Partners

Forums

News

Features

More

Themes

Looks like your ad blocker is on.

Choose your Ad Blocker