PHP / CSS question

[Laser]

I have a script that calculates a number based on user inputs. I am trying to highlight the resulting cell based on the submitted value.

$vartotal is the result when the form is submited <20 is suppose to be highlighed green, >30 Orange and > 34 red. howerver the only one that is working is >34 - Red.

I was hoping someone will see what I am doing wrong.

TIA

$varIndicatorClass = "";
   if($vartotal < 20){
    $varIndicatorClass = 'class="highlight"';
    }
$varIndicatorClass = "";
   if($vartotal > 30){
    $varIndicatorClass = 'class="highlight2"';
    }
$varIndicatorClass = "";
   if($vartotal > 34){
    $varIndicatorClass = 'class="highlight1"';
    }
[/CODE]

The cell that is highlighted

[CODE]<td '.$varIndicatorClass.'>'.$vartotal.'</td>[/CODE]

[+virtorio MVC]

You only need to initialize varIndicatorClass once:

   $varIndicatorClass = "";

   if($vartotal < 20){
	$varIndicatorClass = 'class="highlight"';
	}
   else if($vartotal > 30){
	$varIndicatorClass = 'class="highlight2"';
	}
   else if($vartotal > 34){
	$varIndicatorClass = 'class="highlight1"';
	}

edit: you should also use an else statement for situations like this.

[Laser]

Thanks It worked, I had tried using a eslse statement but it kept throwing an error so I tried the other way.

I appreciate the help!

[+virtorio MVC]

I screwed up, because it was late when I replied and I didn't read the code properly.

In the code I pasted above highlight2 will be chosen when the vartotal is above 30 (which includes > 34).

Removing the else statements would work, checking in reverse order would work, or getting more specific with the conditions would work:

Reverse order:

   $varIndicatorClass = "";

   if($vartotal > 34){
        $varIndicatorClass = 'class="highlight1"';
        }
   else if($vartotal > 30){
        $varIndicatorClass = 'class="highlight2"';
        }
   else if($vartotal < 20){
        $varIndicatorClass = 'class="highlight"';
        }

More specific:

   $varIndicatorClass = "";

   if($vartotal < 20){
        $varIndicatorClass = 'class="highlight"';
        }
   else if($vartotal > 30 && $vartotal <= 34){
        $varIndicatorClass = 'class="highlight2"';
        }
   else if($vartotal > 34){
        $varIndicatorClass = 'class="highlight1"';
        }

[Seahorsepip Veteran]

I screwed up, because it was late when I replied and I didn't read the code properly.

In the code I pasted above highlight2 will be chosen when the vartotal is above 30 (which includes > 34).

Removing the else statements would work, checking in reverse order would work, or getting more specific with the conditions would work:

Reverse order:

   $varIndicatorClass = "";

   if($vartotal > 34){
		$varIndicatorClass = 'class="highlight1"';
		}
   else if($vartotal > 30){
		$varIndicatorClass = 'class="highlight2"';
		}
   else if($vartotal < 20){
		$varIndicatorClass = 'class="highlight"';
		}

More specific:

   $varIndicatorClass = "";

   if($vartotal < 20){
		$varIndicatorClass = 'class="highlight"';
		}
   else if($vartotal > 30 && $vartotal <= 34){
		$varIndicatorClass = 'class="highlight2"';
		}
   else if($vartotal > 34){
		$varIndicatorClass = 'class="highlight1"';
		}

you can also nest the code :p

Like so:

   $varIndicatorClass = "";
   if($vartotal > 30){
		$varIndicatorClass = 'class="highlight"';
		if($vartotal > 34){
			$varIndicatorClass = 'class="highlight2"';
		}
   } else if($vartotal < 20){
        $varIndicatorClass = 'class="highlight1"';
   }
[/CODE]

[+virtorio MVC]

you can also nest the code :p

Like so:

   $varIndicatorClass = "";
   if($vartotal < 20){
		$varIndicatorClass = 'class="highlight"';
		if($vartotal > 30){
			$varIndicatorClass = 'class="highlight2"';
			if($vartotal > 34){
				$varIndicatorClass = 'class="highlight1"';
			}
		}
   }
[/CODE]

That won't work though, it will only go into that block if it's < 20, then you test if it's > 30/34 within that block.

[primexx]

small asthetic thing, why are you doing $var='class="value"' when you can do $var="value" and put the "class=" bit in the html portion itself?

[Seahorsepip Veteran]

That won't work though, it will only go into that block if it's < 20, then you test if it's > 30/34 within that block.

Oops my bad I didn't see the < instead of > :p

fixed it

small asthetic thing, why are you doing $var='class="value"' when you can do $var="value" and put the "class=" bit in the html portion itself?

I wonder about that myself too but maybe he wants to use something else then class on certain values :/

[ZakO]

Oops my bad I didn't see the < instead of > :p

fixed it

Not fixed :p. Nesting

if ($vartotal < 20) {[/CODE]

inside

[CODE]if ($vartotal > 34) {[/CODE]

makes no logical sense.

[+virtorio MVC]

small asthetic thing, why are you doing $var='class="value"' when you can do $var="value" and put the "class=" bit in the html portion itself?

Cells that don't meet those conditions don't have a class.

It's not how I would do it, but it keeps the HTML generation part tidier.

[Seahorsepip Veteran]

Not fixed :p. Nesting

if ($vartotal < 20) {[/CODE]

inside

[CODE]if ($vartotal > 34) {[/CODE]

makes no logical sense.

It's fixed in the original post #5 I can't change the quoted old code in post #6 ;)

[ZakO]

It's fixed in the original post #5 I can't change the quoted old code in post #6 ;)

It's not fixed. Your post #5 is different to the old code in the quote, but the updated code in post #5 is still wrong :p.

[Seahorsepip Veteran]

It's not fixed. Your post #5 is different to the old code in the quote, but the updated code in post #5 is still wrong :p.

Oh damn I really aren't awake right now I guess lol, now it works xD

[threetonesun]

Do you guys all hate switch statements, or something? :laugh:

If you get to if, elseif, elseif, the syntax gets much cleaner if you just move to switch. Plus, if you ever have to stack classes (i.e, > 30 has classes for >30 and > 20), a switch makes it much easier.

[Seahorsepip Veteran]

Do you guys all hate switch statements, or something? :laugh:

If you get to if, elseif, elseif, the syntax gets much cleaner if you just move to switch. Plus, if you ever have to stack classes (i.e, > 30 has classes for >30 and > 20), a switch makes it much easier.

I'm always thinking like if and else if and else in my mind when writing stuff xD

[Laser]

Guys thanks for all the help, I did have to make the adjustment Virtorio posted to make  the cell change when the condition was met.

 

Laser