checkboxes and PHP

June 22, 2003

Hi guys,

I've written a simple script in PHP that allows users to submit their ascii art to the site. Each new submission gets an 'approved' value of 0 until it is reviewed and approved by myself. I've set up a basic admin area that pulls all the records from the database that have not yet been approved and displays them on screen. Below each record is a checkbox with a dynamically generated name in the form: chk[iD], where [iD] is the auto-incremented id of the record.

I'm having trouble determining whether a checkbox has been ticked or not when submitting my form, which queries the database. I've got the following code so far, but it does not seem to work (all checkboxes are read as 'checked'!): :

$approved=0; 

if($_POST['submit']) 
{ 
    $i=0; 

    while($i&lt;$records_size) 
    { 
        $chkBox="chk" .$records[$i]; 

        #if checkbox of current record's id is checked 
        if($chkBox!="") 
        { 
            #create query 
            $sql="UPDATE asciiart SET approved=1 WHERE id=$records[$i]"; 

            #execute query 
            $result=mysql_query($sql,$connection); 

            $approved++; 
        } 

    $i++; 
    } 
        
    $url=$PHP_SELF ."?processed"; 
    print "&lt;html&gt;&lt;head&gt;&lt;meta http-equiv='Refresh' content='1; url=$url'&gt;&lt;/head&gt;&lt;/html&gt;"; 
    die("$approved of $records_size approved"); 
}

The if($chkBox!="") part of the code is obviously what's causing the problem, but I don't know to change it. Were it a VB app I would have done if chkBox[id].checked=false

The main page is at: http://www.cyberiapc.com/asciiart.php and the admin area is at http://www.cyberiapc.com/asciiart_pending.php

I'd appreciate any pointers?

Thanks.

CoreLEx

June 22, 2003

if ( $_POST['checkbox3'] == true ) { do xxxxx }

:)

June 23, 2003

Thanks mr magoo. I'll give it a try and see what happens. :)

June 23, 2003

I tried your suggestion mr magoo, but now all checkboxes are read as "unchecked":

if($_POST['submit'])
{
    $i=0;
    $approved=0;

    #loop for all check boxes
    while($i&lt;$records_size)
    {
        $chkBox="chk" .$records[$i];

        #if checkbox of current record's id is checked 
        if($_POST['$chkBox']==true) 
        { 
            #create query
            $sql="UPDATE asciiart SET approved=1 WHERE id=$records[$i]";

            #execute query
            $result=mysql_query($sql,$connection);

            $approved++;
        }

        $i++;
    }
        
    $url=$PHP_SELF ."?processed";
    print "&lt;html&gt;&lt;head&gt;&lt;meta http-equiv='Refresh' content='1; url=$url'&gt;&lt;/head&gt;&lt;/html&gt;";
    die("$approved of $records_size approved");
}

:pinch:

June 23, 2003

dont you have to qualifity if($_POST['submit']) ??? like if($_POST['submit'] == true) { ???

June 24, 2003

let me see the form im betting its somthing in the form that dont match

June 24, 2003

Here's the code for the script:

&lt;?php

    $connection = @mysql_connect("localhost","user","pass") or die("Sorry, unable to connect to MySQL");

    $result = @mysql_select_db(asciiart,$connection) or die("Sorry, unable to to get database.");

#--------------
# retrieve data
#--------------

$sql="select id,author,title,art,approved from asciiart";
$result=mysql_query($sql,$connection);

$counter=0;

$records=array();

#write the data

echo("&lt;form action=\"$PHP_SELF\" method=post&gt;");
echo("&lt;center&gt;");
echo("&lt;table width=200 border=0 bgcolor=#FFFFFF cellpadding=3 style=\"border: 1px solid #ccd7e0; background-color: #fff;\"&gt;");

while($currentRow = mysql_fetch_array($result))
{
    if($currentRow["approved"]==0)
    {
        echo("&lt;tr&gt;");
        echo("&lt;td width=100%&gt;");
        echo("&lt;font size=\"1\" face=\"verdana\"&gt;");

        echo($currentRow["title"] ."&lt;br&gt;");
        echo("&lt;/font&gt;");

        echo("&lt;font size=\"2\" face=\"verdana\"&gt;");
        echo("&lt;b&gt;" .$currentRow["art"] ."&lt;/b&gt;&lt;br&gt;&lt;br&gt;");
        echo("&lt;/font&gt;");
        echo("&lt;input type=checkbox name=chk" .$currentRow["id"]  ." value=off&gt;");
        echo($currentRow["id"]);

        #store id of records awaiting approval in an array
        $records[$counter]=$currentRow["id"];

        $counter++;

        echo("&lt;/td&gt;");
        echo("&lt;/tr&gt;");

        #seperator cell
        echo("&lt;tr&gt;");
        echo("&lt;td width=100%&gt;");
        echo("&lt;hr width=100% color=#ccd7e0 size=1&gt;");
        echo("&lt;/td&gt;");
        echo("&lt;/tr&gt;");
    }
}

echo("&lt;/tr&gt;");
echo("&lt;/table&gt;");
echo("&lt;/center&gt;");
echo("&lt;br&gt;");
echo("&lt;center&gt;&lt;input type=submit name=submit value=Submit!&gt;&lt;/center&gt;");
echo("&lt;br&gt;");

$records_size=count($records);
echo("&lt;center&gt;Records awaiting approval: " .$records_size ."&lt;/center&gt;");

#--------------
# submit data
#--------------


if($_POST['submit'])
{
    $i=0;
    $approved=0;

    #loop for all check boxes
    while($i&lt;$records_size)
    {
        $chkBox="chk" .$records[$i];

        #if checkbox of current record's id is checked 
        if($_POST['chkBox']) 
        { 
            #create query
            $sql="UPDATE asciiart SET approved=1 WHERE id=$records[$i]";

            #execute query
            $result=mysql_query($sql,$connection);

            $approved++;
        }

        $i++;
    }
}

#close
mysql_close();

?&gt;

June 24, 2003

dont you have to qualifity if($_POST['submit']) ??? like if($_POST['submit'] == true) { ???

nope you don't :p

if ( $_POST['submit'] )

is the same as

if ( $_POST['submit'] == TRUE )

or

if ( !$_POST['submit'] )

is the same as

if ( !$_POST['submit'] == TRUE)

but this will happen only if it exist and there is something in the variable

June 24, 2003

try changing this line:

echo("&lt;input type=checkbox name=chk" .$currentRow["id"]  ." value=off&gt;");

to thie:

echo("&lt;input type=checkbox name='chk" .$currentRow["id"]  ."'&gt;");

and then change the if statement:

       if($_POST['chkBox'])

to this:

       if($_POST['chkBox']=="on")

June 24, 2003

Thanks m0fo. That makes more sense, but unfortunately also does not work as expected. See http://www.cyberiapc.com/asciiart_pending.php

I wish there was a way to debug the script line by line to see why the checkboxes' states are not recognized by the latter part of the code that performs the UPDATE query.

I've been trying a few things in the meantime, but to no avail. :pinch:

Any other suggestions?

CoreLEx

June 29, 2003

anyone? :cry:

June 29, 2003

i suggest you start trying to do one thing, and then expand it, adding loops and the option to do more than one. Try that.

June 29, 2003

Here's the code for the script:

&lt;?php

 ? ?$connection = @mysql_connect("localhost","user","pass") or die("Sorry, unable to connect to MySQL");

 ? ?$result = @mysql_select_db(asciiart,$connection) or die("Sorry, unable to to get database.");

#--------------
# retrieve data
#--------------

$sql="select id,author,title,art,approved from asciiart";
$result=mysql_query($sql,$connection);

$counter=0;

$records=array();

#write the data

echo("&lt;form action=\"$PHP_SELF\" method=post&gt;");
echo("&lt;center&gt;");
echo("&lt;table width=200 border=0 bgcolor=#FFFFFF cellpadding=3 style=\"border: 1px solid #ccd7e0; background-color: #fff;\"&gt;");

while($currentRow = mysql_fetch_array($result))
{
 ? ?if($currentRow["approved"]==0)
 ? ?{
 ? ? ? ?echo("&lt;tr&gt;");
 ? ? ? ?echo("&lt;td width=100%&gt;");
 ? ? ? ?echo("&lt;font size=\"1\" face=\"verdana\"&gt;");

 ? ? ? ?echo($currentRow["title"] ."&lt;br&gt;");
 ? ? ? ?echo("&lt;/font&gt;");

 ? ? ? ?echo("&lt;font size=\"2\" face=\"verdana\"&gt;");
 ? ? ? ?echo("&lt;b&gt;" .$currentRow["art"] ."&lt;/b&gt;&lt;br&gt;&lt;br&gt;");
 ? ? ? ?echo("&lt;/font&gt;");
 ? ? ? ?echo("&lt;input type=checkbox name=chk" .$currentRow["id"] ?." value=off&gt;");
 ? ? ? ?echo($currentRow["id"]);

 ? ? ? ?#store id of records awaiting approval in an array
 ? ? ? ?$records[$counter]=$currentRow["id"];

 ? ? ? ?$counter++;

 ? ? ? ?echo("&lt;/td&gt;");
 ? ? ? ?echo("&lt;/tr&gt;");

 ? ? ? ?#seperator cell
 ? ? ? ?echo("&lt;tr&gt;");
 ? ? ? ?echo("&lt;td width=100%&gt;");
 ? ? ? ?echo("&lt;hr width=100% color=#ccd7e0 size=1&gt;");
 ? ? ? ?echo("&lt;/td&gt;");
 ? ? ? ?echo("&lt;/tr&gt;");
 ? ?}
}

echo("&lt;/tr&gt;");
echo("&lt;/table&gt;");
echo("&lt;/center&gt;");
echo("&lt;br&gt;");
echo("&lt;center&gt;&lt;input type=submit name=submit value=Submit!&gt;&lt;/center&gt;");
echo("&lt;br&gt;");

$records_size=count($records);
echo("&lt;center&gt;Records awaiting approval: " .$records_size ."&lt;/center&gt;");

#--------------
# submit data
#--------------


if($_POST['submit'])
{
 ? ?$i=0;
 ? ?$approved=0;

 ? ?#loop for all check boxes
 ? ?while($i&lt;$records_size)
 ? ?{
 ? ? ? ?$chkBox="chk" .$records[$i];

 ? ? ? ?#if checkbox of current record's id is checked 
 ? ? ? ?if($_POST['chkBox']) 
 ? ? ? ?{ 
 ? ? ? ? ? ?#create query
 ? ? ? ? ? ?$sql="UPDATE asciiart SET approved=1 WHERE id=$records[$i]";

 ? ? ? ? ? ?#execute query
 ? ? ? ? ? ?$result=mysql_query($sql,$connection);

 ? ? ? ? ? ?$approved++;
 ? ? ? ?}

 ? ? ? ?$i++;
 ? ?}
}

#close
:)ysql_close();

?&gt;

Just change if($_POST['chkBox']) to if($_POST[ $chkBox ])

:)

Sign In

checkboxes and PHP

Question

alset_alokin

Link to comment

Share on other sites

12 answers to this question

Recommended Posts

john smith 1924 Veteran

Link to comment

Share on other sites

alset_alokin

Link to comment

Share on other sites

alset_alokin

Link to comment

Share on other sites

john smith 1924 Veteran

Link to comment

Share on other sites

72001

Link to comment

Share on other sites

alset_alokin

Link to comment

Share on other sites

sinatosk

Link to comment

Share on other sites

m0fo

Link to comment

Share on other sites

alset_alokin

Link to comment

Share on other sites

alset_alokin

Link to comment

Share on other sites

john smith 1924 Veteran

Link to comment

Share on other sites

PHPAlien

Link to comment

Share on other sites

Recently Browsing 0 members

Posts

Recent Achievements

Popular Contributors

Tell a friend