37 replies to this topic

[Brodel]

one last question...

I have the option to upload an image, however if nothing is uploaded I get a broken image icon in my post. Is there a way to echo the image if it's present but otherwise leave blank? This is what I have at the moment. I've looked at the !empty function but I'm not sure how to implement it or if it's the right way to do it in this case.

//Outputs the image and other data
echo "<h4></b> ".$info['title'] . "</h4>";
echo "<b><h6></b> ".$info['date']."</h6><br>";
echo "<p><img src=/blogimages/".$info['photo'] . "></p><br>";
echo "<b><p></b> ".$info['text'] . "<p><br>";
echo "<div class='blogspacer'></div>";

[Tjcool007]

you could do something like

if(isset($info['photo']))
{
	echo "<p><img src='/blogimages/" . $info['photo'] . "' /></p><br />";
}
else
{
	echo "<p><img src='/blogimages/noimage.png' /></p><br />";
}

That would echo "noimage.png" instead if no image is there.
That's assuming the $info['photo'] var is empty when there's nothing uploaded.
Else you'll need a file_exists() call.

Also, some of your HTML in the post above is incorrect. You are closing the <b> before closing the tag inside, like here:

echo "<b><h6></b>" . $info['date'] . "</h6><br>";

Should probably be this:

echo "<b><h6>" . $info['date'] . "</h6></b><br>";

[Brodel]

Thanks, so I could just make a small noimage.png that is just the same colour as my background, right? Then there would technically be an image there, but it would look blank.

thanks for pointing out the mistake also

[The_Decryptor]

Or you could just not write anything out, save loading a blank image from the server.

Edit: Also, the mysql_ API is deprecated (and for an old version of MySQL), if you're writing brand new code now either use the mysqli library, or PDO.

[threetonesun]

if you're trying to maintain formatting consistency, use an empty <div> instead of a blank image if there's no image.

[Brodel]

I have added a transparent noimage.png to the blogimages folder and tried the above code as well as a blank div, but each time I make a post with no image there is still a broken image link. Am I adding it incorrectly or something?

//Puts it into an array
while($info = mysql_fetch_array( $data ))
{
//Outputs the image and other data
echo "<h4></b> ".$info['title'] . "</h4>";
echo "<b><h6>".$info['date']."</h6></b><br>";
if(isset($info['photo']))
{
		echo "<p><img src=/blogimages/" . $info['photo'] . " /></p><br />";
}
else
{
		echo "<p><img src='/blogimages/noimage.png' /></p><br />";
}
echo "<b><p></b> ".$info['text'] . "<p><br>";
echo "<div class='blogspacer'></div>";
}

If it makes any difference, in chrome and ie the broken image icon shows. In firefox it doesn't.


Is it a change I need to make to my addblog.php also?

  //This gets all the other information from the form
		$title=$_POST['title'];
		$date= date("d F Y H:i:s");
		$photo=($_FILES['photo']['name']);
		$text=$_POST['text'];
  
  
		//This keeps the formatting of text entered into the text area
		$text=nl2br($text);

		// Connects to your Database
		mysql_connect("localhost:8888","Alexweb","*****") or die(mysql_error()) ;
   mysql_select_db("Alexweb") or die(mysql_error()) ;
  
		//Writes the information to the database
		mysql_query("INSERT INTO `blogentries` VALUES ('$title', '$date', '$photo', '$text')") ;


		//Writes the photo to the server
		if(move_uploaded_file($_FILES['photo']['tmp_name'], $target))
		{
  

		//Tells you if its all ok
		echo "<h4>The photo ". basename( $_FILES['uploadedfile']['name']). " has been uploaded, and your entry has been added to the blog" ;
		echo '<br><a href="http://www.mywebsite.com/blog2.php"> Click here to view</a>';
		}
		else {
	   //Gives an error if its not
		echo "<h4>thanks for your entry .";
	 echo '<br><a href="http://www.mywebsite.com/blog2.php"> Click here to view</a>';
		}

[threetonesun]

I assume it doesn't work if you post an image, either, as you've got quotes all over the place there. This line:

echo "<p><img src=/blogimages/" . $info['photo'] . " /></p><br />";

Should be

echo '<p><img src="/blogimages/' . $info['photo'] . '"/></p><br />';

To make things easier to read, you might want to use single quotes with PHP, double quotes with HTML.
Also, is the noimage.png in the correct place?

[Brodel]

if I include an image it does work and uploads it to blogimages. There is definitely a noimage in the correct place.

Yea, I really need to tidy things up. It's getting a bit of a mess, still getting he hang of integrating the html and php, as you can tell, lol.

[threetonesun]

I suspect that $photo=($_FILES['photo']['name']); does not return FALSE if there is no image. You should check if $_FILES['photo'] is set, and then assign it to $photo, which should by default be set to FALSE.

[winlonghorn]

What about settting the image src to "./blogimages/"?

[Brodel]

threetonesun, on 18 April 2012 - 13:18, said:

I suspect that $photo=($_FILES['photo']['name']); does not return FALSE if there is no image. You should check if $_FILES['photo'] is set, and then assign it to $photo, which should by default be set to FALSE.

i'm not entirely sure what you mean. i don't want to keep bugging people with basic questions though so i'll do a bit of googling. thanks again for your help

[Brodel]

winlonghorn, on 18 April 2012 - 13:36, said:

What about settting the image src to "./blogimages/"?

Thanks, I tried that but still have the same issue.

[winlonghorn]

Brodel, on 18 April 2012 - 13:40, said:

Thanks, I tried that but still have the same issue.

Ok, sorry that it didn't work. I just figured it wasn't finding it because the path wasn't starting from the parent directory. I apologize that I couldn't be more helpful.

[Brodel]

winlonghorn, on 18 April 2012 - 13:42, said:

Ok, sorry that it didn't work. I just figured it wasn't finding it because the path wasn't starting from the parent directory. I apologize that I couldn't be more helpful.

No worries. It's all worth trying for me

[winlonghorn]

Brodel, on 18 April 2012 - 13:37, said:

i'm not entirely sure what you mean. i don't want to keep bugging people with basic questions though so i'll do a bit of googling. thanks again for your help

I think this is what he means:

if(isset($_FILES['photo']))
{
	$photo = $_FILES['photo'];
}

Brodel, on 18 April 2012 - 13:44, said:

No worries. It's all worth trying for me

True. It is a learning experience.