• 0

C# Better & more efficient way to load DLL dynamically & get interf


Question

Hi,

Been using the code below to load a dll dynamically and get an instance of certain interface. This was done way back in .NET 2 days. What is a better & more efficient way to do this using .NET 4 functionality?


// Usage
ICountryHandler pCountryHandler = GetInstanceFromModule<ICountryHandler>("Company.Product.Country.Australia.dll");

public static TInterface GetInstanceFromModule<TInterface>(string AModuleName)
where TInterface : class
{
Assembly pAssembly;
ConstructorInfo pConstructor;
TInterface pInstance;
Type pInterface;
pAssembly = null;
if (AModuleName.Contains(Path.DirectorySeparatorChar.ToString()) || AModuleName.Contains(Path.AltDirectorySeparatorChar.ToString()) || AModuleName.Contains(Path.PathSeparator.ToString()) || AModuleName.Contains(Path.VolumeSeparatorChar.ToString()))
{
pAssembly = Assembly.LoadFrom(AModuleName);
}
else
{
pAssembly = Assembly.LoadFrom(Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), AModuleName));
}
if (pAssembly != null)
{
foreach (Type pType in pAssembly.GetExportedTypes())
{
pInterface = pType.GetInterface(typeof(TInterface).ToString());
if (pInterface != null)
{
pConstructor = pType.GetConstructor(new Type[] { });
pInstance = pConstructor.Invoke(null) as TInterface;
if (pInstance != null)
{
return pInstance;
}
}
}
}
return null;
}
[/CODE]

TA :)

10 answers to this question

Recommended Posts

  • 0


pInterface = pType.GetInterface(typeof(TInterface).ToString());
if (pInterface != null)[/CODE]

I take it this tests if pType implements TInterface? I'd do:

[CODE]if (typeof(TInterface).IsAssignableFrom(pType))[/CODE]

Also rather than getting the default constructor and invoking explicitely, you could use Activator for that:

[CODE]
pConstructor = pType.GetConstructor(new Type[] { });
pInstance = pConstructor.Invoke(null) as TInterface;

// instead do
pInstance = (TInterface)Activator.CreateInstance(pType);[/CODE]

No need to use [font=courier new,courier,monospace]as[/font] and check for null since you just checked that pType implements TInterface: the cast must necessarily succeed.

None of this is .NET 4-specific but might allow you to cut down the number of lines a bit.

  • 0

You should divide that method into smaller methods - one to get the assembly from a string, one to get all types implementing an interface, and one to create an instance of all these types.

Your check for absolute path can be replaced with Path.IsPathRooted().

Also, stop using Hungarian notation...especially if you're not actually using the prefix but just using "p" at the beginning of everything. It's both ugly and useless. ( see http://msdn.microsoft.com/en-us/library/vstudio/ms229045.aspx - "Do not use Hungarian notation").

  • 0

Actually the biggest efficiency gains here would be by caching the results. Iterating all the types in an assembly can take a long time and you're doing it every time the method is called. Of course, measure your gains - how much time this method currently takes and how much you're saving (or wasting!) by doing things differently. You might find out this method takes an insignificant amount of time and you're just worrying for nothing.

  • Like 1
  • 0
  On 04/10/2012 at 07:58, Dr_Asik said:

Iterating all the types in an assembly can take a long time and you're doing it every time the method is called.

(Y)

Unless it's a once-off thing - then it's probably not worth overcomplicating it.

And just for fun, here's a LINQ version:

(PS: If you often need to test code snippets (not necessarily LINQ-related), LINQPad is invaluable)


public static TInterface GetInstanceFromModule<TInterface>() where TInterface : class
{
// Change this to load assembly from file
var pAssembly = Assembly.GetAssembly(typeof(TInterface));

// Magic!
if (pAssembly != null)
return pAssembly.GetExportedTypes()
.Where(t => t.IsClass)
.Where(t => typeof(TInterface).IsAssignableFrom(t))
.Select(t => (TInterface)Activator.CreateInstance(t))
.FirstOrDefault();

return null;
}
[/CODE]

Edit: It doesn't really increase efficiency, but does make it a lot easier on the eyes. And [i]slightly[/i] harder to debug :p

Edited by GreenMartian
  • 0

Thanks guys.

I am using hungarian notations as that is the coding practices where I work and I gotta follow their guidelines. I am going to implement few of these suggestions and see how things go. I am only calling this once for each DLL that I want to load and once they are loaded that is it.

I read somewhere to use newly introduced dynamic key word and use managed extensibility framework but I am stuck there... Any advice on that would be useful too.

Cheers :)

  • 0

Ah, didn't realise MEF is now built into .NET 4.

From your example, it looks like you're looking more into Dependency Injection (DI). From what I remember, MEF does it to some extent, but is more geared towards supporting extensions (I haven't actually used it, but did some reading on it a couple years ago, so feel free to correct me).

There are multiple frameworks that provide DI Containers. Personally, I've only used Castle Windsor. There's also Unity, and a few others.

Setup properly, DI containers make it ridiculously easy to inject interface implementations to other classes.

In a nutshell, you basically tell it once, at the start of your app, to load a config from an xml file like so:

container.Install(Configuration.FromXmlFile("settings.xml")

With the xml file looking something like

&lt;configuration&gt;
&lt;components&gt;
  &lt;component service="Namespace.ICountryHandler, AssemblyNameOfInterface"
	type="Namespace.AustralianHandler, AssemblyNameOfImplementor" /&gt;
&lt;/components&gt;
&lt;/configuration&gt;

And everywhere else in the code when you have a property of type ICountryHandler, you'll get the Australian handler.

PS: Thanks for mentioning MEF. I might revisit it and see what MS have been up to. There goes my weekend!

This topic is now closed to further replies.
  • Posts

    • Russia is based in Cyprus. AdGuard is about as Russian as Telegram is.
    • Pixel Recall anyone? Or LiveRecall, OpenRecall or WindRecorder? Someone, somewhere wants your data.
    • HP 15.6-inch laptop is 20 percent off for students and everyday users by Paul Hill If you’re a student or casual user, this HP 15.6-inch laptop (model 15-fc0499nr) may be a good fit for you, as it has been discounted by 20% from $499.99 to just $399.99. It’s not a cutting-edge machine, but at this price, its core specs are solid, making it a great back-to-school option. It’s worth pointing out that this laptop carries an Amazon’s Choice badge and has over 1,000 purchases in just the last month, highlighting its popularity. Next, we'll discuss the specifications, followed by a buying link if you're interested in purchasing it. Powering this laptop is an AMD Ryzen 5 7520U processor, 8GB of LPDDR5 RAM, and a 512GB PCIe NVMe M.2 SSD. These aren’t the highest specs ever, but for everyday tasks, you should get your tasks done efficiently. The inclusion of the SSD means your system will boot quickly and your apps will launch fast, even if launching for the first time. It has a 15.6-inch HD touchscreen display, which is a key feature and a pretty big deal at this price point. If you find yourself with a task where a mouse isn’t suited, just touch the screen instead; it seems pretty useful for graphics work if you need to do some. One shortcoming of this device is that it uses integrated AMD Radeon Graphics, which is enough for casual entertainment and light creative work, but don’t expect to be playing heavy games. As for the operating system, this laptop ships with Windows 11 Home. It’s worth pointing out here that this is not a Copilot+ PC, so it will be missing Recall and other AI features, but it does have a Copilot key. This laptop is great if you’re going to be taking it to school or college, as it’s lightweight at just 3.52 lbs (1.6kg). It also has decent connectivity with 1 USB Type-C (data transfer only), 2 USB Type-A, 1 HDMI 1.4b, and a headphone/microphone combo jack. It also features Wi-Fi 6 and Bluetooth 5.3 for modern connectivity. Other notable features include the HP True Vision 720p HD camera with noise reduction for video calls and a camera privacy shutter. The laptop also has a long-lasting battery life of up to 12 hours and supports Fast Charge, which gets you to 50% in 45 minutes. If you’re convinced by this solid entry-level laptop, check out the buying link below: HP 15.6-inch laptop (model 15-fc0499nr): $399.99 (Amazon US) / MSRP $499.99 This Amazon deal is US-specific and not available in other regions unless specified. If you don't like it or want to look at more options, check out the Amazon US deals page here. Get Prime (SNAP), Prime Video, Audible Plus or Kindle / Music Unlimited. Free for 30 days. As an Amazon Associate, we earn from qualifying purchases.
    • Install a cheap Chinese clone of Adguard and then take support from call center to restore to Windows XP.
    • Does the job, although it can't run windows 11 officially. Currently running Windows 10 modded with ReviOS
  • Recent Achievements

    • Dedicated
      Snake Doc earned a badge
      Dedicated
    • One Month Later
      Philsl earned a badge
      One Month Later
    • One Year In
      armandointerior640 earned a badge
      One Year In
    • One Month Later
      armandointerior640 earned a badge
      One Month Later
    • Week One Done
      Itbob513626 earned a badge
      Week One Done
  • Popular Contributors

    1. 1
      +primortal
      614
    2. 2
      ATLien_0
      236
    3. 3
      Xenon
      155
    4. 4
      +FloatingFatMan
      123
    5. 5
      Michael Scrip
      116
  • Tell a friend

    Love Neowin? Tell a friend!