Help with PHP/mySQL script

[Nashy]

I have a script that I've had made for a site I look after, and the coder has created it in a way where it doesn't look to make modifying the design of it all that easy.

It is full PHP, he hasn't added any HTML apart from in the echo.

I know nothing about PHP, hence I asked for this to be made.

The below snippet of code is what I mean, and I'm wondering how I would go about making it so it is a basic HTML file, calling the mySQL data from the DB.

function printlogo($data){

  $teamA = getTeamA($data);
  $teamB = getTeamB($data);

  echo "<tr><td align='center' width='35' height='40'><img src='".getLogo($teamA)."'></td><td align='center' width='30'></td><td align='center' width='35'><img src='".getLogo($teamB)."'></td></tr>";
}
[/CODE]

I appreciate any help. I'm happy to send the file for anyone to look over and provide help.

Thanks in advance.

[Haggis Veteran]

function printlogo($data){
  $teamA = getTeamA($data);
  $teamB = getTeamB($data);
}
[/CODE]

[CODE]
<tr>
<td align='center' width='35' height='40'>
<img src="<?php printlogo($teamA) ?>" />
</td>
<td align='center' width='30'></td>
<td align='center' width='35'>
<img src="<?php printlogo($teamB) ?>" /></td>
</tr>
[/CODE]

should work :)

also you had Function printlogo but the html had getlogo

[Nashy]

function printlogo($data){
  $teamA = getTeamA($data);
  $teamB = getTeamB($data);
}
[/CODE]

[CODE]
<tr>
<td align='center' width='35' height='40'>
<img src="<?php printlogo($teamA) ?>" />
</td>
<td align='center' width='30'></td>
<td align='center' width='35'>
<img src="<?php printlogo($teamB) ?>" /></td>
</tr>
[/CODE]

should work :)

also you had Function printlogo but the html had getlogo

That doesn't seem to do anything for me. When I test it, it doesn't show anything.

Here is a bigger section of the code, I'm not sure if there is more there that could be of use.

[CODE]
/**
*
* Returns first team's name
*/

function getTeamA($data){
return $data['team1'];
}


/**
*
* Returns second team's name
*/

function getTeamB($data){
return $data['team2'];
}

function getScoreA($data){
return $data['score1'];
}

function getScoreB($data){
return $data['score2'];
}

function getLogo($team){
$team=strtolower($team);
return "images/$team.png";
}

function printlogo($data){

$teamA = getTeamA($data);
$teamB = getTeamB($data);

echo "<tr><td align='center' width='35' height='40'><img src='".getLogo($teamA)."'></td><td align='center' width='30'></td><td align='center' width='35'><img src='".getLogo($teamB)."'></td></tr>";
}
[/CODE]

[Haggis Veteran]

i assume it works prior to that change?

u really need to paste the entire code so we can see what its doing

[Nashy]

Hi there.

Here is the entire code:

<!--Live Scores-->
<?PHP

include('library/database.php');
$db = new database();

/****
  * If no match is defined to be showed
  * Chooses the first match from the list
  *
  */

function randomMatch()
{
  $match=-1;
  $q = "SELECT * FROM game WHERE active = '1'";
  $r = mysql_query($q) or die("Error in selecting first match: ".mysql_error());
  if(mysql_num_rows($r)==0){
   echo "NO MATCH IS CURRENTLY ACTIVE!";
   exit;
  }

  while($row = mysql_fetch_array($r)){
   $match = $row['id'];
   break;
  }
  return $match;
}

/**
  *
  *
  *
  */

function thisMatch(){
   return $_REQUEST['match'];
}

/**
  *
  * Returns Id of the current match.
  * if an id is specified then thisMatch();
  * else randomMatch is called
  *
  */

function getId(){
  $id=-1;
  if(!isset($_REQUEST['match'])){   //GET parameter null
   $id = randomMatch();
  }
  else $id = thisMatch();

  if($id==-1){
   reportExit();
   return -1;
  }
  return $id;
}

/**
  *
  * Data variable keeps the data of the row with fixed id
  *
  */

function fetchData(){
  $id = getId();

  if($id==-1)return -1;
  $q1 = "SELECT * FROM game WHERE id = '$id'";
  $r1 = mysql_query($q1) or die("Error in fetching first active match, Level: 1:: ".mysql_error());
  $data = mysql_fetch_assoc($r1) or die("Error in fetching first active match, Level: 2:: ".mysql_error());;
  return $data;
}

/**
  *
  * If No match is currently active, do exit
  *
  */

function reportExit(){
   echo "No match is currently active!";
   exit;
}

/**
  *
  * Returns first team's name
  */

function getTeamA($data){
  return $data['team1'];
}


/**
  *
  * Returns second team's name
  */

function getTeamB($data){
  return $data['team2'];
}

function getScoreA($data){
  return $data['score1'];
}

function getScoreB($data){
  return $data['score2'];
}

function getLogo($team){
  $team=strtolower($team);
  return "images/$team.png";
}

function printlogo($data){

  $teamA = getTeamA($data);
  $teamB = getTeamB($data);

  echo "<tr><td align='center' width='35' height='40'><img src='".getLogo($teamA)."'></td><td align='center' width='30'></td><td align='center' width='35'><img src='".getLogo($teamB)."'></td></tr>";
}

function printName($data){

  $teamA = "<B>".getTeamA($data)."</B>";
  $teamB = "<B>".getTeamB($data)."</B>";

  echo "<tr><td align='center' width='35' height='40'>$teamA</td><td align='center' width='30'></td><td align='center' width='35'>$teamB</td></tr>";
}

function printScore($data){

  $scoreA = "<B>".getScoreA($data)."</B>";
  $scoreB = "<B>".getScoreB($data)."</B>";

  echo "<tr><td align='center' width='35' height='40'>$scoreA</td><td align='center' width='30'></td><td align='center' width='35'>$scoreB</td></tr>";
}

function printPlayers($data,$id){
  echo "<TD width='35%' style='border:0' valign='top'>";
   $var = 'player'.$id;
   $str = $data[$var];
   $ar  = explode(',',$str);
   foreach($ar as $ars){
    $ars = ltrim($ars);
    echo "   ".$ars."<BR>";
   }
  echo "</TD>";
}

function printLocation($data){
  $location = $data['location'];
  $time	 = $data['time'];
  echo "<TD style='margin:5; border:0' width='30%' align='center' valign='middle'>$location<BR>$time<BR>";
  $str	  = $data['link'];
  $links=explode(',',$str);
  foreach($links as $link){
   echo "<a href=$link>".$link."</a><BR>";
  }
  echo "<BR>Currently Active Games:<BR>";
  $q = "SELECT * FROM game WHERE active = '1'";
  $r = mysql_query($q) or die("Erro in selecting active games on line: 152".mysql_error());
  while($row=mysql_fetch_array($r)){
   echo "<a href='index.php?match=".$row['id']."'>".$row['team1']." VS ".$row['team2']."</a><BR>";
  }
  echo "</TD>";
}

function printTime(){
}

function listPlayer($data){
  echo "<TR>";
   printPlayers($data,1);
   printLocation($data);
   printPlayers($data,2);
  echo "</TR>";
}

function printData($data){
  printlogo($data);
  printName($data);
  printScore($data);
  listplayer($data);
}

function printNote($id){
  $q = "SELECT * FROM notes WHERE gameid='$id' ORDER BY id DESC";
  $r = mysql_query($q) or die("Error in PrintNote:: ".mysql_error());
  while($row=mysql_fetch_array($r)){
  $time = $row['time'];
  $note = $row['body'];
  echo '<tr><td width="100%" colspan="3"><B>'; 
  $fDigit = $time{0};
  if($fDigit>='0'&&$fDigit<='9'){
   if($time%10==1&&$time!=11)echo $time."st Minute";
   else if($time%10==2&&$time!=12)echo $time."nd Minute";
   else echo $time."th Minute";
  }
  else echo $time;

  echo "</B><BR>$note</td></tr>";
  echo "<tr style='border:0' colspan='3'><td style='border:0'> </td></tr>";
  }
}

echo "<table align='center' border='1' width='1000'>";
$data=fetchData();
printData($data);
printNote($data['id']);
echo "</table>";
?>
[/CODE]

Thanks :)

[Haggis Veteran]

i am at work so cant test anything really lol

try

<tr>
<td align='center' width='35' height='40'>
<img src="<?php echo printlogo($teamA); ?>" />
</td>
<td align='center' width='30'></td>
<td align='center' width='35'>
<img src="<?php echo printlogo($teamB); ?>" /></td>
</tr>
[/CODE]

[Nashy]

That's also not working.

[Haggis Veteran]

<tr>
<td align='center' width='35' height='40'>
<img src="<?php echo getLogo($teamA); ?>" />
</td>
<td align='center' width='30'></td>
<td align='center' width='35'>
<img src="<?php echo getLogo($teamB); ?>" /></td>
</tr>
[/CODE]

[Nashy]

That does give a result, but doesn't show any images.

http://live.thenashy.com/test.php

[+theblazingangel MVC]

<snipped>

function getTeamA($data){
  return $data['team1'];
}

function getTeamB($data){
  return $data['team2'];
}

function getLogo($team){
  $team=strtolower($team);
  return "images/$team.png";
}

function printlogo($data){

  $teamA = getTeamA($data);
  $teamB = getTeamB($data);

  echo "<tr><td align='center' width='35' height='40'><img src='".getLogo($teamA)."'></td><td align='center' width='30'></td><td align='center' width='35'><img src='".getLogo($teamB)."'></td></tr>";
}

function printName($data){

  $teamA = "<B>".getTeamA($data)."</B>";
  $teamB = "<B>".getTeamB($data)."</B>";

  echo "<tr><td align='center' width='35' height='40'>$teamA</td><td align='center' width='30'></td><td align='center' width='35'>$teamB</td></tr>";
}

function printData($data){
  printlogo($data);
  printName($data);
  printScore($data);
  listplayer($data);
}

echo "<table align='center' border='1' width='1000'>";
$data=fetchData();
printData($data);
printNote($data['id']);
echo "</table>";
?>
[/CODE]


[b]Note:[/b] do NOT replace the code you posted with the above, I just snipped it down to some of the bits you need to focus on here to understand why Haggis's code will not work and how to fix it!
[CODE]
function printlogo($data){
  $teamA = getTeamA($data);
  $teamB = getTeamB($data);
}
[/CODE]

[CODE]
<tr>
<td align='center' width='35' height='40'>
<img src="<?php printlogo($teamA) ?>" />
</td>
<td align='center' width='30'></td>
<td align='center' width='35'>
<img src="<?php printlogo($teamB) ?>" /></td>
</tr>
[/CODE]


[CODE]
<tr>
<td align='center' width='35' height='40'>
<img src="<?php echo printlogo($teamA); ?>" />
</td>
<td align='center' width='30'></td>
<td align='center' width='35'>
<img src="<?php echo printlogo($teamB); ?>" /></td>
</tr>
[/CODE]


[CODE]
<tr>
<td align='center' width='35' height='40'>
<img src="<?php echo getLogo($teamA); ?>" />
</td>
<td align='center' width='30'></td>
<td align='center' width='35'>
<img src="<?php echo getLogo($teamB); ?>" /></td>
</tr>
[/CODE]


That does give a result, but doesn't show any images.
http://live.thenashy.com/test.php

The primary flaw in Haggi's code in all three of the above posts is that of scope. The variables $teamA and $teamB only exist [u]within[/u] the printLogo() and printName() functions, not outside of them! Therefore Haggi's code, which exists outside of these functions, tries to use the content of these variables and fails to work.
Additionally, all of the functions in the snipped down set of code (snipped down to show only stuff related to Haggis's code), with the exception of getLogo(), expect to be given a copy of the $data variable, which holds the entire row of data from the database (as an "array"), while Haggis's code is incorrectly trying to give them a variable containing only a team name.
Hence why the HTML in your test page only contains <img src="images/.png"></img> instead of something like <img src="images/brisbane broncos.png"></img>, it's unable to get the name of the team due to incorrect use of the functions your developer created.
The correct code would be:
[code]
<tr>
	<td align='center' width='35' height='40'>
		<img src="<?php getLogo(getTeamA($data)) ?>" />
	</td>
	<td align='center' width='30'></td>
	<td align='center' width='35'>
		<img src="<?php getLogo(getTeamB($data)) ?>" />
	</td>
</tr>

This makes the printLogo() function redundant btw. The whole purpose of the printLogo() function is to generate a snippit of HTML code to display a logo, but this replaces that, so you can get rid of it.

What is happening here (assuming the OP needs it explaining), is we are calling the getTeamA() and getTeamB() functions respectively, passing in the entire $data variable, as they expect. These functions return the team name from the $data variable. This return value is then given to getLogo() which puts together and returns the url for the image file.

Really, url's shoud be encoded, so replace the getLogo() function with:

function getLogo($team){
  return rawurlencode("images/" . strtolower($team) . ".png");
}

[palenous]

Most of what theblazingangel said is correct, but the final product he gave you is not... There were definitely some redundancies in the code and it was far from professionally done, but the image name still needs echoed out. You only return data that you want echoed out when you are calling the function from within an echo statement:

function getLogo($team){
return rawurlencode("images/" . strtolower($team) . ".png");
}
<tr>
		<td align='center' width='35' height='40'>
				<img src="<?php echo (getLogo(getTeamA($data))); ?>" />
		</td>
		<td align='center' width='30'></td>
		<td align='center' width='35'>
				<img src="<?php echo (getLogo(getTeamB($data))); ?>" />
		</td>
</tr>
[/CODE]

Otherwise, the code will not output as you would like it to. Another option is to leave the html as is, and change the return statement to an echo statement:

[CODE]
function getLogo($team){
echo rawurlencode("images/" . strtolower($team) . ".png");
}
[/CODE]

After doing one of those two options, you shouldn't have any more issues.

[+theblazingangel MVC]

but the image name still needs echoed out

oops, good spot!

[palenous]

oops, good spot!

Thanks. :) You did an awesome job explaining it though. Very thorough and easy to follow!