• 0

Why won't my CSS work?

Asked by Nashy,

 Share

Question

Grand Master

Nashy

Posted
Posted

Hi all. I'm having a bit of trouble with some CSS not working, and I'm unable to see why. I'm not a CSS guru by any means, so no doubt it's something really simple that I've missed.

Also, before anyone vomits at the use of tables, they're only used because this particular page is not going to be used by many people, and I'm not the greatest with DIVs so I didn't really have the time. (I'm still learning how to use DIVs correctly).

Anyway, it's a bit of a mess given I have been trying different thigns, so I'd relaly appreciate anyone who could take a look and guide me in the right direction.

Note: I've included all the PHP that I've had made for me, just in case it is something to do with that.



<head>
<link href="css.css" rel="stylesheet" type="text/css" />
</head>
<!--Bismillahir Rahmanir Rahim-->
<?PHP

include('library/database.php');
$db = new database();
/****
  * If no match is defined to be showed
  * Chooses the first match from the list
  *
  */

function randomMatch()
{
  $match=-1;
  $q = "SELECT * FROM game WHERE active = '1'";
  $r = mysql_query($q) or die("Error in selecting first match: ".mysql_error());
  if(mysql_num_rows($r)==0){
   echo "NO MATCH IS CURRENTLY ACTIVE!";
   exit;
  }

  while($row = mysql_fetch_array($r)){
   $match = $row['id'];
   break;
  }
  return $match;
}

/**
  *
  *
  *
  */

function thisMatch(){
   return $_REQUEST['match'];
}

/**
  *
  * Returns Id of the current match.
  * if an id is specified then thisMatch();
  * else randomMatch is called
  *
  */

function getId(){
  $id=-1;
  if(!isset($_REQUEST['match'])){   //GET parameter null
   $id = randomMatch();
  }
  else $id = thisMatch();

  if($id==-1){
   reportExit();
   return -1;
  }
  return $id;
}

/**
  *
  * Data variable keeps the data of the row with fixed id
  *
  */

function fetchData(){
  $id = getId();

  if($id==-1)return -1;
  $q1 = "SELECT * FROM game WHERE id = '$id'";
  $r1 = mysql_query($q1) or die("Error in fetching first active match, Level: 1:: ".mysql_error());
  $data = mysql_fetch_assoc($r1) or die("Error in fetching first active match, Level: 2:: ".mysql_error());;
  return $data;
}

/**
  *
  * If No match is currently active, do exit
  *
  */

function reportExit(){
   echo "No match is currently active!";
   exit;
}
/**
  *
  * Returns first team's name
  */

function getTeamA($data){
  return $data['team1'];
}

/**
  *
  * Returns second team's name
  */

function getTeamB($data){
  return $data['team2'];
}

function getScoreA($data){
  return $data['score1'];
}

function getScoreB($data){
  return $data['score2'];
}

function getLogo($team){
  $team=strtolower($team);
  return "images/$team.png";
}

function printPlayers($data,$id){
   $var = 'player'.$id;
   $str = $data[$var];
   $ar  = explode(',',$str);
   foreach($ar as $ars){
    $ars = ltrim($ars);
    echo "   ".$ars."<BR>";
   }
}

function printActiveGames($data){
  $links = $data['link'];
  $links = explode(',',$links);
  echo "<BR>";

  foreach($links as $link){
   echo "<a href=$link>".$link."</a><BR>";
  }
  echo "<BR>Currently Active Games:<BR>";
  $q = "SELECT * FROM game WHERE active = '1'";
  $r = mysql_query($q) or die("Error in selecting active games on line: 152".mysql_error());
  while($row=mysql_fetch_array($r)){
   echo "<a href='index.php?match=".$row['id']."'>".$row['team1']." VS ".$row['team2']."</a><BR>";
  }
}

function printNote($id){
  $q = "SELECT * FROM notes WHERE gameid='$id' ORDER BY id ASC";
  $r = mysql_query($q) or die("Error in PrintNote:: ".mysql_error());
  while($row=mysql_fetch_array($r)){
  $time = $row['time'];
  $note = $row['body'];
  echo '<tr><td id="notetime">'; 
  $fDigit = $time{0};
  if($fDigit>='0'&&$fDigit<='9'){
   if($time%10==1&&$time!=11)echo $time."st Minute";
   else if($time%10==2&&$time!=12)echo $time."nd Minute";
   else echo $time."th Minute";
  }
  else echo $time;

  echo "</TD><TD id='note'>$note</td></tr>";
  echo "<tr style='border:0'><td style='border:0' colspan='2' width='100%'> </td></tr>";
  }
}

$data=fetchData();

$location = $data['location'];
$time	 = $data['time'];
$str	  = $data['link'];
$links    = explode(',',$str);

$teamA = getTeamA($data);
$teamB = getTeamB($data);

$scoreA = getScoreA($data);
$scoreB = getScoreB($data);
$logoA  = getLogo($teamA);
$logoB  = getLogo($teamB);
?>
<html>
<body>
<table align='center' border='0' width='600'>
<tr>
<td id="hometeam"><img src='<?PHP echo $logoA?>'></td>
<td align='center' width='30'>Vs</td>
    <td id="awayteam"><img src='<?PHP echo $logoB?>' ></td></tr>
<tr>
<td class="teamtext"><?PHP echo $teamA?></td>
    <td align='center' width='30'></td>
    <td class="teamtext"><?PHP echo $teamB?></td>
</tr>

<tr class="teamtext">
<td class="score"><?PHP echo $scoreA?></td>
    <td> </td>
    <td><?PHP echo $scoreB?></td>
</tr>
<tr class="players">
<td><?PHP printPlayers($data,1);?></td>
    <td><?PHP echo $location."<br>".$time;printActiveGames($data)?></td>
    <td><?PHP printPlayers($data,1)?></td>
</tr>
<tr>
<td height="113" colspan="3"><div><table border='0' width='100%'>
<tr>
  <td id="notetime2"> </td>
  <td id="note2"> </td>
</tr>
<?PHP printNote($data['id'])?></table></div></td></tr>
</table>
</body>
</html>
[/CODE]

[CODE]
@charset "utf-8";
/* CSS Document */
/* User Side Below */
#overall_container {
width: 600px;
vertical-align:top;
margin: auto;
z-index:2;
border:#000;
font-family: Calibri, Verdana, Geneva, sans-serif;
font-size: 12px;
}
#hometeam {
width: 250px;
vertical-align:middle;
margin:auto;
background-color:#EEEEEE;
text-align:center;
float:left;
border:none;
}
#awayteam {
width: 250px;
vertical-align:middle;
margin:auto;
background-color:#EEEEEE;
text-align:center;
float:left;
border:none;
}
#vsbox {
width: 100px;
vertical-align:middle;
margin:auto;
background-color:#EEEEEE;
text-align:center;
float:left;
border:none;
font-family: Calibri, Verdana, Geneva, sans-serif;
font-size: 12px;
}
#location {
width: 400px;
vertical-align:middle;
background-color:#EEEEEE;
text-align:center;
margin-left: Auto;
margin-right: Auto;
border:none;

}
#notetime {
width: 30%;
font-family: Calibri, Verdana, Geneva, sans-serif;
font-size: 11px;
font-style:italic;
background-color:#C9FCCD;
border:none;
padding:0px;
}
#note {
width: 100%;
font-family: Calibri, Verdana, Geneva, sans-serif;
font-size: 12px;
background-color:#C4FA8D;
padding:0px;
}
/* Admin Panel Below */
#overall_pass {
width: 60%;
}
#login_title {
font-family: Calibri, Verdana, Geneva, sans-serif;
font-size: 14px;
font-weight: bolder;
background-color: #036;
color: #CCC;
text-align: center;
.team {
font-family: Verdana, Geneva, sans-serif;
}
/* Fonts */
.teamtext {
font-family: Calibri, Verdana, Geneva, sans-serif;
font-size: 16px;
font-weight: Bolder;
text-align:center;
}
#teamtext {
font-family: Calibri, Verdana, Geneva, sans-serif;
font-size: 16px;
font-weight: Bolder;
text-align:center;
}
.regulartext {
font-family: Calibri, Verdana, Geneva, sans-serif;
font-size: 14px;
text-align:center;
}
.players {
font-family: Calibri, Verdana, Geneva, sans-serif;
font-size: 12px;
text-align:left;
}
.score {
font-family: Calibri, Verdana, Geneva, sans-serif;
font-size: 22px;
text-align:centre;
}
[/CODE]

Link to comment
https://www.neowin.net/forum/topic/1134376-why-wont-my-css-work/
Share on other sites

12 answers to this question

Recommended Posts

  • 0
Grand Master

Nashy

Posted
  • Author
Posted

what are you trying to do and which part isn't working?

I want to change the font in each table row.

well your css file looks fine. just make sure it is named "css.css" and is located in the root of your web dir.

It is. The notes section towards the bottom works, but nothing else.

  • 0
Grand Master

The_Decryptor Veteran

Posted
  • Veteran
Posted

This isn't related to your CSS, but your code has an SQL injection vulnerability (You're directly including part of the query string into an SQL query with no validation), use PDO+prepared statements instead of the mysql_* APIs and you won't have that issue (It'll be faster too)

  • hckngrtfakt, Jose_49, threetonesun and 1 other
  • Like 4
  • 0
Grand Master

Nashy

Posted
  • Author
Posted

You are missing a closing bracket for #login_title.

Thanks so much. You have no idea how much I have stared at this CSS for.

Also, note that at the last code, it says centre and not center with ER at the end.

There are many similar properties. You can group them together with a comma.

I didn't realise that could be done, I appreciate it.

This isn't related to your CSS, but your code has an SQL injection vulnerability (You're directly including part of the query string into an SQL query with no validation), use PDO+prepared statements instead of the mysql_* APIs and you won't have that issue (It'll be faster too)

Thanks a lot, I have no idea what PDO and prepared statements is, but I will pass it on to the person who made it for me. Thanks for pointing it out.

  • 0
Grand Master

threetonesun

Posted
Posted

Try to put them into quote marks, so instead of Calibri, write "Calibri" and etc.

No need. This:


font-family: Calibri, Candara, Segoe, "Segoe UI", Optima, Arial, sans-serif;
[/CODE]

Will work perfectly fine. Quotes are only needed for white space or hypens, or if you were trying to use a font called "sans-serif" instead of the generic sans-serif.

OP, are you sure it's not paying attention to any fonts? Based on the original code, you've declared them all about a dozen times.

  • Guth and Jose_49
  • Like 2
This topic is now closed to further replies.
 Share
Go to question listing

  • Recently Browsing   0 members

    • No registered users viewing this page.

  • Posts

  • Recent Achievements

    • Reacting Well
      BizSAR earned a badge
      Reacting Well
    • First Post
      AndreaB earned a badge
      First Post
    • Week One Done
      Huge Trailer earned a badge
      Week One Done
    • Week One Done
      Classifyskilleducation earned a badge
      Week One Done
    • One Month Later
      eurospharma62 earned a badge
      One Month Later

  • Popular Contributors

    1. 1
      +primortal
      579
    2. 2
      +Edouard
      184
    3. 3
      PsYcHoKiLLa
      75
    4. 4
      Michael Scrip
      73
    5. 5
      neufuse
      64
    Show More

  • Tell a friend

    Love Neowin? Tell a friend!