31 replies to this topic

[Haggis]

Ok i made a news system

Mainly because i wanted to see if i could do it

Ignore the actual site layout it was just thrown together so i could work on it as if it was part of a site

Is there anything you would add?
Anything you would change?
anything you would remove?

http://www.haggistech.co.uk/news

[LUTZIFER]

Sweet! Looks awesome so far. Good work!!

[Haggis]

Thanks

Been working on it for a wee while now just in between work etc

the main page i feel is about finished maybe some small tweaks

Totally lost on admin page though

[+Lingwo]

If you're not sure what to do for the admin page.
Look at bootstrap
http://twitter.github.com/bootstrap/
You can whip up a decent looking administration backend pretty quickly.

As for functionality, you will want to include things like comment moderation, News CRUD. A user CRUD also.

[Uplift]

Very good work, it's nice, clean and does it's job - just a couple of things:

- index.php?page=comments&id=54 - you should definitely use a slug: /facebook-hosting-windows-8-hackathon, page=comments is not a good representation
- also show news title in the page <title></title>, it still says Home even when it's not on 'home'
-

Posted by: Haggis @ November 30, 2012

.. you can't post something at @ a date.

[Haggis]

Very good work, it's nice, clean and does it's job - just a couple of things:

- index.php?page=comments&id=54 - you should definitely use a slug: /facebook-hosting-windows-8-hackathon, page=comments is not a good representation
- also show news title in the page <title></title>, it still says Home even when it's not on 'home'
-

Posted by: Haggis @ November 30, 2012

.. you can't post something at @ a date.

Why is it not good to use ?page=comments for example?

I will fix the @ to on lol

and yeah the | home i will fix too

thanks

[WildWayz]

Isn't it SEO indexing? You'll get more hits from search engines if the title is in the link...

[Uplift]

Why is it not good to use ?page=comments for example?

I will fix the @ to on lol

and yeah the | home i will fix too

thanks

Just my personal take on it: it's not really a comments page, it's a news page with comment functionality... Using something like the page/news title as the url is much more relevant.

And as above.. SEO purposes.

[ACTIONpack]

It works but needs a lot of css styling. It's looks like a shell only.

[kyosuken]

You forgot to validate the ID

http://www.haggistec...nts&id=mouhhaha

will give a mysql error...

Good job for a first try !

[Haggis]

It works but needs a lot of css styling. It's looks like a shell only.

Did you read the first post?

in particular thisbit

Ignore the actual site layout it was just thrown together so i could work on it as if it was part of a site

You forgot to validate the ID

http://www.haggistec...nts&id=mouhhaha

will give a mysql error...

Good job for a first try !

Thank you, i will fix that

[Trollercoaster]

What check are you doing on the ID to ensure it's legit?

[Haggis]

Its been so long since i did that bit of code i will ahve to check lol

[Haggis]

i am escaping the string and should now not work like that

this should work now

http://www.haggistec...ents&id=muhahah

[Uplift]

yeah i tried to hijack it using the id and every attempt failed.