• 0

[vb.net] count number of lines in a textfile


Question

  Visual Basic .NET said:
Dim line(1000), txt As String

Dim x As Integer = 0

Dim file As System.IO.StreamReader

file = New System.IO.StreamReader(OpenFileDialog1.FileName)

Do

? ? txt = file.ReadLine()

? ? line(x) = txt

? ? x += 1

Loop Until txt Is Nothing

currently i'm using this to read a text file and put each line of text in an array of strings (i need to parse the strings later). this works great, but i have to declare line() with an index, or redim it later with an index of the number of lines the file contains. this code works for files up to 1001 lines long (arrays start at 0) but files larger than that cause an error. my problem lies in that i can't find the number of lines without doing something like this first:

  Visual Basic .NET said:
Do

? ? txt = file.ReadLine()

? ? x += 1

Loop Until txt Is Nothing

ReDim line(x)

x = 0 'set x to zero for start of next loop

this would work, but i would be reading the file twice, which takes time. sure, most text files aren't so big that you would notice a pause, but i want to do:pt right :p how would i get the number of lines in a text file? searching on MSDN doesn't bring up much about this with the streamreader class, so i don't know what to do...

7 answers to this question

Recommended Posts

  • 0

You don't need to load the whole file all at once into memory.

Just check for number of VbCr (ascii 13) charaters in the text file.

This will give you the number of lines in the file.

If the last character of the file is not VbCr or VbLf (ascii 10) then add 1 to the total count.

  • 0
  gameguy said:
noll: i'll look into arraylists, i haven't heard of those...

Yes, check out all the Collections classes. I can't remember the last time I used a normal array for much of anything. I was fortunate enough to have a professor for Java who taught us these and made us rewrite many parts of the Java Collections Framework (which mostly works the same in .NET) so I've used them extensively knowing how they work.

  • 0

i need it line by line, otherwise i'd do that.

using this code, i get an error saying "index was out of range. must be non-negative number and less than the size of the collection."

  Quote
Dim line As New ArrayList()

Dim txt As String

Dim x As Integer = 0

Dim file As System.IO.StreamReader

file = New System.IO.StreamReader(OpenFileDialog1.FileName)

Do

? ? txt = file.ReadLine()

? ? line(x) = txt 'code crashes on this line

? ? x += 1

Loop Until txt Is Nothing

:blink:blink: the index IS a non-negative number less than the size of the collection (default capacity for an ArrayList is 16, right?) x is zero, which satisfies both conditions, so what's the pro:huh: :huh: it's happening the first time it loops, when x is zero. and it should grow when it needs to anyway, r:unsure:nsure:

  • 0

nevermind, i fixed it. i had to use line.Insert(x, txt) instead of treating it as an array.

fixed code:

  Quote
Do

? ? txt = file.ReadLine()

? ? line.Insert(x, txt) 'Insert(index As Integer, value As Object)

? ? x += 1

Loop Until txt Is Nothing

Edited by gameguy
This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Sure, that must be why it was revealed at the Sony showcase... the game was announced 5 years ago and the visuals are far from poor, what the hell are you smoking, plus the Switch 2 is pretty much on par with an Xbox Series S. It would be absolutely stupid for a dev to build a game "with the Switch 2 in mind" when it's coming to all platforms were the majority of sales will happen.
    • The Irony... China wouldn't be what it is today without Apple 😂
    • Microsoft makes it easier to find PC specs in Windows 11 Settings by Taras Buria Windows 11 has already received several improvements that make it easier to learn about your computer's specifications. Recently, Microsoft released Spec Cards for the System > About section, which provide basic information about the PC's main components, such as processor, memory, storage, graphics card, and video memory. Now, the Settings app is getting a new way to find your device info. Microsoft wants to display basic device information right on the Home page of the Settings app. The latest preview builds from the Dev and Beta Channels introduced a new "Your device info" card for the Settings' Home page. It displays specs like processor name and speed, graphics card and the amount of video memory, storage, and RAM. The card also has a link to the "About" section, where you will find more information about your computer, its Windows edition, product ID, and the recently introduced FAQ section that answers common hardware-related questions. The "Your device info" card joins the existing cards on the Settings app's home page. While the section offers useful information like quick access to Bluetooth devices, Wi-Fi, personalization, and recommended settings, users received it with mixed reactions, as many considered it another way for Microsoft to promote its services and subscriptions like Microsoft 365, OneDrive, and Game Pass (seriously, who thinks about Game Pass when opening Settings?). Now, the Settings' Home page is a bit more useful, as it saves you a few clicks when checking your computer's specs. If you want to test the new "Your device info" card, update your PC to build 26200.5622 or newer (Dev Channel). Just keep in mind that Microsoft is rolling it out gradually, and it requires signing in with a Microsoft Account in the United States. Other changes in build 26200.5622 include a new Settings section for Quick Machine Recovery, widget improvements, more app recommendations in the "Open with" dialog, and more. Check out the full release notes here.
    • Ponies will finally have good games to play after replaying Last of Us for the 100th time. Oh and I lied, Silent Hill f looks pretty great too, but we already knew about that.
  • Recent Achievements

    • Week One Done
      jbatch earned a badge
      Week One Done
    • First Post
      Yianis earned a badge
      First Post
    • Rookie
      GTRoberts went up a rank
      Rookie
    • First Post
      James courage Tabla earned a badge
      First Post
    • Reacting Well
      James courage Tabla earned a badge
      Reacting Well
  • Popular Contributors

    1. 1
      +primortal
      397
    2. 2
      +FloatingFatMan
      177
    3. 3
      snowy owl
      170
    4. 4
      ATLien_0
      167
    5. 5
      Xenon
      134
  • Tell a friend

    Love Neowin? Tell a friend!