• 0

[vb.net] count number of lines in a textfile


Question

  Visual Basic .NET said:
Dim line(1000), txt As String

Dim x As Integer = 0

Dim file As System.IO.StreamReader

file = New System.IO.StreamReader(OpenFileDialog1.FileName)

Do

? ? txt = file.ReadLine()

? ? line(x) = txt

? ? x += 1

Loop Until txt Is Nothing

currently i'm using this to read a text file and put each line of text in an array of strings (i need to parse the strings later). this works great, but i have to declare line() with an index, or redim it later with an index of the number of lines the file contains. this code works for files up to 1001 lines long (arrays start at 0) but files larger than that cause an error. my problem lies in that i can't find the number of lines without doing something like this first:

  Visual Basic .NET said:
Do

? ? txt = file.ReadLine()

? ? x += 1

Loop Until txt Is Nothing

ReDim line(x)

x = 0 'set x to zero for start of next loop

this would work, but i would be reading the file twice, which takes time. sure, most text files aren't so big that you would notice a pause, but i want to do:pt right :p how would i get the number of lines in a text file? searching on MSDN doesn't bring up much about this with the streamreader class, so i don't know what to do...

7 answers to this question

Recommended Posts

  • 0

You don't need to load the whole file all at once into memory.

Just check for number of VbCr (ascii 13) charaters in the text file.

This will give you the number of lines in the file.

If the last character of the file is not VbCr or VbLf (ascii 10) then add 1 to the total count.

  • 0
  gameguy said:
noll: i'll look into arraylists, i haven't heard of those...

Yes, check out all the Collections classes. I can't remember the last time I used a normal array for much of anything. I was fortunate enough to have a professor for Java who taught us these and made us rewrite many parts of the Java Collections Framework (which mostly works the same in .NET) so I've used them extensively knowing how they work.

  • 0

i need it line by line, otherwise i'd do that.

using this code, i get an error saying "index was out of range. must be non-negative number and less than the size of the collection."

  Quote
Dim line As New ArrayList()

Dim txt As String

Dim x As Integer = 0

Dim file As System.IO.StreamReader

file = New System.IO.StreamReader(OpenFileDialog1.FileName)

Do

? ? txt = file.ReadLine()

? ? line(x) = txt 'code crashes on this line

? ? x += 1

Loop Until txt Is Nothing

:blink:blink: the index IS a non-negative number less than the size of the collection (default capacity for an ArrayList is 16, right?) x is zero, which satisfies both conditions, so what's the pro:huh: :huh: it's happening the first time it loops, when x is zero. and it should grow when it needs to anyway, r:unsure:nsure:

  • 0

nevermind, i fixed it. i had to use line.Insert(x, txt) instead of treating it as an array.

fixed code:

  Quote
Do

? ? txt = file.ReadLine()

? ? line.Insert(x, txt) 'Insert(index As Integer, value As Object)

? ? x += 1

Loop Until txt Is Nothing

Edited by gameguy
This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Microsoft 365 will soon disable outdated authentication protocols for file access by Usama Jawad On a fairly regular basis, Microsoft disables outdated protocols that are used to access its services. In the past few years, the company has deprecated Basic Auth in Exchange Online and cut access to Outlook for third-party apps relying on this protocol. Now, it has decided to get rid of old authentication protocols for file access across Microsoft 365 services. As reported by Bleeping Computer, Microsoft has posted a message on its Microsoft 365 Admin Center. Starting from mid-July 2025, the company will begin disabling legacy authentication protocols used to access files across Microsoft 365 and Office apps, SharePoint, and OneDrive. Essentially, applications or services which use the Relying Party Suite (RPS) or FrontPage Remote Procedure Call (FPRPC) will to perform browser-based authentication to perform open operations on Office files will no longer be able to do so. As expected, this is primarily being done to improve the cybersecurity posture of various services. Microsoft states that RPS can be brute-forced and phished with relative ease as it is fairly outdated. Similarly, FPRPC is typically used for remote web page authoring and it is susceptible to exploitation through various vulnerabilities too. As such, both of these protocols will be disabled by default starting from mid-July 2025, with the rollout of this change targeting completion by August 2025. The Redmond tech giant will update the protocol baseline by default without mandating any licensing changes for customers. In addition, once these modifications are rolled out, Microsoft 365 will require admin consent to get third-party access to files and sites. IT admins can view the guidance available here to configure admin consent workflows. Microsoft says that these changes align with the principles of its Secure Future Initiative (SFI). Earlier today, it announced the rollout of improved security defaults for Windows 365 citing the same reasons too.
    • It does and it can... I took an i3 board and upgraded it to my FX8350... no issues, just put in new drivers over the top that Windows didn't. Not the issue for me, (though I eventually did do a new install from 23H2 to 24H2)... I was on 22H2 at the time. The issue is activation. You may get hit with having to activate again.
  • Recent Achievements

    • First Post
      TIGOSS earned a badge
      First Post
    • Week One Done
      slackerzz earned a badge
      Week One Done
    • Week One Done
      vivetool earned a badge
      Week One Done
    • Reacting Well
      pnajbar earned a badge
      Reacting Well
    • Week One Done
      TBithoney earned a badge
      Week One Done
  • Popular Contributors

    1. 1
      +primortal
      707
    2. 2
      ATLien_0
      283
    3. 3
      Michael Scrip
      218
    4. 4
      +FloatingFatMan
      197
    5. 5
      Steven P.
      130
  • Tell a friend

    Love Neowin? Tell a friend!