My News system

[Haggis Veteran]

Ok i made a news system

Mainly because i wanted to see if i could do it

Ignore the actual site layout it was just thrown together so i could work on it as if it was part of a site

Is there anything you would add?

Anything you would change?

anything you would remove?

http://www.haggistech.co.uk/news

[LUTZIFER]

Sweet! Looks awesome so far. Good work!!

[Haggis Veteran]

Thanks

Been working on it for a wee while now just in between work etc

the main page i feel is about finished maybe some small tweaks

Totally lost on admin page though

[Lingwo]

If you're not sure what to do for the admin page.

Look at bootstrap

http://twitter.github.com/bootstrap/

You can whip up a decent looking administration backend pretty quickly.

As for functionality, you will want to include things like comment moderation, News CRUD. A user CRUD also.

[game_over]

Very good work, it's nice, clean and does it's job - just a couple of things:

- index.php?page=comments&id=54 - you should definitely use a slug: /facebook-hosting-windows-8-hackathon, page=comments is not a good representation

- also show news title in the page <title></title>, it still says Home even when it's not on 'home'

-

Posted by: Haggis @ November 30, 2012

.. you can't post something at @ a date.

[Haggis Veteran]

Very good work, it's nice, clean and does it's job - just a couple of things:

- index.php?page=comments&id=54 - you should definitely use a slug: /facebook-hosting-windows-8-hackathon, page=comments is not a good representation

- also show news title in the page <title></title>, it still says Home even when it's not on 'home'

-

Posted by: Haggis @ November 30, 2012

.. you can't post something at @ a date.

Why is it not good to use ?page=comments for example?

I will fix the @ to on lol

and yeah the | home i will fix too

thanks :)

[WildWayz]

Isn't it SEO indexing? You'll get more hits from search engines if the title is in the link...

[game_over]

Why is it not good to use ?page=comments for example?

I will fix the @ to on lol

and yeah the | home i will fix too

thanks :)

Just my personal take on it: it's not really a comments page, it's a news page with comment functionality... Using something like the page/news title as the url is much more relevant.

And as above.. SEO purposes.

[ACTIONpack]

It works but needs a lot of css styling. It's looks like a shell only.

[kyosuken]

You forgot to validate the ID

http://www.haggistech.co.uk/news/index.php?page=comments&id=mouhhaha

will give a mysql error...

Good job for a first try :) !

[Haggis Veteran]

It works but needs a lot of css styling. It's looks like a shell only.

Did you read the first post?

in particular thisbit

Ignore the actual site layout it was just thrown together so i could work on it as if it was part of a site

You forgot to validate the ID

http://www.haggistec...nts&id=mouhhaha

will give a mysql error...

Good job for a first try :) !

Thank you, i will fix that :)

[Sandor]

What check are you doing on the ID to ensure it's legit?

[Haggis Veteran]

Its been so long since i did that bit of code i will ahve to check lol

[Haggis Veteran]

i am escaping the string and should now not work like that

this should work now

http://www.haggistech.co.uk/news/index.php?page=comments&id=muhahah

[game_over]

yeah i tried to hijack it using the id and every attempt failed.

[Haggis Veteran]

Awesome :)

[Sandor]

i am escaping the string and should now not work like that

this should work now

http://www.haggistec...ents&id=muhahah

escaping...assuming you're using mysqli_real_escape_string then?

Not necessarily secure from what I've read.

Thoughts on:

$id = preg_match("/^[0-9]+$/", $_GET['id']);
[/CODE]

Doing anything on the page= btw?

[Haggis Veteran]

yeah looking at the page= thing but not got a lot of time right now

so getting rid of the small problems first :)

[Sandor]

is the page used in the query? if not, no need to worry. only need to worry about things directly used in the query really.

[Haggis Veteran]

nah page is not used in the query only the id

I thought you meant the SEO stuff lol

[Sandor]

These days it's a bit of a myth about the address affecting SEO. Always a good idea to include the title though simply because people search for words.

/news/index.php?page=comments&id=54 isn't brilliant.

/news/index.php?page=comments&title=facebook-hosting-windows-8-hackathon is better (and Google can understand query strings)

My own personal blog that I'm creating uses entry.php?entry=title-of-post&category=category-of-post

[Haggis Veteran]

hmmm never thought about that :) i will have a look

[game_over]

http://www.generateit.net/mod-rewrite/

use it, and get rid of unnecessary-page-name.php?=

[Haggis Veteran]

little interim fix

http://www.haggistech.co.uk/news/index.php?page=comments&title=Facebook-hosting-Windows-8-hackathon

[Haggis Veteran]

ok got the mod_rewrite stuff working

does this look better now?

http://haggistech.co.uk/news/

[guitmz]

haha nice work mate!!