• 0

My News system


Question

Ok i made a news system

Mainly because i wanted to see if i could do it

Ignore the actual site layout it was just thrown together so i could work on it as if it was part of a site

Is there anything you would add?

Anything you would change?

anything you would remove?

http://www.haggistech.co.uk/news

Link to comment
Share on other sites

Recommended Posts

  • 0

Thanks

Been working on it for a wee while now just in between work etc

the main page i feel is about finished maybe some small tweaks

Totally lost on admin page though

Link to comment
Share on other sites

  • 0

Very good work, it's nice, clean and does it's job - just a couple of things:

- index.php?page=comments&id=54 - you should definitely use a slug: /facebook-hosting-windows-8-hackathon, page=comments is not a good representation

- also show news title in the page <title></title>, it still says Home even when it's not on 'home'

-

Posted by: Haggis @ November 30, 2012

.. you can't post something at @ a date.

Link to comment
Share on other sites

  • 0

Very good work, it's nice, clean and does it's job - just a couple of things:

- index.php?page=comments&id=54 - you should definitely use a slug: /facebook-hosting-windows-8-hackathon, page=comments is not a good representation

- also show news title in the page <title></title>, it still says Home even when it's not on 'home'

-

Posted by: Haggis @ November 30, 2012

.. you can't post something at @ a date.

Why is it not good to use ?page=comments for example?

I will fix the @ to on lol

and yeah the | home i will fix too

thanks :)

Link to comment
Share on other sites

  • 0

Isn't it SEO indexing? You'll get more hits from search engines if the title is in the link...

Link to comment
Share on other sites

  • 0

Why is it not good to use ?page=comments for example?

I will fix the @ to on lol

and yeah the | home i will fix too

thanks :)

Just my personal take on it: it's not really a comments page, it's a news page with comment functionality... Using something like the page/news title as the url is much more relevant.

And as above.. SEO purposes.

Link to comment
Share on other sites

  • 0

It works but needs a lot of css styling. It's looks like a shell only.

Link to comment
Share on other sites

  • 0

It works but needs a lot of css styling. It's looks like a shell only.

Did you read the first post?

in particular thisbit

Ignore the actual site layout it was just thrown together so i could work on it as if it was part of a site

You forgot to validate the ID

http://www.haggistec...nts&id=mouhhaha

will give a mysql error...

Good job for a first try :) !

Thank you, i will fix that :)

Link to comment
Share on other sites

  • 0

Its been so long since i did that bit of code i will ahve to check lol

Link to comment
Share on other sites

  • 0

yeah looking at the page= thing but not got a lot of time right now

so getting rid of the small problems first :)

Link to comment
Share on other sites

  • 0

nah page is not used in the query only the id

I thought you meant the SEO stuff lol

Link to comment
Share on other sites

  • 0

These days it's a bit of a myth about the address affecting SEO. Always a good idea to include the title though simply because people search for words.

/news/index.php?page=comments&id=54 isn't brilliant.

/news/index.php?page=comments&title=facebook-hosting-windows-8-hackathon is better (and Google can understand query strings)

My own personal blog that I'm creating uses entry.php?entry=title-of-post&category=category-of-post

Link to comment
Share on other sites

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.