Visual Basic - Guessing game (1 - 100)

[atyemail]

Public Class Form1

    

    Dim aRandNumGen As New Random

    Dim answer As Integer = aRandNumGen.Next(1, 101)

    Private Sub Timer1_Tick(sender As Object, e As EventArgs) Handles Timer1.Tick

        lblTime1.Text = "Time: " + TimeString

        lblTime2.Text = "Date: " + DateString

        GroupBox1.Hide()

    End Sub

 

    Private Sub btnGuess_Click(sender As Object, e As EventArgs) Handles btnGuess.Click

        If Not IsNumeric(TextBox1.Text) Then

            MessageBox.Show("Numeric")

        End If

        Dim guess As Integer

        guess = CInt(TextBox1.Text)

        If answer = guess Then

            GroupBox1.Show()

        End If

 

        If answer = guess Then

            Label2.Text = "Congartulations"

        ElseIf answer < guess Then

            Label2.Text = "Too High"

        ElseIf answer < guess - 5 Then

            Label2.Text = "A little too low"

        ElseIf answer > guess Then

            Label2.Text = "Too Low"

        ElseIf answer > guess + 5 Then

            Label2.Text = "A little too high"

        End If

        TextBox1.Focus()

        TextBox1.SelectionStart = 0

        TextBox1.SelectionLength =

            TextBox1.TextLength

    End Sub

    

    

End Class

 

So i need to make a guessing game and i can run it and get random number with good instruction but i am missing some codes like as you see that i want to make like if the randomnumber is near to the answer like + 5 it will said little too high and if rnadom number - 5 then it will said little too low but i can't seem to work it out and also that i am trying to make it so that the textbox1 can only be enter as numeric but whenever i put word it will make the program crash.

And i also have a groupbox saying Do you want to play again? with 2 rad buttons yes and no and a button OK

so i want to make it so that when the user enter the correct random number the groupbox will be visible but not at start

[+theblazingangel MVC]

Your logic in your if-elseif-else block is flawed, you need to re-think it! Also you've got a typo on "congratulations" ;)

[Andre S. Veteran]

Your crash is due to the fact that you still execute the CInt() cast even if the text is not numeric. Just read your code carefully, that's what it does. Don't do that.

 

Also you hide the groupbox on every tick of the timer, which means even if you show it when the user wins, it'll disappear as soon as the timer event happens again. You could hide it in the OnLoaded event and enable it when the user has guessed properly.

[limok]

Try using case statements

[Andre S. Veteran]

  On 11/08/2013 at 03:35, limok said:

Try using case statements

That is of no help whatsoever...

[atyemail]

Hey Asik

can you give me a hint about the crashing even without isnumeric i tried to remove it and yes it crash still but than if i remove the cint it won work because of option strict on and option explicit on so what you recommend me to do?

And for the groupbox i have fixed it to show up 

[atyemail]

Option Strict On

Option Explicit On

 

Public Class Form1

    

    Dim aRandNumGen As New Random

    Dim answer As Integer = aRandNumGen.Next(1, 101)

    Private Sub Timer1_Tick(sender As Object, e As EventArgs) Handles Timer1.Tick

        lblTime1.Text = "Time: " + TimeString

        lblTime2.Text = "Date: " + DateString

    End Sub

 

    Private Sub btnGuess_Click(sender As Object, e As EventArgs) Handles btnGuess.Click

        If Not IsNumeric(TextBox1.Text) Then

            MessageBox.Show("Numeric")

        End If

        If CDbl(TextBox1.Text) > 100 Then

            MessageBox.Show("Number be between 1 - 100")

        End If

        If CDbl(TextBox1.Text) < 1 Then

            MessageBox.Show("Number be between 1 - 100")

        End If

        Dim guess As Integer = CInt(TextBox1.Text)

 

        If answer = guess Then

            GroupBox1.Show()

        End If

 

        If answer = guess Then

            Label2.Text = "Congratulations"

        ElseIf answer < guess Then

            Label2.Text = "Too High"

        ElseIf answer - 5 < guess Then

            Label2.Text = "A little too low"

        End If

        If answer > guess Then

            Label2.Text = "Too Low"

        ElseIf answer + 5 > guess Then

            Label2.Text = "A little too high"

        End If

        TextBox1.Focus()

        TextBox1.SelectionStart = 0

        TextBox1.SelectionLength =

            TextBox1.TextLength

    End Sub

    

    Private Sub Button1_Click(sender As Object, e As EventArgs) Handles Button1.Click

        If RadYes.Checked Then

            Reset()

        End If

        If RadNo.Checked Then

            End

        End If

    End Sub

 

    Private Sub btnExit_Click(sender As Object, e As EventArgs) Handles btnExit.Click

        End

    End Sub

 

    Private Sub btnClear_Click(sender As Object, e As EventArgs) Handles btnClear.Click

        TextBox1.Clear()

    End Sub

End Class

 

Okay so this is my newly improve code and i have groupbox showing after the person guess correctly and now i just need to make that if the user enter not numeric it should pop up a message box "Numeric Only" but mine kept on crashing what do i need to fix?

And also i already make that if the user enter number correctly than groupbox show yes/no and a button if no then program will exit but if yes i want to reset it but what's the code?

[Coi]

  On 11/08/2013 at 04:30, atyemail said:

 

 

        If Not IsNumeric(TextBox1.Text) Then

            MessageBox.Show("Numeric")

        End If

 

Okay so this is my newly improve code and i have groupbox showing after the person guess correctly and now i just need to make that if the user enter not numeric it should pop up a message box "Numeric Only" but mine kept on crashing what do i need to fix?

 

 

It's because you still run the whole code after showing the message box, try adding "Return" (means, in this case, stop running through the method) after that line:

If Not IsNumeric(TextBox1.Text) Then
    MessageBox.Show("Numeric Only")
    Return
End If

[atyemail]

Thank you very much,

Please help me atm i have problem when the random number is in range random number - 10 = a little too low but the a little too high is not working, any suggestion?

 

Public Class Form1

    

    Dim aRandNumGen As New Random

    Dim answer As Integer = aRandNumGen.Next(1, 101)

    Private Sub Timer1_Tick(sender As Object, e As EventArgs) Handles Timer1.Tick

        lblTime1.Text = "Time: " + TimeString

        lblTime2.Text = "Date: " + DateString

    End Sub

 

    Private Sub btnGuess_Click(sender As Object, e As EventArgs) Handles btnGuess.Click

        If Not IsNumeric(TextBox1.Text) Then

            MessageBox.Show("Numeric")

            Return

        End If

        If CDbl(TextBox1.Text) > 100 Then

            MessageBox.Show("Number be between 1 - 100")

        End If

        If CDbl(TextBox1.Text) < 1 Then

            MessageBox.Show("Number be between 1 - 100")

        End If

        Dim guess As Integer = CInt(TextBox1.Text)

 

        If answer = guess Then

            GroupBox1.Show()

        End If

 

        If answer = guess Then

            Label2.Text = "Congratulations"

        ElseIf answer < guess Then

            Label2.Text = "Too High"

        ElseIf answer - 10 < guess Then

            Label2.Text = "A little too low"

        ElseIf answer > guess Then

            Label2.Text = "Too Low"

        ElseIf answer + 10 > guess Then

            Label2.Text = "A little too high"

        End If

 

        TextBox1.Focus()

        TextBox1.SelectionStart = 0

        TextBox1.SelectionLength =

            TextBox1.TextLength

    End Sub

    

    Private Sub Button1_Click(sender As Object, e As EventArgs) Handles Button1.Click

        If RadYes.Checked Then

            Reset()

        End If

        If RadNo.Checked Then

            End

        End If

    End Sub

 

    Private Sub btnExit_Click(sender As Object, e As EventArgs) Handles btnExit.Click

        End

    End Sub

 

    Private Sub btnClear_Click(sender As Object, e As EventArgs) Handles btnClear.Click

        TextBox1.Clear()

    End Sub

End Class

[Coi]

If answer = guess Then
    Label2.Text = "Congratulations"
ElseIf answer < guess Then
    Label2.Text = "Too High"
ElseIf answer - 10 < guess Then
    Label2.Text = "A little too low"
ElseIf answer > guess Then
    Label2.Text = "Too Low"
ElseIf answer + 10 > guess Then
    Label2.Text = "A little too high"
End If

It's because the logic is flawed. Try to read and follow the logic.

(I also recommend placing 'guess' on the left side for readability)

 

If you can't fix it yourself, this is how I would do it :

.

.

.

.

.

.

.

.

.

.

.

.

.

.

.

.

If guess = answer Then
    Label2.Text = "Congratulations"
ElseIf guess > answer Then
    If guess < answer + 10 Then
        Label2.Text = "A little too high"
    Else
        Label2.Text = "Too High"
    End If
ElseIf guess < answer Then
    If guess > answer - 10 Then
        Label2.Text = "A little too low"
    Else
        Label2.Text = "Too Low"
    End If
End If

[Andre S. Veteran]

  On 11/08/2013 at 03:49, atyemail said:

Hey Asik

can you give me a hint about the crashing even without isnumeric i tried to remove it and yes it crash still but than if i remove the cint it won work because of option strict on and option explicit on so what you recommend me to do?

And for the groupbox i have fixed it to show up 

Your method should look roughly like this (pseudo-code, you figure out how to translate in VB):

If the text in the textbox is not a number Then
     print some error message
Else
     convert text to integer with CInt
     tell user whether the guess is above, below or equal to the answer
End If

Your problem currently is that you attempt to convert to integer even if the text isn't a number.