Array pseudocode

[bs819]

"Design a program that lets the user enter 20 numbers. It should store the numbers in an array and then display the following data: lowest number, highest number, total of numbers, and the average of numbers."

 

I just want to know if this looks correct! It's the first array problem I have done.

 

  Quote

 

Constant Integer SIZE = 20

Declare Real numbers

Declare Integer index

Declare Real num, highest, lowest, total, avg

 

For index = 0 to SIZE ? 1

   Display ?Enter a number?

   Input num

   Set numbers[index] = num

End For

 

Set highest = getHigest(numbers, SIZE)

Display "Higest:", highest

Set lowest = getLowest(numbers, SIZE)

Display "Lowest:", lowest

Set total = getTotal(numbers, SIZE)

Display "Total:", total

Set avg = total / SIZE

Display "Average:", avg

 

Function Real getHighest(Real array[], Integer size)

   Declare Integer index

   Declare Real highest = array[0]

   For index = 1 to size ? 1

      If array[index] > highest Then

         Set highest = array[index]

   End For

   Return highest

End Function

 

Function Real getLowest(Real array[], Integer size)

   Declare Integer index

   Declare Real lowest = array[0]

   For index = 1 to size ? 1

      If array[index] < lowest Then

         Set lowest = array[index]

      End If

   End For

   Return lowest

End Function

 

Function Real getTotal(Real array[], Integer size)

   Declare Real total = 0

   Declare Integer index

   For index = 0 to size ? 1

      Set total = total + array[index]

   End For

   Return total

End Function

 

 

 

[firey]

Looks good to me.

You have Highest, Lowest, Average, Total.

You have the cap of 20, and it uses an array.   You seem to loop through correctly.   One thing you could do is the fact you constant SIZE and the Array[] is declared as a member variable.. you don't need to pass them into the functions.  If the point is to make it dynamic so ANY could be passed in.. then keep it how it is, otherwise you could do it without extra functions. 

Also, most Arrays have a size anyways instead of needing to pass one in you could just call that (Array.size() or simmilar).

[+Majesticmerc MVC]

Looks good for the mostpart, can't fault your logic. Couple of pointers:

• It's never a good idea to have two variables named the same. See that in your list of global variables (around line 4) you have variables called "index", "highest", "lowest", "total", but then you also have local variables in each function with the same name. In an implementation of your program, it's possible that your logic would fail due to the fact that you'd try to declare the same variable twice.
  • I'd give your globals different names (e.g. highest_result, lowest_result, etc). This would avoid any possible name clashes.
• A foreach syntax might work better for the loops in your functions, rather than using your SIZE constant everywhere.

  • for each number in array
        if number < lowest
            set lowest = number
        end
    end

Other than that I think it looks pretty spot on :)

[bs819]

  On 21/10/2013 at 12:23, Majesticmerc said:

Looks good for the mostpart, can't fault your logic. Couple of pointers:

• It's never a good idea to have two variables named the same. See that in your list of global variables (around line 4) you have variables called "index", "highest", "lowest", "total", but then you also have local variables in each function with the same name. In an implementation of your program, it's possible that your logic would fail due to the fact that you'd try to declare the same variable twice.
  • I'd give your globals different names (e.g. highest_result, lowest_result, etc). This would avoid any possible name clashes.
• A foreach syntax might work better for the loops in your functions, rather than using your SIZE constant everywhere.

  • for each number in array
        if number < lowest
            set lowest = number
        end
    end

Other than that I think it looks pretty spot on :)

 

Thank you for the pointers!  :)

[bs819]

  On 21/10/2013 at 12:16, firey said:

Looks good to me.

You have Highest, Lowest, Average, Total.

You have the cap of 20, and it uses an array.   You seem to loop through correctly.   One thing you could do is the fact you constant SIZE and the Array[] is declared as a member variable.. you don't need to pass them into the functions.  If the point is to make it dynamic so ANY could be passed in.. then keep it how it is, otherwise you could do it without extra functions. 

Also, most Arrays have a size anyways instead of needing to pass one in you could just call that (Array.size() or simmilar).

Thank you for the help!