• 0

Python, Keyboard Interrupt, and Windows


Question

So I'm writing my own launcher for youtube-dl just for my own personal use, and to familiarize myself with Python a little bit more.  When I run it in Linux, it works normally, and if I cancel a download with CTRL+C, the "Interrupted by User" error message appears.  If I run it in Windows, it works normally, except the "Interrupted by User" error message does not appear when I cancel a download with CTRL+C.  The other error messages such as the "Invalid URL" one works, so I know it's making down into the "elif download is not 0:" portion, but that one error message doesn't appear.

 

It's not the end of the world, and I'm suspecting this has something to do with the way Windows, or the Windows version of youtube-dl, handles the CTRL+C keyboard interrupt.  Here's the block of code that launches the download and then displays messages according to the outcome.

 

Code Snippet

 

If you have issues opening the link let me know and I'll re-do it, but Neowin's code bracket didn't recognize any of the indentions, and it looked a bit confusing, so I thought this would be easier to read.

3 answers to this question

Recommended Posts

  • 0

Even if a keyboard interrupt spit out an error code other than the "2" specified, it should still get caught by the "else" statement that issues the "Unknown error" window, but not even that comes up, it just cancels the download but doesn't tell the user anything.

  • 0

You need to wrap your code in a try..except and catch KeyboardInterrupt
 

try:
    <yourcode>
except KeyboardInterrupt as e:
    print(e)

other tips:

1. I wouldn't use "is" to compare numbers, use "==". The reason this works is that for performance reasons CPython creates objects for the first 256 ints and uses them whenever you have a value in that range.
The only time you tend to use "is" is when you want to check if something is None (by "is None").

2. Also avoid "is" for strings, use "==" instead, it should only work if those strings are interned. See http://stackoverflow.com/questions/2988017/string-comparison-in-python-is-vs for some more information.

3. os.system works, but you should probably replace it with subprocess.call. The subprocess module has more features and is intended to be a replacement for a number of older modules and functions (including os.system).

 

4. Use os.path to manipulate your paths to reduce the chance of errors

  • 0

You probably should just setup a signal handler for your main process: http://docs.python.org/2/library/signal.html, use subprocess.popen().wait(), and then manually terminate the process if SIGINT is sent. The reason being is that this will make termination handling consistent across platforms.

 

If you go with the exception solution you may or may not need to terminate the subprocess manually in Windows. Another thing to note is that there are subtle differences in interrupt behavior between os.system() and subprocess.call(): http://stackoverflow.com/questions/18739821/keyboard-interrupts-and-os-system-vs-subprocess-call that can affect you depending on what you are doing.

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • About that Trump's mobile 🤣🤣🤣  
    • AliExpress faces EU crackdown, makes promises to fight illegal products by Paul Hill The European Commission has taken two significant actions against the Chinese online marketplace AliExpress under the Digital Services Act (DSA) in a bid to enhance user and consumer safety online. The first action was to get AliExpress to commit to several legally binding commitments to address issues related to advertising and recommender systems. The second action was the publication of preliminary findings which found that AliExpress had breached obligations regarding the spread of illegal products. AliExpress can now respond to the Commission but if the broken rules are confirmed then AliExpress can expect to be fined. The Digital Services Act is a new tool that the EU has to regulate large online platforms. It aims to level the business playing field, protect fundamental rights of users, create a safer digital space, and improve transparency from businesses. AliExpress's pledges: More transparency, safer shopping As part of the pledges made by AliExpress, it will do more to monitor and detect illegal products such as medicines, food supplements, and adult material propagated through hidden links and affiliate programs. To help flag illegal items, AliExpress has promised to improve its notice and action mechanism. Other pledges include enhancements to the internal complaint handling system; more transparency for advertising and recommender systems; better traceability of traders on the platform; and improved data access for researchers. By implementing these rules, the European Commission hopes it can make AliExpress safer for registered and non-registered users by limiting the exposure to illegal content. Deep dive into AliExpress's alleged failures With regards to the preliminary findings, the Commission found that AliExpress had underestimated the risks because it had not allocated enough resources to moderation systems for illegal products. It also found that the company had failed to consistently enforce its penalty policy against those publishing illegal content. The Commission also discovered systemic failures in AliExpress’s proactive content moderation systems that allowed malicious traders to continue to operate or start operating on the platform. AliExpress is designated as a Very Large Online Platform (VLOP) which means it has to meet certain standards set out by the EU. The aforementioned violations are against the quality of operation that the EU expects from VLOPs. The company now has the right to defend itself against the EC’s findings, it can examine the documents and reply in writing, but if the findings are confirmed, AliExpress could face fines and be required to submit an action plan.
    • Author/Neowin... The title is incorrect and misleading... By the official blog post, it's not "indefinitely". There's a clear statement that development continues with a few specific target areas, and a new release date TBD and announced later. If it is later announced to be cancelled or delayed indefinitely, that's another story.
    • I hate Microsoft. My parents almost lost all drive content. As senior citizens they are unable to follow constant "improvements" Microsoft is dropping on its users. My mother's laptop is normally unlocked with a PIN. It is unexplicable for non-It person, that there is some cloud mictosoft account, that has a different password than the Pin and user ID is e-mail, but not necessarily normal Gmail addree, and even if the person knows this email address the password is not the password used for this email account. Just too much of twists. Suddenly her laptop ordered entering "decryption key" before booting. It was miracle we managed to guess email address associated with the PC that was used for Microsoft account. She would had lost everything on the drive. Why are they doing this? Privacy may be important for some people, but data loss is much more important for most of the people.
  • Recent Achievements

    • First Post
      xuxlix earned a badge
      First Post
    • First Post
      Tomek Święcicki earned a badge
      First Post
    • One Year In
      carlitin86 earned a badge
      One Year In
    • Reacting Well
      Peterlll06 earned a badge
      Reacting Well
    • Week One Done
      Peterlll06 earned a badge
      Week One Done
  • Popular Contributors

    1. 1
      +primortal
      674
    2. 2
      ATLien_0
      283
    3. 3
      Michael Scrip
      226
    4. 4
      +FloatingFatMan
      192
    5. 5
      Steven P.
      145
  • Tell a friend

    Love Neowin? Tell a friend!