• 0

[c#] searching for a hex string in a file?


Question

I have a program im working on to extract pngs (and later on more files) ...but currently i am using BinaryReader, and i read it byte-by-byte to check for png header/footer. For most files (even those over just a few hundred kb) it takes a little bit.

is there any way to just search in the file for what im looking for, or any ideas on a faster way to do this?

it does *work* the way i am doing it...its just slow :)

Thanks

Doug

3 answers to this question

Recommended Posts

  • 0

im thinking you're still going to have to do a sequential search and if the files are large and the part you're searching for is far enough in the file, that's going to take a while. that is if im understanding you correctly with what you are trying to do.

(edit) is the method you're using to read the data in reading in large chunks from the file.. or is it reading a byte then comparing it and then reading the next byte. if it's the latter, that could be causing your slow down.

  • 0
  nvme said:

im thinking you're still going to have to do a sequential search and if the files are large and the part you're searching for is far enough in the file, that's going to take a while. that is if im understanding you correctly with what you are trying to do.

(edit) is the method you're using to read the data in reading in large chunks from the file.. or is it reading a byte then comparing it and then reading the next byte. if it's the latter, that could be causing your slow down.

well ive tried two ways, reading a byte at a time, and reading 100 bytes, then using string comparisons with that chunk...

i have a string var with the hex im looking for

as i go, i have a pos var

if the byte looked at is = the first two in the hex string, it increments, and it resets to 0 if the byte is different than expected...then it just stores each byte once it finds the header until the footer, then it writes that file, then clears the previous stuff

  • 0

ok this is old, i made this about 2 years ago and i think there are better ways to do this. The code gets an jpeg image (album art) in an mp3 file, it works but as you can see the hex values i was looking for are 41h,50h,49h,43h ( APIC ). I used filestream not binaryreader. You can give it a try and fix it up to work with your code. Just change the conditions in the "data == 0x41 %% ........" to what your looking for. There may be a better way but i was still learning back then (C# and mp3 ID tag stuff) and i havent changed anything since.

returns true if there is data and "out Img" get the Image, false if no image data and "out Img" get null.

public bool GetImageFromMp3( string Mp3_File_Path, out Image Img )
		{			  
			int imgPos = 0;
			int imgEnd = 0;
			int imgLenght = 0;
			FileStream fs = new FileStream( Mp3_File_Path, FileMode.Open );
			byte [] data = new byte [ fs.Length ];
			fs.Read( data, 0, (int)fs.Length );
			for (int i = 0; i < data.Length; i++)
			{
				if (data[i]   == 0x41 &&	  //APIC  0x41 0x50 0x49 0x43
					data[i+1] == 0x50 &&
					data[i+2] == 0x49 &&
					data[i+3] == 0x43)
				{
					imgPos = i + 23;
				}
				if (data[i]   == 0xff && data[i+1] == 0xd9)  //end of image
				{
					imgEnd = i+1;
				}
			}
			if ( imgPos == 0 ) // no image data
			{
				Img = null;  
				return false;
			}
			else
			{
				imgLenght = imgEnd - imgPos;
				Img = Image.FromStream( new MemoryStream( data,imgPos,imgLenght ) );
				fs.Close();
				return true;
}

Edited by dolimite35
This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Adobe releases all-new Photoshop app for Android devices by Pradeep Viswanathan Early this year, Adobe released an all-new Photoshop app for iOS devices. Designed from the ground up for smartphones, the app allows users to easily add, remove, adjust, and combine content, as well as access free Adobe Stock assets to create new visuals. Today, Adobe announced a similar, brand-new Photoshop app for Android devices, currently in beta. It’s important to note that this Android version is not intended to replace the desktop version of Photoshop. Instead, it offers access to select powerful Photoshop features—including layering, masking, and the new Generative Fill—within an easy-to-use mobile interface. During the beta phase, the following features are available to all users: Following the beta phase, users will need a new Photoshop Mobile & Web plan to access the premium features. The premium features list includes the ability to remove objects by brushing over them with the Remove Tool, the ability to use Clone Stamp to hide unwanted objects by cloning areas of an image, the ability to fill portions of an image with content sampled from other parts of the image with Content-Aware Fill, the ability to export using additional file formats (PSD, TIF, JPG, PNG), and more. You can download the Adobe Photoshop app from the Google Play Store if your device is running Android 11 or later and has at least 6GB of RAM (8GB or more is recommended for optimal performance).
    • And what about all the toxic waste that "clean" nuclear energy produces?
    • Plasma is beautiful, but my workload is unlikely to ever run on linux ... Cubase 14 with 5 or 6 dozen instances of Kontakt 8. Sigh.
    • Hey everyone! Just curious what your favorite browser is and why? Personally, I prefer using Chrome because it is simple and smooth to use. Would love to hear what everyone else is using and if there's something better I should try!
    • I'm Sam, 20, currently studying IT and passionate about all things tech and music. I found Neowin while browsing for community forums, and I’m excited to be here, connect with others, and maybe even learn something new along the way. Looking forward to chatting with you all!
  • Recent Achievements

    • Conversation Starter
      DarkShrunken earned a badge
      Conversation Starter
    • One Month Later
      jrromero17 earned a badge
      One Month Later
    • Week One Done
      jrromero17 earned a badge
      Week One Done
    • Conversation Starter
      johnwin1 earned a badge
      Conversation Starter
    • One Month Later
      Marwin earned a badge
      One Month Later
  • Popular Contributors

    1. 1
      +primortal
      246
    2. 2
      snowy owl
      156
    3. 3
      ATLien_0
      142
    4. 4
      +FloatingFatMan
      138
    5. 5
      Xenon
      127
  • Tell a friend

    Love Neowin? Tell a friend!