• 0

[c#] searching for a hex string in a file?


Question

I have a program im working on to extract pngs (and later on more files) ...but currently i am using BinaryReader, and i read it byte-by-byte to check for png header/footer. For most files (even those over just a few hundred kb) it takes a little bit.

is there any way to just search in the file for what im looking for, or any ideas on a faster way to do this?

it does *work* the way i am doing it...its just slow :)

Thanks

Doug

3 answers to this question

Recommended Posts

  • 0

im thinking you're still going to have to do a sequential search and if the files are large and the part you're searching for is far enough in the file, that's going to take a while. that is if im understanding you correctly with what you are trying to do.

(edit) is the method you're using to read the data in reading in large chunks from the file.. or is it reading a byte then comparing it and then reading the next byte. if it's the latter, that could be causing your slow down.

  • 0
  nvme said:

im thinking you're still going to have to do a sequential search and if the files are large and the part you're searching for is far enough in the file, that's going to take a while. that is if im understanding you correctly with what you are trying to do.

(edit) is the method you're using to read the data in reading in large chunks from the file.. or is it reading a byte then comparing it and then reading the next byte. if it's the latter, that could be causing your slow down.

well ive tried two ways, reading a byte at a time, and reading 100 bytes, then using string comparisons with that chunk...

i have a string var with the hex im looking for

as i go, i have a pos var

if the byte looked at is = the first two in the hex string, it increments, and it resets to 0 if the byte is different than expected...then it just stores each byte once it finds the header until the footer, then it writes that file, then clears the previous stuff

  • 0

ok this is old, i made this about 2 years ago and i think there are better ways to do this. The code gets an jpeg image (album art) in an mp3 file, it works but as you can see the hex values i was looking for are 41h,50h,49h,43h ( APIC ). I used filestream not binaryreader. You can give it a try and fix it up to work with your code. Just change the conditions in the "data == 0x41 %% ........" to what your looking for. There may be a better way but i was still learning back then (C# and mp3 ID tag stuff) and i havent changed anything since.

returns true if there is data and "out Img" get the Image, false if no image data and "out Img" get null.

public bool GetImageFromMp3( string Mp3_File_Path, out Image Img )
		{			  
			int imgPos = 0;
			int imgEnd = 0;
			int imgLenght = 0;
			FileStream fs = new FileStream( Mp3_File_Path, FileMode.Open );
			byte [] data = new byte [ fs.Length ];
			fs.Read( data, 0, (int)fs.Length );
			for (int i = 0; i < data.Length; i++)
			{
				if (data[i]   == 0x41 &&	  //APIC  0x41 0x50 0x49 0x43
					data[i+1] == 0x50 &&
					data[i+2] == 0x49 &&
					data[i+3] == 0x43)
				{
					imgPos = i + 23;
				}
				if (data[i]   == 0xff && data[i+1] == 0xd9)  //end of image
				{
					imgEnd = i+1;
				}
			}
			if ( imgPos == 0 ) // no image data
			{
				Img = null;  
				return false;
			}
			else
			{
				imgLenght = imgEnd - imgPos;
				Img = Image.FromStream( new MemoryStream( data,imgPos,imgLenght ) );
				fs.Close();
				return true;
}

Edited by dolimite35
This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Doing that has only worked for me with the Enterprise version.
    • I like Neowin a lot, but this "article" is shady and misleading. We need an "editorial" flag and this isn't "news" it's "my cousin's dog's best friend posted on twitter about their snapchat account from their dog's owner that a bad thing happened, so it's NEWS." Thanks
    • Burrrrn. Bought COD WWII last month when it was on sale for PC. Oh well. Excellent game tho, and the PC version plays/looks amazing (and has it's own PC achievements). ...wondering if this is a lesson on waiting on sales. ...also hoping Rise of the Tomb Raider has it's own PC Achievements
    • Google Chrome 137.0.7151.120 (offline installer) by Razvan Serea The web browser is arguably the most important piece of software on your computer. You spend much of your time online inside a browser: when you search, chat, email, shop, bank, read the news, and watch videos online, you often do all this using a browser. Google Chrome is a browser that combines a minimal design with sophisticated technology to make the web faster, safer, and easier. Use one box for everything--type in the address bar and get suggestions for both search and Web pages. Thumbnails of your top sites let you access your favorite pages instantly with lightning speed from any new tab. Desktop shortcuts allow you to launch your favorite Web apps straight from your desktop. Chrome has many useful features built in, including automatic full-page translation and access to thousands of apps, extensions, and themes from the Chrome Web Store. Google Chrome is one of the best solutions for Internet browsing giving you high level of security, speed and great features. Important to know! The offline installer links do not include the automatic update feature. Google Chrome 137.0.7151.120 changelog: [$7000][420697404] High CVE-2025-6191: Integer overflow in V8. Reported by Shaheen Fazim on 2025-05-27 [$4000][421471016] High CVE-2025-6192: Use after free in Profiler. Reported by Chaoyuan Peng (@ret2happy) on 2025-05-31 [425443272] Various fixes from internal audits, fuzzing and other initiatives Download web installer: Google Chrome Web 32-bit | Google Chrome 64-bit | Freeware Download: Google Chrome Offline Installer 64-bit | 128.0 MB Download: Google Chrome Offline Installer 32-bit | 115.0 MB Download page: Google Chrome Portable Download: Google Chrome MSI Installers for Windows (automatic update) View: Chrome Website | Release Notes Get alerted to all of our Software updates on Twitter at @NeowinSoftware
  • Recent Achievements

    • One Month Later
      gatilogistic earned a badge
      One Month Later
    • One Year In
      Custom Greek Shirts earned a badge
      One Year In
    • One Month Later
      Custom Greek Shirts earned a badge
      One Month Later
    • Week One Done
      Custom Greek Shirts earned a badge
      Week One Done
    • Week One Done
      topantidetectbrowser earned a badge
      Week One Done
  • Popular Contributors

    1. 1
      +primortal
      672
    2. 2
      ATLien_0
      281
    3. 3
      Michael Scrip
      223
    4. 4
      +FloatingFatMan
      190
    5. 5
      Steven P.
      146
  • Tell a friend

    Love Neowin? Tell a friend!