• 0

Java: Reading File & Loop help


Question

Hi... I'm a newbie at Java, so I was wondering if you guys could help me out...

I have txt file i'm reading scores and labels off of to make a bar graph.

First line is an integer (score), second line is the label ("Score 1"), and they alternate from then on. I have 5 scores, meaning ten lines in the txt file.

Anyway, I can read the txt file and make the bar graph perfectly, but when i make the loop, i always have to specify how many times to do the loop... I have no idea how to make it count how many items are in the txt file automatically or to stop when there are no more values.

Please help if you can :o

Here is my code for the loop area so far:

 int n = 0;
  int itemCount = 5;

  SimpleReader reader = new SimpleReader( "graphdata.dat" );

  while ( n < itemCount )
 	 {
 	 double number = reader.getInt();
 	 r = new SimpleRectangle( BAR_START, barPos, (int) number, BAR_HEIGHT );
 	 r.setColor( barColor );
 	 r.setToFill();
 	 graphWin.add( r );
 	 total = total + number;
 	 n = n + 1;
 	 barPos = barPos + BAR_HEIGHT + BAR_SPACER;

 	 String word = reader.getString();
 	 lab = new SimpleLabel( LABEL_START, labelPos, LABEL_WIDTH, LABEL_HEIGHT );
 	 lab.setText( word + ": " + (int) number );
 	 graphWin.add( lab );
 	 labelPos = labelPos + LABEL_HEIGHT + LABEL_SPACER;
 	 }
  reader.safeClose();

Link to comment
https://www.neowin.net/forum/topic/62996-java-reading-file-loop-help/
Share on other sites

6 answers to this question

Recommended Posts

  • 0

Well, I've got no idea what SimpleReader is, but if it's extending BufferedReader, reader.ready() will say if the file is ready or not.

So:

while(reader.ready()) {
........

or

while(reader.getInt() != *numberhere*)

If it returns an error number, just put that in the *numberhere*

It's hard though not knowing what your reader does or what methods it has to read the file with.

Edited by kjordan2001
  • 0

Use BufferedReader instead and to for the this question:

"or to stop when there are no more values"

use a while loop if the following code:

while (in.readLine() != null)
{
    //Code execution here
}

This code below is what i did some while back and should give you some hints on how to implement BufferedReader:

/**
 * Read Class - A Class that Read's a Text file
 * @author Saad Mahamood 
 * @version 10/10/02 
 */

import java.io.*;

public class Read  
{

    public Read()
    {
        //Default Constructor
    }


    /**
     * textFile - This method read's a text file and output's
     *            it's content's to the terminal
     *@execption - IOException 
     */
    public void textFile() throws IOException
    {
        File aFile = new File("read.txt");

        if ((!aFile.isFile()) || (!aFile.canRead()))
        {
            // Let's leave
            throw new IOException("File not found");
        }

            
        BufferedReader in = new BufferedReader(new FileReader(aFile));
        
        
        String theString = null;

        for (int i=0;i < 26; i++ ) 
        {
            theString = in.readLine();
            System.out.println(theString);
       	 
        }


    }



	public static void main(String[] args) 
	{
  System.out.println("Reading file");
        System.out.println("***********************");
        Read aread = new Read();
        try
        {
            aread.textFile();
        }
        catch(IOException e)
        {
            System.err.println("Anption occured!");
        }

	}
}

ss1.

  • 0

try {
    BufferedReader oBuffer = new BufferedReader(new FileReader(new File("Path\to\file.txt")));
} catch (FileNotFoundException e) {
    system.out.print("FileFound");
}

String s = null;
while(true) {
    s = oBuffer.readLine();
    if (s == null) break;

    //Do your Rectangle business here
}

BTW: IF you are finding you have to create your own readers and writers and you are a newbie, then you are going down the wrong path. The book "Core Java2" from Sun Press has a good chapter that deals with the intricacies of Readers and Writers (and InputStreams and OutputStreams). I suggest you read it. It will spare you a lot of time later down the line.

Also, try not to initialize your objects inside of a loop. You have a line

String word = reader.getString();

inside your loop. That is not very efficient. While not technically wrong, it is a bad habit to get into.

FREE TIP: (and off-topic) On a related note, careful with string concatenation inside loops. You don't do it on the example you supplied, but if you are reading a file the last thing you want to do is:

String s = new String();
String temp = null;
while (true) {
    temp = oBuffer.readLine();
    if (temp == null) break;
    s += temp;
}

If you read the book above, or any text on the net, you will learn to use a StringBuffer for this kind of operation.

Edited by PeterHammer
  • 0

sorry for the lack of reply the past few days, i haven't had a chance to jump back on the computer...

thanks for all your help... I'm a total newbie to Java, and i just found out how stupid it was to post the code that I have, since I found out that SimpleReader and all that stuff were custom classes from my teacher. sorry about that.

thanks for all your help though, i got it working now =)

thanks for all your help with BifferedReader also, I think i'm gonna study up on that one more... I'll read up a bit more before I ask for the next question.

Thanks again, and I really appreciate all of your help guys. :D

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • The look speaks volumes, doesn't it?  
    • Whatever happened to offering a desirable product is what lead to profit?
    • 2 articles down "more gamers are switching to Windows 11, according to Valve."
    • After 4 years, the w11 adoption should be huge, but thats not the case, you see adoption dropping in another post. there are so many valid reason why people stick on w10, microsoft need to stop the whole support end at october. XP and 7 had extended support until a good version of windows released that people moved on to. right now w11 its a mess, its unreliable, unstable, buggy and the forced usability downgrades. Now more than ever people have alternatives even now M$ have a version with support until 2027 and 2032. its not that hard to keep supporting 10 until then. Hopefully by then w12 release and its a good option
    • Data (Use and Access) Bill faces pushback over AI and creative rights in UK parliament by Fiza Ali Image via: BBC In recent months, a series of high‐profile controversies has highlighted growing tension between technology platforms, content creators, and regulators over how artificial intelligence is trained and used. Previously, LinkedIn admitted sharing private messages to train its models, Meta was sued in France for using copyright‐protected content without authorisation, and OpenAI is paradoxically urging US lawmakers to expand "fair use" for AI. Meanwhile, several leading publishers, among them The New York Times and The Guardian, launched a "Support Responsible AI" campaign, accusing Big Tech of profiting from unlicensed journalism. Against this backdrop, the UK’s Data (Use and Access) Bill, which would allow AI firms to use all published content unless rights-holders opt out, has stalled in Parliament, with over 300 peers demanding AI companies disclose and license any copyrighted material they employ. Baroness Beeban Kidron has proposed an amendment requiring the Secretary of State for Science, Innovation, and Technology to report on the bill’s impact on the creative industries three months after it becomes law, unless the bill is amended first. Supporters of the government’s position, including Sir Nick Clegg, former president of global affairs at Meta, argue that requiring individual licences from all rights-holders would impose an unmanageable administrative burden and could deter AI investment in the UK. They say a broad opt-out regime is necessary for innovation. Opponents counter that unlicensed use of creative content risks harming writers, musicians, filmmakers, and other creators by allowing AI tools to produce similar work without compensation. Prominent artists such as Sir Elton John, Sir Paul McCartney, and Dua Lipa have warned that unrestricted access to their work could undermine their income and legacy. The debate traces back to early AI development, when large technology firms scraped substantial amounts of text, images, and other media from the internet without paying rights-holders. In 2022, the Ninth Circuit Court of Appeals held that "data scraping" does not constitute hacking, meaning it was not illegal to harvest publicly available website content so long as no defensive measures were bypassed. Those scraped datasets were then used to train generative models capable of producing text, images, and music in the styles of established creators. The Department for Science, Innovation, and Technology is conducting a broader consultation and will not amend the bill unless changes are deemed satisfactory for creators. If the bill cannot be agreed upon, it risks being withdrawn. The current impasse reflects a wider tension between supporting AI-driven innovation and protecting the economic interests of the creative industries. Until both Houses reach a compromise or one side concedes, the bill’s future remains uncertain.
  • Recent Achievements

    • Week One Done
      Epaminombas earned a badge
      Week One Done
    • Week One Done
      Prestige Podiatry Care earned a badge
      Week One Done
    • Week One Done
      rollconults earned a badge
      Week One Done
    • One Month Later
      lilred1938 earned a badge
      One Month Later
    • Week One Done
      lilred1938 earned a badge
      Week One Done
  • Popular Contributors

    1. 1
      +primortal
      134
    2. 2
      Xenon
      130
    3. 3
      ATLien_0
      123
    4. 4
      +Edouard
      102
    5. 5
      snowy owl
      95
  • Tell a friend

    Love Neowin? Tell a friend!