• 0

Java: Reading File & Loop help


Question

Hi... I'm a newbie at Java, so I was wondering if you guys could help me out...

I have txt file i'm reading scores and labels off of to make a bar graph.

First line is an integer (score), second line is the label ("Score 1"), and they alternate from then on. I have 5 scores, meaning ten lines in the txt file.

Anyway, I can read the txt file and make the bar graph perfectly, but when i make the loop, i always have to specify how many times to do the loop... I have no idea how to make it count how many items are in the txt file automatically or to stop when there are no more values.

Please help if you can :o

Here is my code for the loop area so far:

 int n = 0;
  int itemCount = 5;

  SimpleReader reader = new SimpleReader( "graphdata.dat" );

  while ( n < itemCount )
 	 {
 	 double number = reader.getInt();
 	 r = new SimpleRectangle( BAR_START, barPos, (int) number, BAR_HEIGHT );
 	 r.setColor( barColor );
 	 r.setToFill();
 	 graphWin.add( r );
 	 total = total + number;
 	 n = n + 1;
 	 barPos = barPos + BAR_HEIGHT + BAR_SPACER;

 	 String word = reader.getString();
 	 lab = new SimpleLabel( LABEL_START, labelPos, LABEL_WIDTH, LABEL_HEIGHT );
 	 lab.setText( word + ": " + (int) number );
 	 graphWin.add( lab );
 	 labelPos = labelPos + LABEL_HEIGHT + LABEL_SPACER;
 	 }
  reader.safeClose();

Link to comment
https://www.neowin.net/forum/topic/62996-java-reading-file-loop-help/
Share on other sites

6 answers to this question

Recommended Posts

  • 0

Well, I've got no idea what SimpleReader is, but if it's extending BufferedReader, reader.ready() will say if the file is ready or not.

So:

while(reader.ready()) {
........

or

while(reader.getInt() != *numberhere*)

If it returns an error number, just put that in the *numberhere*

It's hard though not knowing what your reader does or what methods it has to read the file with.

Edited by kjordan2001
  • 0

Use BufferedReader instead and to for the this question:

"or to stop when there are no more values"

use a while loop if the following code:

while (in.readLine() != null)
{
    //Code execution here
}

This code below is what i did some while back and should give you some hints on how to implement BufferedReader:

/**
 * Read Class - A Class that Read's a Text file
 * @author Saad Mahamood 
 * @version 10/10/02 
 */

import java.io.*;

public class Read  
{

    public Read()
    {
        //Default Constructor
    }


    /**
     * textFile - This method read's a text file and output's
     *            it's content's to the terminal
     *@execption - IOException 
     */
    public void textFile() throws IOException
    {
        File aFile = new File("read.txt");

        if ((!aFile.isFile()) || (!aFile.canRead()))
        {
            // Let's leave
            throw new IOException("File not found");
        }

            
        BufferedReader in = new BufferedReader(new FileReader(aFile));
        
        
        String theString = null;

        for (int i=0;i < 26; i++ ) 
        {
            theString = in.readLine();
            System.out.println(theString);
       	 
        }


    }



	public static void main(String[] args) 
	{
  System.out.println("Reading file");
        System.out.println("***********************");
        Read aread = new Read();
        try
        {
            aread.textFile();
        }
        catch(IOException e)
        {
            System.err.println("Anption occured!");
        }

	}
}

ss1.

  • 0

try {
    BufferedReader oBuffer = new BufferedReader(new FileReader(new File("Path\to\file.txt")));
} catch (FileNotFoundException e) {
    system.out.print("FileFound");
}

String s = null;
while(true) {
    s = oBuffer.readLine();
    if (s == null) break;

    //Do your Rectangle business here
}

BTW: IF you are finding you have to create your own readers and writers and you are a newbie, then you are going down the wrong path. The book "Core Java2" from Sun Press has a good chapter that deals with the intricacies of Readers and Writers (and InputStreams and OutputStreams). I suggest you read it. It will spare you a lot of time later down the line.

Also, try not to initialize your objects inside of a loop. You have a line

String word = reader.getString();

inside your loop. That is not very efficient. While not technically wrong, it is a bad habit to get into.

FREE TIP: (and off-topic) On a related note, careful with string concatenation inside loops. You don't do it on the example you supplied, but if you are reading a file the last thing you want to do is:

String s = new String();
String temp = null;
while (true) {
    temp = oBuffer.readLine();
    if (temp == null) break;
    s += temp;
}

If you read the book above, or any text on the net, you will learn to use a StringBuffer for this kind of operation.

Edited by PeterHammer
  • 0

sorry for the lack of reply the past few days, i haven't had a chance to jump back on the computer...

thanks for all your help... I'm a total newbie to Java, and i just found out how stupid it was to post the code that I have, since I found out that SimpleReader and all that stuff were custom classes from my teacher. sorry about that.

thanks for all your help though, i got it working now =)

thanks for all your help with BifferedReader also, I think i'm gonna study up on that one more... I'll read up a bit more before I ask for the next question.

Thanks again, and I really appreciate all of your help guys. :D

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Steve Jobs' wife wants to see Jony Ive-OpenAI's mysterious AI gadget succeed by Hamid Ganji This month, OpenAI, the company behind ChatGPT, made a significant stride by announcing a $6.5 billion acquisition of io. The startup belongs to former Apple design chief Jony Ive and OpenAI's current CEO, Sam Altman, and it's working on a mysterious AI gadget. Interestingly, another person who benefited from this deal and its future outcomes is Steve Jobs's wife, Laurene Powell Jobs. With a net worth of over $14 billion, Powell Jobs is the founder and president of Emerson Collective, an investment firm. After Ive left Apple in 2019 and founded his businesses, LoveFrom and io, Powell Jobs seized the opportunity to invest in both startups. The investment is said to exceed $1 billion. In an interview with The Financial Times, Jony Ive and Powell Jobs discussed their experience working with Steve Jobs as well as the dark side of technology. Ive said one of his incentives for collaborating with OpenAI and Sam Altman is that "humanity deserves better." In another interview in May, Jony Ive also hinted at the "unintended consequences" of his work at Apple that "were far from pleasant." "If you make something new, if you innovate, there will be consequences unforeseen, and some will be wonderful and some will be harmful," Ive added. "While some of the less positive consequences were unintentional, I still feel responsibility. And the manifestation of that is a determination to try and be useful." Laurene Powell Jobs also confirmed Jony Ive's comments, adding that "there are dark uses for certain types of technology," even if the tech wasn't initially designed with that kind of use in mind. Apple's former design chief also endorsed Powell Jobs's involvement in LoveFrom, saying the company could not exist without her help. Yet, the product Ive and OpenAI have in mind is still a mystery, but some people speculated that it might be a screenless AI phone. Meanwhile, some analysts believe the collaboration between Ive and OpenAI should raise the alarms for Apple.
    • Because some people prefer to pay for a service instead of attaining it dishonestly... You comment makes about as much sense as saying, "why would anyone pay for Netflix when torrents exist?"
    • Boy, I wonder how much time they'll save when Copilot ######s something up and they find out the error years if not decades later. It's not like UK had a massive ######up within their postal service decades ago that destroyed hundreds of lives of Brits because their computer systems were hallucinating s**t...
    • You clearly missed the sarcasm in that comment. It's pretty clear that the point of that comment was to point out the irony in the fact that nearly every negative thing people say about Windows 11, also applies to Windows 10. Heck, even the Win10 start menu was wildly unpopular when it came out.
    • Even biggest AMD fans and Intel haters will love this 14600K deal as you get free 240 AIO by Sayan Sen Last week, the Intel 14600K was on sale for $193, and you also got a free game with it. However, it looks like there is still some stock of these chips left, as the processor is selling for $199. Along with the free game, you also get a free 240 mm AIO liquid cooler (purchase link under the specs list below). The 14600K is based on Intel's 14th Gen Raptor Lake Refresh design. Since it is a K variant, it is unlocked for overclocking. However, do keep in mind that it is a fairly power-hungry processor, much more so than something like an equivalent Ryzen. But the chip is fairly powerful, and you can enjoy excellent gaming and productivity performance with it. Speaking of AMD Ryzen, the 14600K is about equivalent to the Zen 4-based 7600(X) in gaming and faster in productivity, thanks to the E-cores. Ensure your motherboard has decent VRM power delivery and cooling (ideally a Z790 chipset motherboard), plus you will need a good quality air cooler (and a complementary good case with excellent airflow) or a 240/280 mm AIO liquid cooler. Thus this is where the free MSI AIO cooler will come in handy. The technical specs of the 14600K are given below: Core Count: 14 (6 Performance Cores + 8 Efficiency Cores) Thread Count: 20 Base Clock Frequency: 3.5 GHz (P-core), 2.6 GHz (E-core) Boost Clock Frequency: Up to 5.3 GHz Cache: 24 MB Cache Stock Memory Support: DDR4 (3200 MT/s) and DDR5 (5600 MT/s) Socket: LGA 1700 TDP: 125 W Integrated Graphics: Intel UHD Graphics 770 PCIe Support: PCIe Gen 5 (16 lanes) and Gen 4 (4 lanes) Process Technology: Intel 7 (10 nm) Maximum Temperature: 100° C Get the Intel Core i5-14600K at the link below (make sure to select the checkbox for the free AIO and the free game): Intel Core i5-14600K BX8071514600K + MSI MAG Coreliquid A13 240mm Liquid Cooler 240mm + Free Intel Spring Bundle (Civilization VII & Dying Light: The Beast): $199.99 (Sold and Shipped by Newegg US first-party seller) This Amazon deal is US-specific and not available in other regions unless specified. If you don't like it or want to look at more options, check out the Amazon US deals page here. Get Prime (SNAP), Prime Video, Audible Plus or Kindle / Music Unlimited. Free for 30 days. As an Amazon Associate, we earn from qualifying purchases.
  • Recent Achievements

    • First Post
      ClarkB earned a badge
      First Post
    • Week One Done
      Epaminombas earned a badge
      Week One Done
    • Week One Done
      Prestige Podiatry Care earned a badge
      Week One Done
    • Week One Done
      rollconults earned a badge
      Week One Done
    • Week One Done
      lilred1938 earned a badge
      Week One Done
  • Popular Contributors

    1. 1
      +primortal
      143
    2. 2
      Xenon
      130
    3. 3
      ATLien_0
      124
    4. 4
      +Edouard
      102
    5. 5
      snowy owl
      97
  • Tell a friend

    Love Neowin? Tell a friend!