• 0

Java: Reading File & Loop help


Question

Hi... I'm a newbie at Java, so I was wondering if you guys could help me out...

I have txt file i'm reading scores and labels off of to make a bar graph.

First line is an integer (score), second line is the label ("Score 1"), and they alternate from then on. I have 5 scores, meaning ten lines in the txt file.

Anyway, I can read the txt file and make the bar graph perfectly, but when i make the loop, i always have to specify how many times to do the loop... I have no idea how to make it count how many items are in the txt file automatically or to stop when there are no more values.

Please help if you can :o

Here is my code for the loop area so far:

 int n = 0;
  int itemCount = 5;

  SimpleReader reader = new SimpleReader( "graphdata.dat" );

  while ( n < itemCount )
 	 {
 	 double number = reader.getInt();
 	 r = new SimpleRectangle( BAR_START, barPos, (int) number, BAR_HEIGHT );
 	 r.setColor( barColor );
 	 r.setToFill();
 	 graphWin.add( r );
 	 total = total + number;
 	 n = n + 1;
 	 barPos = barPos + BAR_HEIGHT + BAR_SPACER;

 	 String word = reader.getString();
 	 lab = new SimpleLabel( LABEL_START, labelPos, LABEL_WIDTH, LABEL_HEIGHT );
 	 lab.setText( word + ": " + (int) number );
 	 graphWin.add( lab );
 	 labelPos = labelPos + LABEL_HEIGHT + LABEL_SPACER;
 	 }
  reader.safeClose();

Link to comment
https://www.neowin.net/forum/topic/62996-java-reading-file-loop-help/
Share on other sites

6 answers to this question

Recommended Posts

  • 0

Well, I've got no idea what SimpleReader is, but if it's extending BufferedReader, reader.ready() will say if the file is ready or not.

So:

while(reader.ready()) {
........

or

while(reader.getInt() != *numberhere*)

If it returns an error number, just put that in the *numberhere*

It's hard though not knowing what your reader does or what methods it has to read the file with.

Edited by kjordan2001
  • 0

Use BufferedReader instead and to for the this question:

"or to stop when there are no more values"

use a while loop if the following code:

while (in.readLine() != null)
{
    //Code execution here
}

This code below is what i did some while back and should give you some hints on how to implement BufferedReader:

/**
 * Read Class - A Class that Read's a Text file
 * @author Saad Mahamood 
 * @version 10/10/02 
 */

import java.io.*;

public class Read  
{

    public Read()
    {
        //Default Constructor
    }


    /**
     * textFile - This method read's a text file and output's
     *            it's content's to the terminal
     *@execption - IOException 
     */
    public void textFile() throws IOException
    {
        File aFile = new File("read.txt");

        if ((!aFile.isFile()) || (!aFile.canRead()))
        {
            // Let's leave
            throw new IOException("File not found");
        }

            
        BufferedReader in = new BufferedReader(new FileReader(aFile));
        
        
        String theString = null;

        for (int i=0;i < 26; i++ ) 
        {
            theString = in.readLine();
            System.out.println(theString);
       	 
        }


    }



	public static void main(String[] args) 
	{
  System.out.println("Reading file");
        System.out.println("***********************");
        Read aread = new Read();
        try
        {
            aread.textFile();
        }
        catch(IOException e)
        {
            System.err.println("Anption occured!");
        }

	}
}

ss1.

  • 0

try {
    BufferedReader oBuffer = new BufferedReader(new FileReader(new File("Path\to\file.txt")));
} catch (FileNotFoundException e) {
    system.out.print("FileFound");
}

String s = null;
while(true) {
    s = oBuffer.readLine();
    if (s == null) break;

    //Do your Rectangle business here
}

BTW: IF you are finding you have to create your own readers and writers and you are a newbie, then you are going down the wrong path. The book "Core Java2" from Sun Press has a good chapter that deals with the intricacies of Readers and Writers (and InputStreams and OutputStreams). I suggest you read it. It will spare you a lot of time later down the line.

Also, try not to initialize your objects inside of a loop. You have a line

String word = reader.getString();

inside your loop. That is not very efficient. While not technically wrong, it is a bad habit to get into.

FREE TIP: (and off-topic) On a related note, careful with string concatenation inside loops. You don't do it on the example you supplied, but if you are reading a file the last thing you want to do is:

String s = new String();
String temp = null;
while (true) {
    temp = oBuffer.readLine();
    if (temp == null) break;
    s += temp;
}

If you read the book above, or any text on the net, you will learn to use a StringBuffer for this kind of operation.

Edited by PeterHammer
  • 0

sorry for the lack of reply the past few days, i haven't had a chance to jump back on the computer...

thanks for all your help... I'm a total newbie to Java, and i just found out how stupid it was to post the code that I have, since I found out that SimpleReader and all that stuff were custom classes from my teacher. sorry about that.

thanks for all your help though, i got it working now =)

thanks for all your help with BifferedReader also, I think i'm gonna study up on that one more... I'll read up a bit more before I ask for the next question.

Thanks again, and I really appreciate all of your help guys. :D

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Windows 10 EOL is coming, so how many is “forced”? (to be prepared and not wait until the last moment in October?)
    • I guess more Windows users are switching on their desktops/laptops than people buying new Steam Decks. I wouldn't be surprised. Deck doesn't have the mainstream appeal of other handhelds, usually people who would want one already have one. Glad to see Linux go up!
    • Any news about Windows and Microsoft always brings up crazy people saying; - Windows 11 is terrible, it destroys my hardware, it had sex with my wife, it told the FBI that I visit shemale sites, it collects my data where I get illegal anime. Never use Windows 11, go for Linux and it will never have sex with your wife.
    • QOwnNotes 25.6.0 by Razvan Serea QOwnNotes is a open source (GPL) plain-text file notepad with markdown support and todo list manager for GNU/Linux, Mac OS X and Windows, that (optionally) works together with the notes application of ownCloud (or Nextcloud). So you are able to write down your thoughts with QOwnNotes and edit or search for them later from your mobile device (like with CloudNotes) or the ownCloud web-service. The notes are stored as plain text files and you can sync them with your ownCloud sync client. Of course other software, like Dropbox, Syncthing, Seafile or BitTorrent Sync can be used too. Features: the notes folder can be freely chosen (multiple note folders can be used) sub-string searching of notes is possible and search results are highlighted in the notes application can be operated with customizable keyboard shortcuts external changes of note files are watched (notes or note list are reloaded) older versions of your notes can be restored from your ownCloud server trashed notes can be restored from your ownCloud server differences between current note and externally changed note are showed in a dialog markdown highlighting of notes and a markdown preview mode notes are getting their name from the first line of the note text (just like in the ownCloud notes web-application) and the note text files are automatically renamed, if the the first line changes compatible with the notes web-application of ownCloud and mobile ownCloud notes applications compatible with ownCloud's selective sync feature by supporting an unlimited amount of note folders with the ability to choose the respective folder on your server manage your ownCloud todo lists (ownCloud tasks or Tasks Plus / Calendar Plus) or use an other CalDAV server to sync your tasks to encryption of notes (AES-256 is built in or you can use custom encryption methods like Keybase.io (encryption-keybase.qml) or PGP (encryption-pgp.qml)) dark mode theme support theming support for the markdown syntax highlighting all panels can be placed wherever you want, they can even float or stack (fully dockable) support for freedesktop theme icons, you can use QOwnNotes with your native desktop icons and with your favorite dark desktop theme support for hierarchical note tagging and note subfolders support for sharing notes on your ownCloud server portable mode for carrying QOwnNotes around on USB sticks Evernote import QOwnNotes is available in many different languages like English, German, French, Polish, Chinese, Japanese, Russian, Portuguese, Hungarian, Dutch and Spanish Changes in QOwnNotes 25.6.0: QOwnNotes now builds with with Botan 3, when built with the system Botan library (cmake build parameter -DBUILD_WITH_SYSTEM_BOTAN=ON), because of the end of life of Botan 2 (for #2786) Keep in mind that Botan 3 needs C++20, which causes issues on Qt5 QMake and Qt5 will still use the internal Botan 2 amalgamation Creating an amalgamation Botan 3 did work, but caused major issues with various build processes The filename in checksum files of the Qt6 AppImages in the releases on GitHub was fixed (for #3286) Download: QOwnNotes 25.6.0 | 37.3 MB (Open Source) Download: QOwnNotes for Other Operating Systems View: QOwnNotes Home Page | Screenshot Get alerted to all of our Software updates on Twitter at @NeowinSoftware
    • There are lots of older PC's that are now going to be unsupported on W10, but for modern systems, you should be able to update to W11. Even so, there are ways to bypass the official hardware requirements as well as the MSA (which imo is the bigger annoyance). My only gripe with W11 is all the telemetry collection / bloatware - yes, it is a problem compared to W10 and Linux.
  • Recent Achievements

    • Week One Done
      Epaminombas earned a badge
      Week One Done
    • Week One Done
      Prestige Podiatry Care earned a badge
      Week One Done
    • Week One Done
      rollconults earned a badge
      Week One Done
    • One Month Later
      lilred1938 earned a badge
      One Month Later
    • Week One Done
      lilred1938 earned a badge
      Week One Done
  • Popular Contributors

    1. 1
      +primortal
      148
    2. 2
      Xenon
      132
    3. 3
      ATLien_0
      123
    4. 4
      +Edouard
      103
    5. 5
      snowy owl
      96
  • Tell a friend

    Love Neowin? Tell a friend!