Redirection and Counter Update Problem

[seb86]

OK i have 2 functions, one checks to see if the property has been sold, two updates the visitors counter on the property and the date of that last visit.

The first one does not work as I have a session file that already starts the header so I get this error.

Warning: Cannot modify header information - headers already sent by (output started at /home/account/public_html/listing.php:50) in /home/account/public_html/listing.php on line 50

The second one does not update the values that I have put. The code I have written is for when the visitor is on the property page so it should be collecting the information fine as the error appears for when trying to redirect to the new page. So the page is viewed like this in the address bar: - www.sitename.com/listing.php?id=1 (This is for when the property is still up for sale and if not redirect to the page I want redirected to above).

Here is my table structure:

TABLE IF NOT EXISTS `properties` (
  `property_id` int(11) NOT NULL auto_increment,
  `visits` varchar(255) collate utf8_bin NOT NULL,
  `last_visit` datetime NOT NULL default '0000-00-00 00:00:00',
  PRIMARY KEY  (`property_id`),
) ENGINE=MyISAM  DEFAULT CHARSET=utf8 COLLATE=utf8_bin;

I would like it to also count 1 per IP location so that it's fare, but I don't know how to log that into the table, I might need one for stats where it logs the users IP address and browser, screen resolution and so on.

This is what I have written so far.

<?php
///// Get more information about the property /////
$sql = "SELECT * FROM properties WHERE property_id='$id' AND status='1' AND active='1'";
$query = @mysql_query($sql);
while ($result = @mysql_fetch_array($query)){
$id = $result['$property_id'];
$sale_type = $result['sale_type'];
$visits = $result['visits'];
$lastvisit = $result['$last_visit'];
$active = $result['$active'];
}
///// Checks if property has been sold or removed. /////
if ($sale_type == 1){
	header("Location: delisted.php?id=$id");
?>
<?php
///// If property has not been sold or removed, continue to display property details. /////
}
///// Update Property Views Counter /////
if ($visits != "" || !empty($visits)){
	$visits_counter = $visits +1;
   	$lastvisit  = date("Y:m:d H:i:s");
	$sqlvisits = mysql_query("UPDATE properties SET visits='$visits_counter' AND last_visit='$lastvisit' WHERE property_id = '$id'");
	$query = @mysql_query($sqlvisits);
}
?>

So if someone can help on this, it would be most appreciated.

Thank you.

[Original Poster]

hey, erm im not really sure what you want?

i can say thou to get browser info you use the varible $_SERVER

hey, erm im not really sure what you want?

i can say thou to get browser info you use the varible $_SERVER (may need $server but i think u need the underscore either way it gives u loads of info on the viewer =D)

[seb86]

  hackncrap said:

hey, erm im not really sure what you want?

i can say thou to get browser info you use the varible $_SERVER

hey, erm im not really sure what you want?

i can say thou to get browser info you use the varible $_SERVER (may need $server but i think u need the underscore either way it gives u loads of info on the viewer =D)

What I would like is clearly written in my post. The purpose of this code is to count how many people have visited the property but I only want the counter to be updated per ip. Also the property viewing page checks if the property is or has been sold or not before loading the page. If the property is sold then the user is redirected to another page on the website.

[FlibbyFlobby]

Well to get the clients ip address you can use:

$_SERVER['REMOTE_ADDR'];

You'll need to store all the ip addresses that have visited a particular property, and then only update the count if its not already in that list. Pretty simple really.

[seb86]

I have updated the code a bit but still not getting either function working.

<?php
///// Collect information about the property /////
$sql = "SELECT * FROM ".TBL_PROPERTIES." WHERE property_id='$id' AND sale_type='1' AND status='1' AND active='1'";
$query = mysql_query($sql);
while ($result = @mysql_fetch_array($query)){
$id = $result['$property_id'];
$sale_type = $result['sale_type'];
$visits = $result['visits'];
$lastvisit = $result['$last_visit'];
}

///// Checks if property has been sold or removed. /////
if ($sale_type == 0){
	header("Location: delisted.php?id=$id");
}

///// If property has not been sold or removed, continue to display property details. /////

///// Update Property Views Counter /////
if($visits = mysql_query("SELECT COUNT (visits) FROM ".TBL_PROPERTIES." WHERE property_id='$id' AND visits='$visits'")){
	while($row = mysql_fetch_assoc($visits)){
	$counter = $visits; //count the number of times the property has been viewed
	if ($counter != "" || !empty($counter)){
		$visits_counter = $counter +1; //add 1 to the counter when property is viewed
	   	$lastvisit  = date("Y:m:d H:i:s"); // update the date when property was last looked at
		$sqlvisits = mysql_query("UPDATE ".TBL_PROPERTIES." SET visits='$visits_counter', last_visit='$lastvisit' WHERE property_id='$id'");
		$query = mysql_query($sqlvisits);
		}
	}
}
?>

The sql will not update the columns set to be updated and detecting on wither or not the property is sold or removed reads correcly.

If any one can help me on this I would mostly appreciate it.

The IP thing i will leave out for the moment so don't help me with that feature.

Edited September 1, 2008 by admin2gd1

[metal_dragen Veteran]

Well, for one, you could simplify that update counter quite a bit, like down to two lines.

$sqlvisits = mysql_query("UPDATE ".TBL_PROPERTIES." SET visits=visits+1, last_visit=UNIX_TIMESTAMP() WHERE property_id='$id'");
$query = mysql_query($sqlvisits);

I would suggest altering how you store dates and times. Use a standard integer field and store a unix timestamp. You can easily display the human readable date in any form from that, plus it's less work to store, and MySQL has a UNIX_TIMESTAMP() function built-in.

Second, it sounds like you already know you have another page with output, so I'm not sure why you are having problems with your header() function call. It needs to be called, if it's going to be called, before anything is output to the browser.

If you can't avoid that, I'd suggest a simple trick I use. Echo out some Javascript that does the same thing:

echo '&lt;script type="text/javascript"&gt;document.location.href = "delisted.php?id='.$id.'";</script>

[seb86]

  metal_dragen said:

Well, for one, you could simplify that update counter quite a bit, like down to two lines.

$sqlvisits = mysql_query("UPDATE ".TBL_PROPERTIES." SET visits=visits+1, last_visit=UNIX_TIMESTAMP() WHERE property_id='$id'");
$query = mysql_query($sqlvisits);

I would suggest altering how you store dates and times. Use a standard integer field and store a unix timestamp. You can easily display the human readable date in any form from that, plus it's less work to store, and MySQL has a UNIX_TIMESTAMP() function built-in.

Second, it sounds like you already know you have another page with output, so I'm not sure why you are having problems with your header() function call. It needs to be called, if it's going to be called, before anything is output to the browser.

If you can't avoid that, I'd suggest a simple trick I use. Echo out some Javascript that does the same thing:

echo '&lt;script type="text/javascript"&gt;document.location.href = "delisted.php?id='.$id.'";</script>

The java trick did not work.

[FlibbyFlobby]

  metal_dragen said:

Well, for one, you could simplify that update counter quite a bit, like down to two lines.

$sqlvisits = mysql_query("UPDATE ".TBL_PROPERTIES." SET visits=visits+1, last_visit=UNIX_TIMESTAMP() WHERE property_id='$id'");
$query = mysql_query($sqlvisits);

I would suggest altering how you store dates and times. Use a standard integer field and store a unix timestamp. You can easily display the human readable date in any form from that, plus it's less work to store, and MySQL has a UNIX_TIMESTAMP() function built-in.

I've never understood why people feel the need to store dates as unix timestamps instead of datetimes. There's certainly no real benefits to it. Getting MySQL or even PHP to reformat your dates to a human readable form (or even to a unix timestamp) is quick and easy. Date and datetime exist for a reason.