• 0

Java: Generate the alphabet in random order, no duplicates


Question

Hi guys,

I am taking an introductory programming course and need a bit of help. The assignment is to have the Java program read a message (I am assuming from a .dat file, not quite sure). The program creates substitutes each random letter with a different letter chosen at random by the computer. If the letter M is chosen to replace the letter P in the message, then M replaces P in every instance of the message.

Right now, I just need help with generating a set of the 26 letters ordered randomly without duplicates. Here is what I have:

  Quote
import java.util.Random;

public class encrypt {

public static void main(String[] args) {

char [] alphabet =

{'A','B','C','D','E','F','G','H','I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z'};

char [] substitute =

{'A','B','C','D','E','F','G','H','I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z'};

boolean done=false;

Random generator = new Random();

int i, j, k, random;

while(done==false) {

for(i=0; i<=25; i++) {

random = generator.nextInt(25);

substitute=alphabet[random];

for(j=0; j<=i; j++) {

while(substitute[j]==substitute) {

random = generator.nextInt(25);

if(substitute[j]!=substitute) {

substitute=alphabet[random];

}

}

}

}

for(k=0; k<=25; k++) {

System.out.print(substitute[k] + ", ");

}

done=true;

}

}

}

Right now the program does nothing. If I remove the last for loop with j as the counter and everything within that for loop, I get an output of 26 letters randomly chosen, but there are duplicates. The last for loop is supposed to say something like, "If the randomly generated letter (substitute) has appeared before in substitute[], then generate a new random number until it is no longer a duplicate of a previous number, at which point the letter which corresponds to the random number is stored in substitute.

So if you could give me some suggestions it would be much appreciated. If I am overcomplicating things and there is a much easier way to do this, please guide me in the right direction.

Thanks,

Noah

EDIT: Spacing in the program code isn't working. Looks fine while I'm editing it though. What's wrong?

EDIT 2: See here for my code, correctly formatted.

Edited by -Noah-

Recommended Posts

  • 0

Your way seems a little strange unless I am missing something. Why don't you just have an array for the alphabet and then just pick a letter at random when you need it. From what I understood you don't actually need an entire randomised alphabet.

  • 0
  Zapadlo said:
Your way seems a little strange unless I am missing something. Why don't you just have an array for the alphabet and then just pick a letter at random when you need it. From what I understood you don't actually need an entire randomised alphabet.

Thanks for the response.

How would I make sure that I do not pick the same letter from the alphabet array more than once?

  • 0

You could always switch to using a LinkedList instead of an array, when you choose a letter, you just remove it from the list.

The size of the list would decrease each time, so you'd need to generate a random number using the variable linkedlist.size() instead of 25.

  • 0

I would stick to the array personally and have another with the letters already used so that when a new random letter is picked it is checked against those in the already used array.

LinkedLists - /covers eyes and shrieks

Sorry, personal disposition :)

  • 0
  Zapadlo said:
I would stick to the array personally and have another with the letters already used so that when a new random letter is picked it is checked against those in the already used array.

LinkedLists - /covers eyes and shrieks

Sorry, personal disposition :)

why would you want to maintain 2 arrays versus a single shrinking array that will only ever have letters you can use?

not to mention random doesn't mean true random, you could (however unlikely this is) end up randomizing the same already used letter multiple times in a row

  • 0
  ecstasis said:
why would you want to maintain 2 arrays versus a single shrinking array that will only ever have letters you can use?

not to mention random doesn't mean true random, you could (however unlikely this is) end up randomizing the same already used letter multiple times in a row

I can see what you are saying, and it is true, but I am compelled to say, so?

  • 0

That was my problem: I knew there would be a chance that it could generate the same letter again. That's why I made my code the way I did. Also, I don't see how creating a "used letters" array would be any better than my method.

The only problem is, why doesn't my code work!?!?

How would I go about creating a linked list in Java? I looked online and unless I am missing something, it looks pretty complicated.

  • 0

import java.util.Random;
import java.io.*;
import java.lang.*;
import java.lang.String.*;



public class encrypt {

public static void main(String[] args) {

char [] alphabet =
{'A','B','C','D','E','F','G','H','I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z'};
char [] substitute =
{'A','B','C','D','E','F','G','H','I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z'};
char [] used =
{'0','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'};
boolean done=false;
Random generator = new Random();
int i, j, k, random, count;

count = 0;

System.out.print("Enterring: ");

	  //  open up standard input
	  BufferedReader br = new BufferedReader(new InputStreamReader(System.in));

	  String input = null;

	  //  read the username from the command-line; need to use try/catch with the
	  //  readLine() method
	  try {
		 input = br.readLine();
	  } catch (IOException ioe) {
		 System.out.println("IOr");
		 System.exit(1);
	  }

	  //loop
	  for (int l = 0; l &lt; input.length(); l++)	{
		  count++;

  }
		  System.out.println(count);

		for(int p = 0; p &lt;count; p++)	{

			int result = 0 + (int) ( Math.random()*(26) );

			char temp = alphabet[result];

			char temp2 = '1';
			int o = 0;
			while(temp2 != '0')	{
			//for(int o = 0; o &lt; used.length(); o++)	{

				temp2 = used[o];

				if(temp == temp2) {					
					result = 0 + (int) ( Math.random()*(26) );
				}
				o++;
			}
			char temp3;
			temp3 = input.chatAt(count); // No idea why this doesn't work
			alphabet[result] = temp3;


			count++;
		}


	  System.out.println(input);


while(done==false) {
for(i=0; i&lt;=25; i++) {
random = generator.nextInt(25);
substitute[i]=alphabet[random];
for(j=0; j&lt;=i; j++) {
while(substitute[j]==substitute[i]) {
random = generator.nextInt(25);
if(substitute[j]!=substitute[i]) {
substitute[i]=alphabet[random];
}
}
}
}
for(k=0; k&lt;=25; k++) {
System.out.print(substitute[k] + ", ");
}
done=true;
}
}
}

Something like that, only charAt doesn't work, sorry I'm tired so if you can fix that part I can check the rest of the code.

Oh and this way you have all the letters you have used in an array for printing/whatever.

  Quote
So... then you don't have to compare and try the operation again...

All it is, is a for loop running through used array in case you pick a letter that has been already used you just pick a new random letter.

Edit: Actually, it only checks once and if it picks a letter that already occured again it proceeds when it shouldn't.

Also not accounting for spaces... /sigh there is actually quite a lot, hope it helps though.

Edited by Zapadlo
  • 0
  ecstasis said:
why would you want to maintain 2 arrays versus a single shrinking array that will only ever have letters you can use?

not to mention random doesn't mean true random, you could (however unlikely this is) end up randomizing the same already used letter multiple times in a row

Because LinkedLists seem a bit advanced for someone doing basic stuff like this in an introduction to a java course. Anyway:

Seems pretty sloppy (but it's 12:35am), but here it is. It's commented and stuff so you actually have a clue on what's going on. BTW, did you know you can declare variables while in for-loops? You don't need to declare "int i" as a member variable if you're just going to use it for for loops. Java should also just destroy the integer once you're out of the for loop, meaning you can reuse int i in another for loop if you so wish.

import java.util.Random;

public class encrypt {
  public static void main(String[] args) {
	char [] alphabet =  {'A','B','C','D','E','F','G','H','I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z'};
	char [] substitute = {'.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.'};  //this should be 26 dots, please check
	int [] numbers = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};  //this should be 26 zeros, please check to see if this correct!!

	for (int i=0; i&lt;=25; i++) {
	  random = generator.nextInt(25);
	  //keep running this if-else until we find a number we haven't used before
	  do {
		//if we find a number we haven't used before
		if (numbers[random] == 0) { 
		  numbers[random] = random; //then assign that position in the array that number (i.e. position 10 in the array will now have the number 10)
		  substitute[i] = alphabet[random];  //assign the current position of the substitute alphabet array the random letter from the real alphabet
		}
		else {
		  random = generator.nextInt(25); //if we hit a number we've already used, get another one
		}
	  } while (numbers[random] != 0)
	}
	for(int i=0; i&lt;=25; i++) {
	  System.out.print(substitute[i] + ", "); //print out your brand new randomised alphabet!
	}
  }
}

I'll admit, I have no idea if this works or not, as I don't have the java compiler on my computer any more (haven't done java in about a couple of years), but this should work. There's no harm in compiling it yourself though, just shout out any errors if there are any.

  • 0

heres my attempt, not compiled but i don't imagine its too far off (could be wrong tho)

private String jumble(String[] original) {
	Random gen = new Random();
	String[] alphabet = {"a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v", "x", "y", "z", " "};
	ArrayList alphabetaGenList = new ArrayList(Arrays.asList(alphabet));
	Hashtable newAlphabet = new Hashtable();
	StringBuffer jumbled = new StringBuffer();
		int randomAlphabetLetter = 27;

		//oops made a mistake with the random, 2nd edit
	for (int i = 0; i &lt; 27; i++) {
				int r = gen.nextInt(randomAlphabetLetter--);
		newAlphabet.put(alphabet[i], alphabetGenList.get(r));
		alphabetGenList.remove(r);
	}

	for (int i = 0; i &lt; original.length; i++) {
				jumbled.append(newAlphabet.get(original[i]));
	}	

	return jumbled.toString();
}

edit...

i guess thats a bit overkill since it converts the string too, but not many changes just to do the alphabet

Edited by ecstasis
  • 0

Thanks guys for all the replies.

Zapadlo: I don't know if you realized this, but you have chatAt instead of charAt. :p Even with that change, it throws an error:

Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: 5

at java.lang.String.charAt(Unknown Source)

at encrypt.main(encrypt.java:66)

The string index out of range value is always the number of characters that I have typed for the string. I'm guessing my code at the bottom was not supposed to be there. No problem, though. I live in the US, so it's quarter of 10 now. Didn't mean to give you guys Java code problems in the middle of the night! Is Neowin UK based?

-Noah

  • 0

Teej: I added a semicolon after the while statement. No errors, but here are some examples of the output:

Output 1. W, C, U, H, E, D, F, Q, A, ., T, K, ., ., J, ., X, ., L, ., R, ., O, ., ., .,

Output 2. V, ., P, ., H, K, Q, ., D, S, ., ., G, J, R, F, N, ., M, B, ., Y, ., ., W, U,

Output 3. X, O, W, I, P, ., U, G, Q, R, F, ., ., V, A, B, ., ., K, ., Y, H, ., E, T, M,

I cant figure out what is wrong, most likely because I don't exactly know what is going on with the do while. Does the while statement at the end tell the program to go through the do again under the specified conditions? If you have any more ideas for fixing this, they are welcome!

About the int within the for-loop, my teacher says that it wastes memory and that you should define those variables first, out of the for-loop (?). I'm guessing she's wrong. :laugh:

  • 0
  -Noah- said:
About the int within the for-loop, my teacher says that it wastes memory and that you should define those variables first, out of the for-loop (?). I'm guessing she's wrong. :laugh:

i'm not sure it would make a difference either way since those variables would go to the garbage collector once they are out of scope (i don't know exactly how java deals with).

  • 0

These solutions are all overkill...

- Make an ArrayList containing all 26 letters.

- generate random number from 0 to List.size()-1.

- List.get(randomNumber)

- List.remove(randomNumber)

loop and restart at step 2 until List.size() returns 0.

import java.util.*;

class alphaRandom {

	public static void main(String[] args) {

	ArrayList&lt;Character&gt; al = new ArrayList&lt;Character&gt;();
	Random gen = new Random();
	int num;

	for(int i = 65; i &lt;= 90; i++) {
		al.add((char)i);
	}

	while(al.size() &gt; 0) {
		num = gen.nextInt(al.size());
		System.out.print(al.get(num));
		al.remove(num);
	}
 }
}

Edited by Tech God
  • 0

I had to do this for school too.

Stick to your method of arrays. LinkedLists are a pain for this.

I say keep 1 array list(alphabet).

Then create a random number from 0 - array.length()-1

after that just loop thru and remove the letter that your random number is. Havent done java in a few months so I dont know the EXACT array command to say "array.get? or etc".

Idk, but logically I would do it this way. Easier.

  • 0
  Tech God said:
These solutions are all overkill...

- Make an ArrayList containing all 26 letters.

- generate random number from 0 to List.size()-1.

- List.get(randomNumber)

- List.remove(randomNumber)

loop and restart at step 2 until List.size() returns 0.

import java.util.*;

class alphaRandom {

	public static void main(String[] args) {

	ArrayList&lt;Character&gt; al = new ArrayList&lt;Character&gt;();
	Random gen = new Random();
	int num;

	for(int i = 65; i &lt;= 90; i++) {
		al.add((char)i);
	}

	while(al.size() &gt; 0) {
		num = gen.nextInt(al.size());
		System.out.print(al.get(num));
		al.remove(num);
	}
 }
}

If you want to same some programming time, al.remove(num) will also return the object it's removing - so System.out.print(al.remove(num)) should work.

  • 0
  -Noah- said:
Teej: I added a semicolon after the while statement. No errors, but here are some examples of the output:

Output 1. W, C, U, H, E, D, F, Q, A, ., T, K, ., ., J, ., X, ., L, ., R, ., O, ., ., .,

Output 2. V, ., P, ., H, K, Q, ., D, S, ., ., G, J, R, F, N, ., M, B, ., Y, ., ., W, U,

Output 3. X, O, W, I, P, ., U, G, Q, R, F, ., ., V, A, B, ., ., K, ., Y, H, ., E, T, M,

I cant figure out what is wrong, most likely because I don't exactly know what is going on with the do while. Does the while statement at the end tell the program to go through the do again under the specified conditions? If you have any more ideas for fixing this, they are welcome!

About the int within the for-loop, my teacher says that it wastes memory and that you should define those variables first, out of the for-loop (?). I'm guessing she's wrong. :laugh:

Haha, I am a complete prat. I've made a couple of changes. Basically, the do-while loop was running the code within the loop while the random number isn't zero, meaning, if the position was being used, then it would generate a random letter until it wasn't being used, hence why you get the odd gaps. This new code does the opposite of this (runs the code within the loop until we get a random letter which isn't being used). I also changed all of the numbers to -1 because we would run into an infinite loop as position 0 would never be allowed.

There are three arrays: the alphabet array, the number array and the substitute alphabet array.

The number array is filled with -1s at the beginning, but as the for loop progresses, the number array gets filled up with numbers between 0-25.

Each time the code goes through the loop, it checks to see if that position in the array isn't -1 (i.e. isn't used), and if it isn't -1, then fill that position in the array with the random number, and then take whatever letter is in that position in the alphabet array, and apply it to the next space in the substitute alphabet array.

If the position in the number array ISN'T -1, then we generate a random number and the do-while loop returns to the beginning and we do the process again.

The do-while keeps doing this until we find a number which isn't -1, at which point, the for loop increments i and we start at the beginning of the code within the for-loop.

import java.util.Random;

public class encrypt {
  public static void main(String[] args) {
	char [] alphabet =  {'A','B','C','D','E','F','G','H','I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z'};
	char [] substitute = {'.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.','.'};  //this should be 26 dots, please check
	int [] numbers = {-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1};  //this should be 26 -1s, please check to see if this correct!!

	for (int i=0; i&lt;=25; i++) {
	  random = generator.nextInt(25);
	  //keep running this do-while until we find a number we haven't used before
	  do {
		//if we find a number we haven't used before
		if (numbers[random] == -1) { 
		  numbers[random] = random; //then assign that position in the array that number (i.e. position 10 in the array will now have the number 10), so it's considered to be used
		  substitute[i] = alphabet[random];  //assign the current position of the substitute alphabet array the random letter from the real alphabet
		}
		else {
		  random = generator.nextInt(25); //if we hit a number we've already used, get another one
		}
	  } while (numbers[random] == -1);
	}
	for(int i=0; i&lt;=25; i++) {
	  System.out.print(substitute[i] + ", "); //print out your brand new randomised alphabet!
	}
  }
}

Also, as for what your teacher says, what the hell? Forgive me if I'm wrong, but I'm really certain Java's automatic trashing would destroy the integer as soon as we get outside of the for loop, as opposed to at program termination, meaning it's more efficient to do it that way in this particular instance. Unless you need to use that specific integer value for another task outside of the for loop, declaring it outside of there is pointless.

Regardless of whether it trashes it or not after the for loop, though, it just makes the code neater to actually create the integer for a for-loop in the for-loop, instead of at the beginning, when it may not be needed at all. This is especially true if you have a for-loop within an if-else (as the for-loop may never be executed, meaning you've just wasted memory on declaring an integer which won't be used), or if you're using for-loops in object oriented code, which may not be called very often. Also, if you're using quite a few for loops, you don't want to have to do something like:

int i = 0;	//this integer is for a for loop that does this
int j = 0;		 //this integer is for a for-loop that does that
...
int l = 0;	//this integer is for yet another for-loop that does this thing somewhere in the code, I forget where it is now

Edited by The Teej
  • 0

int variables are primitive types, not Objects and are not created on the heap or garbage collected. They are allocated on the stack when coming into scope and thus released then they go out of scope. Teacher is talking rubbish - an int occupies the same space on the stack wherever it is defined, it just occupies that space for less time when its scope is smaller. And is anyone seriously worrying about 4 bytes of memory in 2009?

  • 0

Obviously the teacher is thinking about :

for (blabla) {
	Object o = new Object();
}

vs

Object o = new Object();
for (blabla) {
}

Here the latter is more efficient since Object() is allocated and constructed only once. If you can move any initialization out of a loop, it's always more efficient to do so. However, doing :

Object o;
for (blabla) {
	o = new Object();
}

is no performance improvement as the object still needs reallocation and construction each time through the loop. The reference o itself is statically allocated, i.e. it's merely a stack pointer increment at the beginning of the method and a decrement at the end, it makes no difference where you declare it in the method.

As for primitive types like int, there is no allocation and no construction involved, so from a performance standpoint it doesn't matter where they are declared within a method. Actually one should try to reduce the scope of variables as much as possible, so here declaring it inside the loop is what makes the most sense since that's the only place where it's supposed to be accessible.

In C++ the question might be different (and I'm unsure about the details), but here we're talking about Java not C++.

Show this to your teacher. :p

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Half a trillion? Do your homework, they're worth more than 3 freaking trillion dollars. As for the correlation between market cap and features, I think you're mistaken. There are some things called priorities. It obviously wasn't a priority for them to implement this, as it's still not a priority to implement moving taskbar to different locations of the screen. The trillions of dollars they're worth, have nothing to do with this.
    • Ara: History Untold 1.4 update delivers overhauls to AI, map generation, combat, and more by Pulasthi Ariyasinghe The 2024-released 4X strategy experience Ara: History Untold has been steadily receiving a massive amount of features and tweaks during its post-launch support period. Now, Stardock Entertainment and Oxide Games have another fresh update for PC gamers to jump into, and it's targeting some major aspects like the game's combat, AI, the camera perspective, and more. Dubbed the Living Strategy Update, the development team says that its features are a direct result of community feedback. First off, the update brings along the Living Strategy View as the default perspective for gameplay, letting players both get immersed in the environments and also easily manage their cities and armies. Next, the AI of computer opponents has been improved so that they make more meaningful decisions, with better late-game choices being a focus for the developer. Ara: History Untold's map generation has also been overhauled, with much more strategically distinct regions spawning across the playable areas for better strategic thinking. The amount of micromanagement has also been reduced by default, but this can be disabled to gain back full control if required. Players will also find that frame rates will remain high even in late-game scenarios thanks to graphics engine optimizations. Faster turn times, better UI responsiveness, and plenty of balance changes are also a part of the update. "It has been a real pleasure working with our colleagues at Microsoft for this update. The teams at Stardock, Oxide, and Microsoft have so much energy going into these updates. Version 1.4 is just a taste of what we have in store," said Brad Wardell, Chief Executive Officer for Stardock and Oxide. "In an industry where true 1.0 products are rare, especially ones in established genres, this has been a wonderful opportunity to try out new ideas and concepts that we in the strategy community have been thinking about for decades." Ara: History Untold update 1.4, Living Strategy, is now available to PC players across Steam and Xbox stores, including PC Game Pass subscribers. Alongside the update, the Untold Scenarios DLC pack has also arrived. This premium add-on touts fresh historical scenarios like Bronze Age Collapse, the Clash of Hemispheres, and Europe at the Crossroads for players to dive into. A separate selection of "what-if" scenarios are also included here, letting players explore alternate histories and see what they can accomplish. The Ara: History Untold: Untold Scenarios DLC pack is also available now on PC across Steam and Xbox stores with a $9.99 price tag. Disclaimer: Neowin's relationship to Stardock
    • Copilot in Excel just got a major upgrade by Usama Jawad It's no secret that Microsoft is trying to get as many people to use Copilot as possible. This is being done through various means, including integration with OneNote, Defender, Windows, and more. Microsoft Excel is the most popular spreadsheet software out there, so it makes sense that the Redmond tech firm would integrate and build upon the capabilities of Copilot in this tool too. Now, the company has implemented a major upgrade in this integration. In a blog post, Microsoft has made Copilot smarter in terms of context awareness in Excel. This makes the AI assistant more useful when asking questions about your data in nautral language queries. Previously, Copilot would only make inferences based on the cell that you have selected, and it typically worked quite well in this scenario. However, Microsoft has realized that workbooks and sheets have become more complex, which means that Copilot needs to be smarter too. This means that you no longer need to select relevant data when asking queries about it, you can simply ask questions such as "Show me insights about the data I was just analyzing" and "Sort the table in the top-right", and Copilot should just work. Microsoft says that this major upgrade in Copilot is due to combining cell signals with chat history in order to make inferences. It also supports data ranges, which means that it can serve as the foundation for even broader context in future updates. In order to get customers to trust the inferences that Copilot is making, Microsoft will highlight the data that the AI assistant is using. This enables customers to further refine the dataset that Copilot is using so that they can get the most accurate responses. Smart context awareness is available on the web and the following versions of desktop: Windows: Version 2505 (Build 18623.20058) Mac: Version 16.95 (Build 2506.3090) Meanwhile, the visual highlighting feature is also available on the web and the desktop versions mentioned below: Windows: Version 2505 (Build 18705.20000) Mac: Version 16.96 (Build 2506.4070) Microsoft has requested customers to provide feedback through the thumbs up/down icons present at the bottom of the Copilot response cards.
    • We should probably just focus on how nice it is that finally another company is taking reusable rockets seriously. I can't believe there are so few players and many rockets in service today are still completely expendable. Hopefully Honda can scale up theirs and add some badly needed competition. I want to see planes become irrelevant for global travel and we use rockets instead.
    • Yea. It's obviously being deprecated, in case no one noticed or forgot all the announcements and changes. Not such a big deal.
  • Recent Achievements

    • Week One Done
      slackerzz earned a badge
      Week One Done
    • Week One Done
      vivetool earned a badge
      Week One Done
    • Reacting Well
      pnajbar earned a badge
      Reacting Well
    • Week One Done
      TBithoney earned a badge
      Week One Done
    • First Post
      xuxlix earned a badge
      First Post
  • Popular Contributors

    1. 1
      +primortal
      687
    2. 2
      ATLien_0
      284
    3. 3
      Michael Scrip
      225
    4. 4
      +FloatingFatMan
      197
    5. 5
      Steven P.
      135
  • Tell a friend

    Love Neowin? Tell a friend!