• 0

[C] Testing whether integer is 'Prime' or 'Not Prime'


Question

Basically I've this homework assignment for my beginner C class, I managed to compile the program but am unable to clear the auto-marker (coursemarker)

Any one got some clues as to why?

The program is required to read a user input integer and calculate whether the integer is prime or not prime and output the respective lines as in the code below. An entry of 0 will result in the program exiting.

otXYN.png

Pardon the noob // comments :p

12 answers to this question

Recommended Posts

  • 0

Can you explain the problem better? Are you just talking about the gray box at the end of the code? And when you post code, post the text instead of an image. Or upload the main.c file and I'll remove it with a text or hex-editor.

And a couple comments on the code. You calculate the square-root of "num" with each iteration of the loop; just do it once and store it in a variable. I'm not sure if the compiler optimizes that out or not. Second, all even numbers greater than 2 are not prime; that could help.

  • 0

The algorithm is fine, but this will get you fired:

while (start<(sqrt(num))

sqrt is an expensive calculation, so you don't want to re-compute it each time through the loop. Compute it once, store it in a local variable and use that for the loop condition.

There are plenty of ways to check for primality. For small primes, the fastest way would be to store all known primes in a sorted array and search (using a binary search) for the input number in that array. You could improve your existing algorithm by testing only for odd numbers, since no even number greater than 2 is prime. More advanced methods (efficient for large primes) are based on probabilities. Check out http://en.wikipedia.org/wiki/Primality_test

  • 0

The best way depends on the greatest number that might be tested in a program; it also depends on your tolerance for a false-positive. The Miller-Rabin test is popular; make sure to read the section about making it deterministic. Since the maximum value that may be tested by your program is INT_MAX, you could easily optimize it using the parameters in the Wikipedia article.

  • 0

Oops, I figured out what my error was, the program was looking for continuous user entry till '0' is keyed in. I put a while loop in the main function and ta-da!

Thanks for the help guys, I'm still in the process of refining my code to check for primes.

  • 0
  On 08/03/2010 at 07:25, evo0o said:

I'm still in the process of refining my code to check for primes.

Other than taking the sqrt() function out of the while loop, you really don't need to change anything. Since you're limiting yourself to 32-bit signed integers, the slowest-case scenario for your test is running the while() loop about 46000 times. That will happen quickly on any CPU.
  • 0

Most people don't realize that: (Prime number > 3) % 6 = 1 or 5 always. (% is the operator which gives you the remainder of the division.)

5 % 6 = 5

7 % 6 = 1

11 % 6 = 5

13 % 6 = 1

17 % 6 = 5

... and so on.

The above calculation can be used as a precondition for testing whether a number is prime, because it helps avoid the use of expensive calculations for testing each and every number for primality with the expensive while loop.

You should also consider hard-coding your program for numbers<=3 because 2 and 3 are prime and 0 and 1 are non-prime.

  • 0
  On 09/03/2010 at 01:18, BGM said:

wtf... wouldn't wanna work where you work! :o

It's a minor difference in code but as mentioned about having it that would means that sqrt() is evaluated each time the condition is check when it only needs to be done once. If we're talking about large prime numbers that would mean a lot of extra computation time wasted.

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Apple prices for sure suck, but performance, upgradability and flexibility are subjective to the use case and machine. For example, you will not find a mini PC in the same starting price range that has the same performance as a Mac Mini, nor will it be very upgradable, if at all at that size. Many cost-effective laptops are not upgradable past the storage. Inexpensive laptops are underperforming in comparison to more expensive models that might actually cost more than a MacBook . You won’t find battery life is comparable unless you go with Snapdragon, which limits compatibility and sacrifices upgradability. AIOs suck in both spaces, so I’ll not mention them. As for flexibility, I can do more in my use cases with a Mac than I can with a Windows or Linux machine. Where Apple really screws their users over is with upgrades, especially since you have to do them during purchase. Outside of cost, it’s all subjective.
    • Not with Proton, no. macOS isn’t Linux in any way, shape, or form.
    • AIDA64 was just showing the variable speed. Open Task Manager and go on the CPU tab and see the magic of your CPU speed going up and down as the PC does things in the background. C States Auto/Disabled actually forces all cores on (disabling the ability to park unneeded 3D Cache cores when they aren't needed), but does not have any effect on the CPU speed. I think setting the Power Plan in Windows to High Performance does boost the CPU clock higher, which also results in less energy efficiency with "everything turned up to 11" all the time when it isn't even needed. Older generation CPUs did not have the variable speeds we now have in modern CPUs, they operated on a fixed clock speed.
    • one drive saved my life .ive freed up some space i now have 227gigs.
    • "What the f is that name of that program?! Good thing I can find it in the easily accessible, and alphabetized list of apps." 🙂 I don't use the Start Menu a lot, but I'd be super annoyed if there wasn't some form of an app drawer in Windows.
  • Recent Achievements

    • One Month Later
      SekTheFirst earned a badge
      One Month Later
    • First Post
      zayanhani earned a badge
      First Post
    • First Post
      HarryTaylor earned a badge
      First Post
    • One Year In
      Eternal Tech earned a badge
      One Year In
    • One Month Later
      Eternal Tech earned a badge
      One Month Later
  • Popular Contributors

    1. 1
      +primortal
      654
    2. 2
      ATLien_0
      237
    3. 3
      Michael Scrip
      231
    4. 4
      Steven P.
      142
    5. 5
      +FloatingFatMan
      135
  • Tell a friend

    Love Neowin? Tell a friend!