• 0

Code not working


Question

So there are 2 classes ,and i'm using windows application form, the for has 2 buttons and code for them are as follows :-

 

Class MyBaseClass

 class MyBaseClass
    {
        public MyBaseClass(string baseClassNeedsThis)
        {
            MessageBox.Show("thishe base class:" + baseClassNeedsThis);
        }
    }

Class MySubClass

 class MySubclass : MyBaseClass
    {
        public MySubclass (string baseClassNeedsThis, int anotherValue)
            :base(baseClassNeedsThis)
        {
            MessageBox.Show("Thishe subclass: " + baseClassNeedsThis + "and" + anotherValue);
        }
    }

And Form1.cs

 

public partial class Form1 : Form
    {
        MyBaseClass myBaseClass;
        MySubclass mySubClass;
        public Form1()
        {
            InitializeComponent();
            
        }

        private void button1_Click(object sender, EventArgs e)
        {
            myBaseClass = new MyBaseClass.MyBaseclass(string baseClassNeedsThis);

        }

        private void button2_Click(object sender, EventArgs e)
        {
            mySubClass = new MySubclass.MySubclass(string baseClassNeedsThis , int anotherValue);
        }
    }

The output expected is up on clicking button1 MyBaseClass  messsge should pop up and on clicking button2 both MyBaseClass  and MySubClass messages should be displayed, i'm getting a lot of errors 

What are the corrections to be made in Form1.cs ?

Link to comment
https://www.neowin.net/forum/topic/1321238-code-not-working/
Share on other sites

4 answers to this question

Recommended Posts

  • 0

Try changing the code on your button click events to the code below. 

 

 

private void button1_Click(object sender, EventArgs e)
{
    myBaseClass = new MyBaseClass("Test");
}

private void button2_Click(object sender, EventArgs e)
{
 mySubClass = new MySubclass("Test2", 3);
}

 

  • 0
  On 03/02/2017 at 07:44, Ch33f said:

The output expected is up on clicking button1 MyBaseClass  messsge should pop up and on clicking button2 both MyBaseClass  and MySubClass messages should be displayed, i'm getting a lot of errors

Expand  

If you have compilation errors please post them it makes it much easier to spot the problem.

 

Here the following is not valid C#:

new MyBaseClass.MyBaseclass(string baseClassNeedsThis);

You're confusing method definition and invocation. When you invoke a method (or here, a constructor, same thing), you need to provide it with the parameters it needs, not try to declare new ones. What would you have expected it to print anyway?

 

So as Zag L. mentions, pass a real string, like a string literal (i.e. "Test") or a variable or field of type string.

 

To give an example, you're probably familiar with the "Hello World" program:

Console.WriteLine("Hello World");

This is an invocation of the method Console.WriteLine, which definition looks something like

public static void WriteLine(string line)
{
  ...
}

Here the parameter line will be "Hello World" as this is value passed in. Trying to invoke the method like this is meaningless:

Console.WriteLine(string line); // not valid C#

However this is:

string line = "Hello World!";
Console.WriteLine(line);

Hopefully that clears things up.

  • 0
  On 03/02/2017 at 14:55, Zag L. said:

Try changing the code on your button click events to the code below. 

 

 

private void button1_Click(object sender, EventArgs e)
{
    myBaseClass = new MyBaseClass("Test");
}

private void button2_Click(object sender, EventArgs e)
{
 mySubClass = new MySubclass("Test2", 3);
}

 

Expand  

Oh cool now i get it, thank you for the help

  • 0
  On 03/02/2017 at 07:44, Ch33f said:

So there are 2 classes ,and i'm using windows application form, the for has 2 buttons and code for them are as follows :-

 

Class MyBaseClass

 class MyBaseClass
    {
        public MyBaseClass(string baseClassNeedsThis)
        {
            MessageBox.Show("thishe base class:" + baseClassNeedsThis);
        }
    }

Class MySubClass

 class MySubclass : MyBaseClass
    {
        public MySubclass (string baseClassNeedsThis, int anotherValue)
            :base(baseClassNeedsThis)
        {
            MessageBox.Show("Thishe subclass: " + baseClassNeedsThis + "and" + anotherValue);
        }
    }

And Form1.cs

 

public partial class Form1 : Form
    {
        MyBaseClass myBaseClass;
        MySubclass mySubClass;
        public Form1()
        {
            InitializeComponent();
            
        }

        private void button1_Click(object sender, EventArgs e)
        {
            myBaseClass = new MyBaseClass.MyBaseclass(string baseClassNeedsThis);

        }

        private void button2_Click(object sender, EventArgs e)
        {
            mySubClass = new MySubclass.MySubclass(string baseClassNeedsThis , int anotherValue);
        }
    }

The output expected is up on clicking button1 MyBaseClass  messsge should pop up and on clicking button2 both MyBaseClass  and MySubClass messages should be displayed, i'm getting a lot of errors 

What are the corrections to be made in Form1.cs ?

Expand  

 

you are combining things which should be done on separate lines:

Declare first, then use.

 

        private void button1_Click(object sender, EventArgs e)
        {
		string baseClassNeedsThis = "Test";
		myBaseClass = new MyBaseClass.MyBaseclass(baseClassNeedsThis);
        }

        private void button2_Click(object sender, EventArgs e)
        {
		string baseClassNeedsThis = "Test";
		int anotherValue = 25;
		myBaseClass = new MySubclass.MySubclass(baseClassNeedsThis, anotherValue);
        }

 

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Is this for Black people only? You'd definitely think so from the ad.
    • I have it as an icon in the Start Menu. Close enough for when I need it.
    • Windows 11 Pro with a copy of Office 2021 Pro drops to all-time low price by Steven Parker Today's highlighted deal comes via our Apps + Software section of the Neowin Deals store, where you can save 86% on Windows 11 Pro (for 2 devices) + Microsoft Office Pro 2021. Upgrade your computing experience with Windows 11 Pro. This cutting-edge operating system boasts a sleek new design and advanced tools to help you work faster and smarter. From creative projects to gaming and beyond, Windows 11 delivers the power and flexibility you need to achieve your goals. With a focus on productivity, the new features are easy to learn and use, enhancing your workflow and efficiency. Whether you're a student, professional, gamer, or creative, Windows 11 Home has everything you need to take your productivity to the next level. New interface. easier on the eyes & easier to use Biometrics login*.Encrypted authentication & advanced antivirus defenses DirectX 12 Ultimate. Play the latest games with graphics that rival reality. DirectX 12 Ultimate comes ready to maximize your hardware* Screen space. Snap layouts, desktops & seamless redocking Widgets. Stay up-to-date with the content you love & the new you care about Microsoft Teams. Stay in touch with friends and family with Microsoft Teams, which can be seamlessly integrated into your taskbar** Wake & lock. Automatically wake up when you approach and lock when you leave Smart App Control. Provides a layer of security by only permitting apps with good reputations to be installed Windows Studio Effects. Designed with Background Blur, Eye Contact, Voice Focus, & Automatic Framing Touchscreen. For a true mouse-less or keyboard-less experience TPM 2.0. Helps prevent unwanted tampering Windows 11 Pro also includes a number of productivity-focused features, such as the ability to snap multiple windows together and create custom layouts, improved voice typing, and a new, more powerful search experience. Personal and professional users will enjoy a modern and secure computing experience, with improved performance and productivity features to help users get more done. Only on Windows 11 Pro If you require enterprise-oriented features for your daily professional tasks, then Windows 11 Pro is a better option. Set up with a local account (only when set up for work or school) Join Active Directory/Azure AD Hyper-V Windows Sandbox Microsoft Remote Desktop BitLocker device encryption Windows Information Protection Mobile device management (MDM) Group Policy Enterprise State Roaming with Azure Assigned Access Dynamic Provisioning Windows Update for Business Kiosk mode Maximum RAM: 2TB Maximum no. of CPUs: 2 Maximum no. of CPU cores: 128 Good to know: Length of access: lifetime Redemption deadline: redeem your code within 30 days of purchase Access options: desktop Max number of device(s): 2 (Use one activation key for up to 2 devices) Version: Windows 11 Pro Updates included Click here to verify Microsoft partnership For Windows 10 or Newer! Get All Essential Microsoft Apps for Your PC with This One-Time Purchase This is intended for families and small businesses who want classic Office apps and email. It includes Word, Excel, PowerPoint, Outlook, Teams, and OneNote. A one-time purchase installed on 1 Windows PC for use at home or work. Lifetime license for MS Word, Excel, PowerPoint, Outlook, Teams, & OneNote One-time purchase installed on 1 Windows PC for use at home or work Instant Delivery & Download – access your software license keys and download links instantly Free customer service – only the best support! Microsoft Office Professional 2021 (for Windows) includes: Microsoft Office Word Microsoft Office Excel Microsoft Office PowerPoint Microsoft Office Outlook Microsoft Office Teams Microsoft Office OneNote Microsoft Office Publisher Microsoft Office Access Good to know: ONE-TIME PURCHASE INSTALLED ON 1 DEVICE Redemption deadline: redeem your code within 30 days of purchase Access options: desktop Full versions No subscriptions – no monthly/annual fees Version: 2021 Updates included Here's the deal: This Microsoft Office Pro 2021 + Windows 11 Pro normally costs $438, but this deal can be yours from just $54.97, that's a saving of $383. For full terms, specifications, and license info please click the link below. Use MSO5 when checking out for additional $5 off. Coupon Expires June 29. Get Microsoft Office Pro 2021 + Windows 11 Pro for just $49.97, or learn more Although priced in U.S. dollars, this deal is available for digital purchase worldwide. We post these because we earn commission on each sale so as not to rely solely on advertising, which many of our readers block. It all helps toward paying staff reporters, servers and hosting costs. Other ways to support Neowin Whitelist Neowin by not blocking our ads Create a free member account to see fewer ads Make a donation to support our day to day running costs Subscribe to Neowin - for $14 a year, or $28 a year for an ad-free experience Disclosure: Neowin benefits from revenue of each sale made through our branded deals site powered by StackCommerce.
    • I'm not a fan of the HP "Smart" app either, but it does work. I just wish I didn't have to log in to use it. HP Color LaserJet Pro MFP 4301
    • FocusOn Image Viewer 1.32 by Razvan Serea FocusOn Image Viewer is a fast, lightweight, and user-friendly photo viewer for Windows. It supports various image formats, offers basic editing tools, EXIF data display, and batch renaming. With a clean interface, slideshow mode, and easy navigation, it’s ideal for quickly viewing and organizing photos without unnecessary complexity or system resource usage. FocusOn Image Viewer key features: Auto Organize: Automatically sorts photos by date using your chosen template. Explorer View: Browse and manage images with thumbnails; includes basic edits like resize and rotate. Photo Editing: Crop, apply filters, correct colors, add borders or text. Non-Destructive Edits: Original images remain untouched. Photo Sharing: Post directly to blogs, Twitter, and Facebook. Email Support: Send selected images via email. Print Options: Print to fit paper size, preserve aspect ratio, or fit multiple images per page. Slideshow: View selected photos in a slideshow. EXIF Tools: View or remove EXIF data. Scanning: Import from TWAIN or WIA-compatible scanners. Set as Background: Quickly set any image as desktop wallpaper. Batch Rename: Rename images in bulk using templates. Resize Images: Resize with optimized or custom resampling methods, including multi-step resizing. Thumbnail Sizes: Choose from thumbnail sizes between 32–256 pixels. Format Support: Compatible with over 100 image formats. FocusOn Image Viewer 1.32 changelog: Added Ghostscript(AI, PDF) DPI option Fixed transparency issue when saving PDF document as image Other improvements and bug fixes Download: FocusOn Image Viewer 64-bit | Portable 64-bit | ~7.0 MB (Freeware) Download: FocusOn Image Viewer 32-bit | Portable 32-bit View: FocusOn Image Viewer Website | Screenshot Get alerted to all of our Software updates on Twitter at @NeowinSoftware
  • Recent Achievements

    • First Post
      Johnny Mrkvička earned a badge
      First Post
    • Week One Done
      viraltui earned a badge
      Week One Done
    • One Month Later
      serfegyed earned a badge
      One Month Later
    • Dedicated
      firey earned a badge
      Dedicated
    • Dedicated
      fettermanj earned a badge
      Dedicated
  • Popular Contributors

    1. 1
      +primortal
      658
    2. 2
      ATLien_0
      224
    3. 3
      Michael Scrip
      224
    4. 4
      Xenon
      146
    5. 5
      +FloatingFatMan
      144
  • Tell a friend

    Love Neowin? Tell a friend!