• 0

An error occurring during compiling


Question

i'm building an Hide and seek game using csharp here is the code, it has 2 interfaces , 2 independent classes, 6 other classes which inherit from the interface and the other 2 classes, the code has zero errors and runs when pressed start. But some times during execution the code starts running and give me this error it pints to the line currentLocation.Exits.Name

 

So hears the cod for the entire program

  interface IHasExteriorDoor
    {
        string DoorDescription { get; }
        Location DoorLocation { get; set; }
    }
 interface IHidingPlace
    {
        string HidingPlaceName { get; }
    }
abstract class Location
    {
        public Location(string name)
        {
            this.name = name;
        }
        public Location[] Exits;
        private string name;
        public string Name
        {
            get { return name; }
        }
        public virtual string Description
        {
            get
            {
                string description = " You're standing in the " + name + ". You see exits to the following places:";

                for (int i = 0; i < Exits.Length; i++)
                {
                    description += "" + Exits[i].Name;
                    if (i != Exits.Length - 1)
                        description += ",";
                }
                description += ".";
                return description;
            }
        }
    }
class Opponent
    {
        private Random random;
        private Location myLocation;
        public Opponent(Location startingLocation)
        {
            myLocation = startingLocation;
            random = new Random();
        }
        public void Move()
        {
            if (myLocation is IHasExteriorDoor)
            {
                IHasExteriorDoor LocationWithDoor = myLocation as IHasExteriorDoor;
            
            if (random.Next(2) == 1)
                myLocation = LocationWithDoor.DoorLocation;
        }
        bool hidden = false;
        while(!hidden)
            {
            int rand = random.Next(myLocation.Exits.Length);
            myLocation = myLocation.Exits[rand];
            if(myLocation is IHidingPlace)
            hidden = true;
            }
        }
        public bool Check(Location locationToCheck)
        {
            if (locationToCheck != myLocation)
                return false;
            else
                return true;
        } 
    }
 class OutsideWithDoor : Outside, IHasExteriorDoor
    {
        public OutsideWithDoor(string name, bool hot, string doorDescription): base(name, hot)
            {
            this.doorDescription = doorDescription;
            }
        private string doorDescription;
        public string DoorDescription
        {
            get { return doorDescription; }
        }
        private Location doorLocation;
        public Location DoorLocation
        {
            get { return doorLocation; }
            set { doorLocation = value; }
        }
        public override string Description
        {
            get
            {
                return base.Description + "You see " + doorDescription + ".";
            }
        }
    }
 class Outside : Location
    {
        private bool hot;
        public bool Hot { get { return hot; } }

        public Outside(string name, bool hot) : base(name)
        {
            this.hot = hot;
        }
        public override string Description
        {
            get
            {
                string NewDescription = base.Description;
                if (hot)
                    NewDescription += "It's very hot.";
                return NewDescription;
            }
        }
    }
 class OutsideWithHidingPlace : Outside, IHidingPlace
    {
        public OutsideWithHidingPlace(string name, bool hot, string hidingPlaceName) : base(name, hot)
        { this.hidingPlaceName = hidingPlaceName; }

        private string hidingPlaceName;
        public string HidingPlaceName
        {
            get { return hidingPlaceName; }
        }
        public override string Description
        {
            get { return base.Description + "Someone could hide" + hidingPlaceName + "."; }
        }
    }
class RoomwithDoor: RoomWithHidingPlace, IHasExteriorDoor
    {
        public RoomwithDoor(string name, string decoration, string hidingPlaceName, string doorDescription):base(name, decoration, hidingPlaceName)
        { this.doorDescription = doorDescription; }
        private string doorDescription;
        public string DoorDescription
        {
            get { return doorDescription; }
        }
        private Location doorLocation;
        public Location DoorLocation
        {
            get { return doorLocation; }
            set { doorLocation = value; }
        }
    }
class Room: Location
    {
        private string decoration;

        public Room(string name, string decoration):base(name)
        {
            this.decoration = decoration;
        }
        public override string Description
        {
            get
            {
                return base.Description+"You see " + decoration + ".";
            }
        }
    }
 class RoomWithHidingPlace : Room, IHidingPlace
    {
        public RoomWithHidingPlace (string name, string decoration, string hidingPlaceName): base(name, decoration)
        {
            this.hidingPlaceName = hidingPlaceName;
        }
        private string hidingPlaceName;
        public string HidingPlaceName
        {
            get { return hidingPlaceName; }
        }
        public override string Description
        {
         get { return base.Description + "Someone could hide" + hidingPlaceName + "."; }
        }
    }
public partial class Form1 : Form
    {
        int Moves;
        Location currentLocation;

        RoomwithDoor livingRoom;
        RoomWithHidingPlace diningRoom;
        RoomwithDoor kitchen;
        Room stairs;
        RoomWithHidingPlace hallway;
        RoomWithHidingPlace bathroom;
        RoomWithHidingPlace masterBedroom;
        RoomWithHidingPlace secondBedroom;

        OutsideWithDoor frontYard;
        OutsideWithDoor backYard;
        OutsideWithHidingPlace garden;
        OutsideWithHidingPlace driveway;

        Opponent opponent;

        public Form1()
        {
            InitializeComponent();
            CreateObjects();
            opponent = new Opponent(frontYard);
            ResetGame(false);
            MoveToANewLocation(livingRoom);
        }
        private void MoveToANewLocation(Location newLocation)
        {
            Moves++;
            currentLocation = newLocation;
            RedrawForm();
        }
        private void RedrawForm()
        {
            exits.Items.Clear();
            for (int i = 0; i < currentLocation.Exits.Length; i++)
                exits.Items.Add(currentLocation.Exits[i].Name);
            exits.SelectedIndex = 0;
            description.Text = currentLocation.Description + "\r\n(move #" + Moves + ")";
            if(currentLocation is IHidingPlace)
            {
                IHidingPlace hidingPlace = currentLocation as IHidingPlace;
                exits.Text = "Check" + hidingPlace.HidingPlaceName;
                exits.Visible = true;
            }
            else
                exits.Visible = false;
                if (currentLocation is IHasExteriorDoor)
                    goThroughTheDoor.Visible = true;
                else
                    goThroughTheDoor.Visible = false;
        }
        private void CreateObjects()
        {
            livingRoom = new RoomwithDoor("Living Room", "an antique carpet","inside the closet", "an oak door with a brassknob");
            diningRoom = new RoomWithHidingPlace("Dining Room", "a crystal chandelier", "in the tall armorie");
            kitchen = new RoomwithDoor("Kitchen", "stainless steel appliances","in the cabinet", "a screen door");
            stairs = new RoomwithDoor("Kitchen", "stainless steel appliances", "in teh cabinet", "a screen door");
            hallway = new RoomWithHidingPlace("Upstairs Hallway", "a picture of a dog", "in the closet");
            bathroom = new RoomWithHidingPlace("Bathjroom", "a sink and a toilet", "in the shower");
            masterBedroom = new RoomWithHidingPlace("Master Bedroom", "a large bed", "under the bed");
            secondBedroom = new RoomWithHidingPlace("Second Bedroom", "a small bed", " under the bed");

            frontYard =new OutsideWithDoor("Front Yard", false, "a heavy-looking oak door ");
            backYard = new OutsideWithDoor("Back Yard", true, " a screen door");
            garden = new OutsideWithHidingPlace("Garden", false,"inside the shed");
            driveway = new OutsideWithHidingPlace("Driveway", true, "in the garage");

            diningRoom.Exits = new Location[] { livingRoom, kitchen };
            livingRoom.Exits = new Location[] { diningRoom, stairs };
            kitchen.Exits = new Location[] { diningRoom };
            stairs.Exits = new Location[] { livingRoom, hallway };
            hallway.Exits = new Location[] { stairs, bathroom, masterBedroom, secondBedroom };
            bathroom.Exits = new Location[] { hallway };
            masterBedroom.Exits = new Location[] { hallway };
            secondBedroom.Exits = new Location[] { hallway };
            frontYard.Exits = new Location[] { backYard, garden, driveway };
            backYard.Exits = new Location[] { frontYard, garden, driveway };
            garden.Exits = new Location[] { backYard, frontYard };
            driveway.Exits = new Location[] { backYard, frontYard };

            livingRoom.DoorLocation = frontYard;
            frontYard.DoorLocation = livingRoom;

            kitchen.DoorLocation = backYard;
            backYard.DoorLocation = kitchen;
        }
         private void ResetGame (bool displayMessage)
        {
            if (displayMessage)
            {
                MessageBox.Show("you found me in" + Moves + "moves!");
                IHidingPlace foundLocation = currentLocation as IHidingPlace;
                description.Text = "you found your opponent in " + Moves + "moves! He was hiding" + foundLocation.HidingPlaceName + ".";
            }
            Moves = 0;
            hide.Visible = true;
            goHere.Visible = false;
            check.Visible = false;
            goThroughTheDoor.Visible = false;
            exits.Visible = false;
        }

    

        private void goHere_Click(object sender, EventArgs e)
        {
            MoveToANewLocation(currentLocation.Exits[exits.SelectedIndex]);
        }

        private void goThroughTheDoor_Click(object sender, EventArgs e)
        {
            IHasExteriorDoor hasDoor = currentLocation as IHasExteriorDoor;
            MoveToANewLocation(hasDoor.DoorLocation);
        }

        private void check_Click(object sender, EventArgs e)
        {
            Moves++;
            if (opponent.Check(currentLocation))
                ResetGame(true);
            else
                RedrawForm();
        }

        private void Hide_Click(object sender, EventArgs e)
        {
            hide.Visible = false;
            for (int i = 1; i <= 10; i++)
            {
                opponent.Move();
                description.Text = i + "...";
                Application.DoEvents();
                System.Threading.Thread.Sleep(200);
            }
            description.Text = "Ready or not, here i come!";
            Application.DoEvents();
            System.Threading.Thread.Sleep(500);

            goHere.Visible = true;
            exits.Visible = true;
            MoveToANewLocation(livingRoom);
        }
    }

Although this program contains 0 errors the program stops compiling sometimes and points towards the line current.Exit.Name and give a pop up saying Null reference  exception was handled.

 

Here's how the form looks like FORM

Link to comment
https://www.neowin.net/forum/topic/1323070-an-error-occurring-during-compiling/
Share on other sites

7 answers to this question

Recommended Posts

  • 0
Location currentLocation = null;
// Or
Location currentLocation.Exits = null;

The error is caused because the value is null, this can be caused by either the whole currentLocation to be null or the Exits attribute to be null.

 

If I would have to guess:

 

You start at Location A which has exits B, C and D.

Then you go to exit Location C which has no exits, the attribute "exits" is null, this causes an error in the for loop which expects at least an empty array instead of null.

 

The NullReferenceException is the most common exception I've ever seen in a C# application :p

 

TL;DR

 

Always initialize your arrays/lists or check if they aren't null before using a loop.

 

Also this is not an compilation but an execution error, which means that the code will compile fine and can be distributed to the users which will see their application crash. Therefore it's always recommended to test all scenarios (0, 1 or multiple exits) for bugs before shipping the code.
 

This can be done manually or automated (recommended) with unit tests: https://www.youtube.com/watch?v=rW6LvPP4VvA

 

 

  • 0
  On 21/02/2017 at 12:51, Ch33f said:

Although this program contains 0 errors the program stops compiling sometimes and points towards the line current.Exit.Name and give a pop up saying Null reference  exception was handled.

Expand  

First, this is not a compile-time error! It does not happen while the program is compiling, it happens while the program is running, i.e. after compilation. If you have any confusion about compile- vs run-time you need to clear that up ASAP. The compiler turns your text files (*.cs) into executable files (*.dll, *.exe), which can then run inside an operating system process. Exceptions happen at run-time when your program is legal C# so it compiles, but it still manages to do something wrong (like in this case, dereferencing a null).

 

As @Seahorsepip mentions, if `currentLocation.Exits.Name` throws NullReferenceException then either currentLocation is null or currentLocation.Exits is null. Why are they null? What could you do to make them not null? That's yours to figure out.

 

 

  • Like 1
  • 0

After reading the code, it appears to me your problem is very simple...

 

abstract class Location
    {
        public Location(string name)
        {
            this.name = name;
        }
        public Location[] Exits;

you did not initialize Exits in the base constructor, nor did you initialize it in the inherited constructors as well.

Seems to me somewhere you should have this line somewhere in your constructors.

Exits = new Location[ExitCount];  //Where ExitCount is an integer

 

  • 0
  On 21/02/2017 at 18:19, Seahorsepip said:

The NullReferenceException is the most common exception I've ever seen in a C# application :p

Expand  

For me it's the "Object reference not set to an instance of an object" error (I've caused this in my apps forgetting to set it correctly), and the division by zero errors. I'm working on a C# GTA soundboard, and when I'm tired the object reference error happens a lot :) Caffeine normally helps :)

  • Like 1
  • 0
  On 21/02/2017 at 23:08, sao123 said:

After reading the code, it appears to me your problem is very simple...

Expand  

The exits are given a value in CreateObjects():

See Form1 constructor:

MoveToANewLocation(livingRoom);

Which sets currentLocation to livingRoom (which is generated by CreateObjects() and has the exits value diningRoom and stairs).

So exits don't need to be initialized in the Locations class itself to work but imagine what happens when the following method is called:

MoveToANewLocation(stairs);

And the stairs exits array attribute is not initialized in CreateObjects()?

 

Then it tries to for loop trough null instead of an array and we end up with a NullReferenceException :)

 

So initializing every array in the classes is a quick fix that does indeed solve the NullReferenceException issue in most cases but might not solve the underlying issue, maybe a Location should always have at least 1 exit as example.

 

As I said before it's saves a lot of work when unit tests are made for all use case scenarios(values, actions etc). Then it's directly clear when something stopped working that worked before.

 

  On 21/02/2017 at 23:33, Tidosho said:

For me it's the "Object reference not set to an instance of an object" error (I've caused this in my apps forgetting to set it correctly), and the division by zero errors. I'm working on a C# GTA soundboard, and when I'm tired the object reference error happens a lot :) Caffeine normally helps :)

Expand  

I always get StackOverflowExceptions since I have a habit to write a lot of recursion logic lately :p 

  • 0
  On 21/02/2017 at 23:33, Tidosho said:

For me it's the "Object reference not set to an instance of an object" error (I've caused this in my apps forgetting to set it correctly), and the division by zero errors. I'm working on a C# GTA soundboard, and when I'm tired the object reference error happens a lot :) Caffeine normally helps :)

Expand  

Try F# - no nulls (mostly) among other benefits ;)

  • 0

Thank You for the feedback, i got the program working, exits is the name given to the combo box and its has been initialized in Location class here is the edited version of form.

public partial class Form1 : Form
    {
        int Moves;
        Location currentLocation;

        RoomwithDoor livingRoom;
        RoomWithHidingPlace diningRoom;
        RoomwithDoor kitchen;
        Room stairs;
        RoomWithHidingPlace hallway;
        RoomWithHidingPlace bathroom;
        RoomWithHidingPlace masterBedroom;
        RoomWithHidingPlace secondBedroom;

        OutsideWithDoor frontYard;
        OutsideWithDoor backYard;
        OutsideWithHidingPlace garden;
        OutsideWithHidingPlace driveway;

        Opponent opponent;

        public Form1()
        {
            InitializeComponent();
            CreateObjects();
            opponent = new Opponent(frontYard);
            ResetGame(false);
            MoveToANewLocation(livingRoom);
        }
        private void MoveToANewLocation(Location newLocation)
        {
            Moves++;
            currentLocation = newLocation;
            RedrawForm();
            
        }
        private void RedrawForm()
        {
            exits.Items.Clear();
            for (int i = 0; i < currentLocation.Exits.Length; i++)
                exits.Items.Add(currentLocation.Exits[i].Name);
            exits.SelectedIndex = 0;
            description.Text = currentLocation.Description + "\r\n(move #" + Moves + ")";
            if(currentLocation is IHidingPlace)
            {
                IHidingPlace hidingPlace = currentLocation as IHidingPlace;
                check.Text = "Check" + hidingPlace.HidingPlaceName;
                check.Visible = true;
            }
            else
                check.Visible = false;
                if (currentLocation is IHasExteriorDoor)
                    goThroughTheDoor.Visible = true;
                else
                    goThroughTheDoor.Visible = false;
        }
        private void CreateObjects()
        {
            livingRoom = new RoomwithDoor("Living Room", "an antique carpet","inside the closet", "an oak door with a brassknob");
            diningRoom = new RoomWithHidingPlace("Dining Room", "a crystal chandelier", "in the tall armorie");
            kitchen = new RoomwithDoor("Kitchen", "stainless steel appliances","in the cabinet", "a screen door");
            stairs = new Room("Stairs", "a wooden bannister");
            hallway = new RoomWithHidingPlace("Upstairs Hallway", "a picture of a dog", "in the closet");
            bathroom = new RoomWithHidingPlace("Bathjroom", "a sink and a toilet", "in the shower");
            masterBedroom = new RoomWithHidingPlace("Master Bedroom", "a large bed", "under the bed");
            secondBedroom = new RoomWithHidingPlace("Second Bedroom", "a small bed", " under the bed");

            frontYard =new OutsideWithDoor("Front Yard", false, "a heavy-looking oak door ");
            backYard = new OutsideWithDoor("Back Yard", true, " a screen door");
            garden = new OutsideWithHidingPlace("Garden", false,"inside the shed");
            driveway = new OutsideWithHidingPlace("Driveway", true, "in the garage");

            diningRoom.Exits = new Location[] { livingRoom, kitchen };
            livingRoom.Exits = new Location[] { diningRoom, stairs };
            kitchen.Exits = new Location[] { diningRoom };
            stairs.Exits = new Location[] { livingRoom, hallway };
            hallway.Exits = new Location[] { stairs, bathroom, masterBedroom, secondBedroom };
            bathroom.Exits = new Location[] { hallway };
            masterBedroom.Exits = new Location[] { hallway };
            secondBedroom.Exits = new Location[] { hallway };
            frontYard.Exits = new Location[] { backYard, garden, driveway };
            backYard.Exits = new Location[] { frontYard, garden, driveway };
            garden.Exits = new Location[] { backYard, frontYard };
            driveway.Exits = new Location[] { backYard, frontYard };

            livingRoom.DoorLocation = frontYard;
            frontYard.DoorLocation = livingRoom;

            kitchen.DoorLocation = backYard;
            backYard.DoorLocation = kitchen;
        }
         private void ResetGame (bool displayMessage)
        {
            if (displayMessage)
            {
                MessageBox.Show("you found me in" + Moves + "moves!");
                IHidingPlace foundLocation = currentLocation as IHidingPlace;
                description.Text = "you found your opponent in " + Moves + "moves! He was hiding" + foundLocation.HidingPlaceName + ".";
            }
            Moves = 0;
            hide.Visible = true;
            goHere.Visible = false;
            check.Visible = false;
            goThroughTheDoor.Visible = false;
            exits.Visible = false;
        }

      /*  private void MoveToANewLocation(Location newLocation)
        {
            currentLocation = newLocation;

            exits.Items.Clear();
            for (int i = 0; i < currentLocation.Exits.Length; i++) 
            exits.Items.Add(currentLocation.Exits[i].Name);
            exits.SelectedIndex = 0;

            description.Text = currentLocation.Description;

            if (currentLocation is IHasExteriorDoor)
                goThroughTheDoor.Visible = true;
            else
                goThroughTheDoor.Visible = false;
        }*/

        private void goHere_Click(object sender, EventArgs e)
        {
            MoveToANewLocation(currentLocation.Exits[exits.SelectedIndex]);
        }

        private void goThroughTheDoor_Click(object sender, EventArgs e)
        {
            IHasExteriorDoor hasDoor = currentLocation as IHasExteriorDoor;
            MoveToANewLocation(hasDoor.DoorLocation);
        }

        private void check_Click(object sender, EventArgs e)
        {
            Moves++;
            if (opponent.Check(currentLocation))
                ResetGame(true);
            else
                RedrawForm();
        }

        private void Hide_Click(object sender, EventArgs e)
        {
            hide.Visible = false;
            for (int i = 1; i <= 10; i++)
            {
                opponent.Move();
                description.Text = i + "...";
                Application.DoEvents();
                System.Threading.Thread.Sleep(200);
            }
            description.Text = "Ready or not, here i come!";
            Application.DoEvents();
            System.Threading.Thread.Sleep(500);

            goHere.Visible = true;
            exits.Visible = true;
            MoveToANewLocation(livingRoom);
        }
    }

 

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Here's how to watch Summer Game Fest 2025 showcase today and what to expect by Pulasthi Ariyasinghe E3 as we know it might be dead, but Summer Game Fest is still going strong with its scheduled events in June. For five years now, Geoff Keighley has been organizing and hosting the video-game-centered platform to get developers and publishers a central location to have their reveal events. Summer Game Fest itself has its own massive show, and tonight, that kickoff event is going live with a whole bunch of announcements, updates, and more. The Summer Game Fest showcase hosted by Keighley is scheduled to go live at 2 PM PT | 5 PM ET | 10 PM BST later today, June 6. The live show is being hosted at the YouTube Theater in Los Angeles and is slated to run around two hours. To watch it online, viewers can tune into the show's YouTube (4K at 60 FPS), Twitch, Twitter, and Steam pages. Separate streams featuring American Sign Language and Descriptive Audio are available on YouTube as well. Not much information has been released regarding what gaming fans can expect to see at the event, but there are some clues and teasers to follow. Hideo Kojima is attending the event like always, meaning Death Stranding 2: On The Beach should get a brand-new trailer, unless it's a misdirect of some kind. The next entry in the Mafia franchise, The Old Country, the Soulslike action RPG Wuchang: Fallen Feathers, a surprise from the Splitgate 2 developer 1047 Games, a Fortnite-focused event from Epic Games, and new content for Atomic Heart should appear during the show. Being a rather long showcase, there should be plenty of other surprise reveals and announcements on stage, especially from major publishers like Ubisoft and 2K, which do not have their own dedicated summer events. Right after the main kickoff event, the Day of the Devs showcase will begin its own festivities at 4pm PT | 7pm ET. This is focused entirely on upcoming indie games. Later in the day, Devolver Digital and IO Interactive are hosting their own showcases. Here's the full calendar.
    • TIL you can report articles. reported as ad lol.
    • Paid US$798 for the 85" model which seemed like a better deal. Pretty nice TV.
    • Apple is making a scary move: a private company overchallenging a legit government and legislation. I am not a fan of democracy, but I am more scared of corporatism. The EU must take a strong stance now: Apple should comply with the law or face consequences, and it must do so immediately.
  • Recent Achievements

    • One Month Later
      EdwardFranciscoVilla earned a badge
      One Month Later
    • One Month Later
      MoyaM earned a badge
      One Month Later
    • One Month Later
      qology earned a badge
      One Month Later
    • One Year In
      Frinco90 earned a badge
      One Year In
    • Apprentice
      Frinco90 went up a rank
      Apprentice
  • Popular Contributors

    1. 1
      +primortal
      453
    2. 2
      +FloatingFatMan
      247
    3. 3
      snowy owl
      240
    4. 4
      ATLien_0
      196
    5. 5
      Xenon
      143
  • Tell a friend

    Love Neowin? Tell a friend!