• 0

(VB) Read Text File Into a 2 Dimensional Array


Question

I need to read a sequential data file into an array. I'm not where things are going wrong here. I keep getting an error "Input past end of file". I'm pretty certain my text file is good. Anyone tell me what I'm doing wrong? My text books aren't yielding the answers, nor is the internet thus far.

Dim strRecords(6, 5) As String

Dim product_list As String

Dim ProductList As Integer

Dim dataFile As String

Dim row As Integer

Dim col As Integer

dlgCommon.Filter = "DAT|*.dat|Text|*.txt|All|*.*"

dlgCommon.ShowOpen

product_list = dlgCommon.FileName

ProductList = FreeFile

Open product_list For Input As #1

Do Until EOF(1)

For row = 1 To 6

For col = 1 To 5

Input #1, strRecords(row, col)

Next col

Next row

Loop

And the text file...

"L666","SURGE PROTECTOR","PC KING",3.30,160,"N"<CR>

"M013","MS MOUSE","MEMORY-REX",23.22,28,"N"<CR>

"H013","20 GB HARD DISK","MICRO SHOP",190.90,18,"N"<CR>

"L005","17'' MONITOR","KING",205.00,4,"N"<CR>

"M713","56K BAUD MODEM","MEMORY-REX",99.00,88,"N"<EOF>

Thanks,

~D

5 answers to this question

Recommended Posts

  • 0
  MrA said:
Why aren't you using a structure to hold your data instead of a 2D array.  Also, items 4 & 5 of each line are numbers, not strings.  That may cause you some problems later (or maybe now).

585015640[/snapback]

Could you clarify your question. Are you asking why I am not using a structure or why I am not using a 2D array?

I know for this assignment I must use an array. I understand the concept of the array and how information is read into it. I just can't get information read into it. heh..

Also, I adjusted the text file making everything strings. I'll validate the numbers as needed.

  • 0
  deck said:
Could you clarify your question.  Are you asking why I am not using a structure or why I am not using a 2D array?

I know for this assignment I must use an array.  I understand the concept of the array and how information is read into it.  I just can't get information read into it. heh..

Also, I adjusted the text file making everything strings.  I'll validate the numbers as needed.

585015699[/snapback]

I'm asking why you are using a 2D array. You could define a structure and make a 1D array of that structure.

Type MyStruct
    Item1 as String
    Item2 as String
    Item3 as String
    Item4 as Single
    Item5 as Integer
    Item6 as String
End Type

Dim myArray(5) as MyStruct

Get rid of the DO LOOP. It will cause problems. Or you could change the loop to:

Dim i as Integer
i = 1
Do Until EOF(1)
  For col = 1 To 6
    Input #1, strRecords(col, i)
  Next
  i = i + 1
Loop

At then end of your data file, put:

"M713","56K BAUD MODEM","MEMORY-REX",99.00,88,"N"&lt;CR&gt;
&lt;EOF&gt;

  • 0

What is the "Input #" line storing in each string? Is it reading the entire line or is it stopping at each comma-delineated element?

For example:

Line 1 = "L666","SURGE PROTECTOR","PC KING",3.30,160,"N"

What does strRecords(1,1) equal?

Either: "L666","SURGE PROTECTOR","PC KING",3.30,160,"N"

Or: "L666"

  • 0
  DrZoidberg said:
What is the "Input #" line storing in each string?  Is it reading the entire line or is it stopping at each comma-delineated element?

For example:

Line 1 = "L666","SURGE PROTECTOR","PC KING",3.30,160,"N"

What does strRecords(1,1) equal?

Either: "L666","SURGE PROTECTOR","PC KING",3.30,160,"N"

Or: "L666"

585015945[/snapback]

I want it to read the entire line.

THEN, I want that line to be searchable using only the first field (L666). So I read the records into the array then search the first field of each of those records for the one I want.

I was able to get my array working... sort of... now I'm working on searching it.

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • I don't know, I haven't checked what changed in previous sockets. I agree that the 1156-1155-1151 succession was suspicious, with a reduction in pin count every time. Intel could do a better job of pre-allocating pins for future use. Another hypothesis is that the internal layout of their CPUs change, like the I/O is moved from one place to another on the chip, and they need to reorganize pins rather than having circuitry go into spaghetti mode to remain compatible. I agree that if AMD is able to maintain compatibility, Intel should be able to do the same, at least by reserving pins for future use and then using those pins when a need for them arises. However, I wouldn't say that AMD's products are entirely better. Intel's I/O now slightly edges out thanks to having double the bandwidth to the chipset and dedicated Thunderbolt lanes to the CPU. It seems that they could widen their lead with the next platform. NVMe SSDs have increased the need for PCIe lanes significantly, and AM5 has been pretty underwhelming in that regard, especially because the chipset connection is so narrow and gets saturated with just 1 gen 4 SSD, leaving the other chipset connectivity (Ethernet, Wi-Fi, audio, etc) to hope for any remaining bandwidth. Otherwise motherboard manufacturers could also make more x2 M.2 slots, those would be fast enough at gen 5 speeds and possibly at gen 4 speeds too.
    • Exactly, the E-cores actually give you good performance for what they offer, it's no surprise that Intel is doubling down on more E-cores instead of more P-cores. The LP-cores are good for when you're system is just sitting there idle and waiting to be used. Every core has it's place tbh, it's just up to Intel to and MS to work to get the scheduler right.
  • Recent Achievements

    • Week One Done
      korostelev earned a badge
      Week One Done
    • Week One Done
      rozermack875 earned a badge
      Week One Done
    • Week One Done
      oneworldtechnologies earned a badge
      Week One Done
    • Veteran
      matthiew went up a rank
      Veteran
    • Enthusiast
      Motoman26 went up a rank
      Enthusiast
  • Popular Contributors

    1. 1
      +primortal
      675
    2. 2
      ATLien_0
      264
    3. 3
      Michael Scrip
      184
    4. 4
      +FloatingFatMan
      177
    5. 5
      Steven P.
      140
  • Tell a friend

    Love Neowin? Tell a friend!