• 0

Java: Prevent opening duplicate dialogs


Question

I'm working on a java project that it has a menu where you can click File > Login to pop out a dialog for user to enter their login info.

My problem is, when the login dialog is present, user and focus back to the main JFrame and select File > Login to pop out another dialog. I'm searching for a way to prevent this from happening. So far I thought about two solutions but I don't know which is the best way to go about solving this kind of issue:

Solution 1: In my customzied JFrame class, declare a boolean that holds the visibility of the login dialog. Whenever the user goes File > Login, it will first check to see if it's already visible or not, then open the dialog if it's not already opened.

Solution 2: Prevent user to set focus back to the main JFrame when the dialog box is opened.

If you were me, how would you approach this problem? And which one is more effective or a common practice?

8 answers to this question

Recommended Posts

  • 0

erm... make the dialog modal. that should fix it.

if you don't want a modal dialog, you can have a private static bool isOpened=false;

that when it's opened it sets that to true and sets back to false when its closed. and on the creator of that dialog it just fails if the isOpened is true :p

i'd _really_ recommend the modal approach :p

  • 0
  Menge said:

erm... make the dialog modal. that should fix it.

if you don't want a modal dialog, you can have a private static bool isOpened=false;

that when it's opened it sets that to true and sets back to false when its closed. and on the creator of that dialog it just fails if the isOpened is true :p

i'd _really_ recommend the modal approach :p

That's not necessary. Create just one instance of it (global in your class that you're showing it in) and just have it so it hides when it closes:

myDialog.setDefaultCloseOperation(WindowConstants.HIDE_ON_CLOSE);

which is the default action.

And to make it visible:

myDialog.setVisible(true);

And if you're having to do some custom listener stuff for buttons and stuff and want to hide it after the user clicks it, put:

myDialog.setVisible(false);

in your action listener.

Edited by kjordan2001
  • 0
  kjordan2001 said:

That's not necessary. Create just one instance of it (global in your class that you're showing it in) and just have it so it hides when it closes:

myDialog.setDefaultCloseOperation(WindowConstants.HIDE_ON_CLOSE);

which is the default action.

And to make it visible:

myDialog.setVisible(true);

And if you're having to do some custom listener stuff for buttons and stuff and want to hide it after the user clicks it, put:

myDialog.setVisible(false);

in your action listener.

But if you do that, if people type info in the fields. You'll have to manually reset the fields, otherwise the next time the dialog shows, the info from the previous time the dialog was shown, will still be present.

  • 0
  Winston said:

But if you do that, if people type info in the fields. You'll have to manually reset the fields, otherwise the next time the dialog shows, the info from the previous time the dialog was shown, will still be present.

Just have it reset them in the submit action listener. Either way you'll have to do some work, question is which kind. Resetting or setting a variable.

  • 0

The best solution is to make the dialog a singleton ... ie only one instance can ever be created. Its called the singleton pattern. Its design pattern, google it

heres a quick example

public class MyFrame extends JFrame {

   public static MyFrame instance;

   private MyFrame() {
	 super(); 
   }

   public static MyFrame getInstance() {
	  if (instance = null)
		  instance = new MyFrame();
	  return instance;
   }

   main() {

	 MyFrame.getInstance().setVisbile(true);
	 ... or
	 MyFrame frame = MyFrame.getInstance();
	 frame.setVisible(true);
   }

   public void cleanup() {
	 instance = null;
  }
}

you will only ever get this one dialog only one instance can every be created. Note: you will need to free the instance yourself as the JVM will not clean it up.

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • That's not Pinocchio. That's a twink boy with a robot arm. Even the puppet is a lie in Lies of P!
    • I have a question on W11. Do VLC Player ( not the Store version ) and QBitorrent work with W11?
    • Splitgate 2 gets a surprise battle royale mode just as the free-to-play game releases by Pulasthi Ariyasinghe The highly anticipated arena shooter with portals, Splitgate 2, has just been released across PC and consoles as a free-to-play experience. At the same time, the studio head appeared on the Summer Game Fest showcase's stage today with a surprise reveal, showing off a brand-new battle royale mode that is a part of the game and is also launching today for free. Watch the action-packed trailer above. The sci-fi shooter franchise by 1047 Games has not breached the battle royale space before, but it seems the studio has been working secretly on the project all this time for this surprise reveal and launch. The Splitgate 2 battle royale mode features 60-player showdowns, letting 15 teams, each with four players, compete with each other to be the last squad standing. The map is touted as being an interconnected, gigantic colosseum with five biomes, and players will have to go through massive World Portals to reach each of them and hopefully take down anyone on the other side. "Choose where to drop in across Drought’s scorching desert, Glacier’s slick snowscape, Inferno’s active volcano, or Fracture’s cluster of asteroids," explains the developer. "After landing, players who stay in the match long enough will gain access to a fifth biome – the central area of Sanctum’s foreboding ruins, which offers special, powerful loot for those who can survive sparring to get it." Being a battle royale, there are chests to loot for better armaments, fast-paced action, map events to change up the atmosphere, and plenty of quick action to jump into. Aside from the new mode, with the Splitgate 2 full launch, the studio has delivered four new maps to the arena mode, a fresh map-creating template, as well as the Gravitas Shotgun as a brand-new weapon. It is also working on implementing a ranked mode, even more maps, map reskins, and more content as part of its post-launch support plans. Splitgate 2 is now available on PC (Steam and Epic Games Store), Xbox Series X|S, Xbox One, PlayStation 5, and PlayStation 4.
    • I hate that they have removed settings that we once had, and had them for what feels like forever. Until now.   My desktop icon font are too thin, and too small now in Windows 11 since the last Windows Update. I have been using Winareo Tweaker to set the icon font to bold, and to change the size to a size larger. Now I have to do it twice, loggin out and back in each time, before it finally takes effect on the third time. But wait.... it gets worse. Once the system is shutdown, and turned back on the next day, all of those icon settings are reset to thin, and small.   I see no reason for the previous font customization options we always had now being removed. SO upsetting.   Boo Microsoft. Updates are suppose to be 'better', not removing options we had previously. This is horrible.
  • Recent Achievements

    • Week One Done
      daelos earned a badge
      Week One Done
    • One Month Later
      daelos earned a badge
      One Month Later
    • Mentor
      Karlston went up a rank
      Mentor
    • One Month Later
      EdwardFranciscoVilla earned a badge
      One Month Later
    • One Month Later
      MoyaM earned a badge
      One Month Later
  • Popular Contributors

    1. 1
      +primortal
      492
    2. 2
      snowy owl
      256
    3. 3
      +FloatingFatMan
      252
    4. 4
      ATLien_0
      212
    5. 5
      Xenon
      150
  • Tell a friend

    Love Neowin? Tell a friend!