• 0

Java: Prevent opening duplicate dialogs


Question

I'm working on a java project that it has a menu where you can click File > Login to pop out a dialog for user to enter their login info.

My problem is, when the login dialog is present, user and focus back to the main JFrame and select File > Login to pop out another dialog. I'm searching for a way to prevent this from happening. So far I thought about two solutions but I don't know which is the best way to go about solving this kind of issue:

Solution 1: In my customzied JFrame class, declare a boolean that holds the visibility of the login dialog. Whenever the user goes File > Login, it will first check to see if it's already visible or not, then open the dialog if it's not already opened.

Solution 2: Prevent user to set focus back to the main JFrame when the dialog box is opened.

If you were me, how would you approach this problem? And which one is more effective or a common practice?

8 answers to this question

Recommended Posts

  • 0

erm... make the dialog modal. that should fix it.

if you don't want a modal dialog, you can have a private static bool isOpened=false;

that when it's opened it sets that to true and sets back to false when its closed. and on the creator of that dialog it just fails if the isOpened is true :p

i'd _really_ recommend the modal approach :p

  • 0
  Menge said:

erm... make the dialog modal. that should fix it.

if you don't want a modal dialog, you can have a private static bool isOpened=false;

that when it's opened it sets that to true and sets back to false when its closed. and on the creator of that dialog it just fails if the isOpened is true :p

i'd _really_ recommend the modal approach :p

That's not necessary. Create just one instance of it (global in your class that you're showing it in) and just have it so it hides when it closes:

myDialog.setDefaultCloseOperation(WindowConstants.HIDE_ON_CLOSE);

which is the default action.

And to make it visible:

myDialog.setVisible(true);

And if you're having to do some custom listener stuff for buttons and stuff and want to hide it after the user clicks it, put:

myDialog.setVisible(false);

in your action listener.

Edited by kjordan2001
  • 0
  kjordan2001 said:

That's not necessary. Create just one instance of it (global in your class that you're showing it in) and just have it so it hides when it closes:

myDialog.setDefaultCloseOperation(WindowConstants.HIDE_ON_CLOSE);

which is the default action.

And to make it visible:

myDialog.setVisible(true);

And if you're having to do some custom listener stuff for buttons and stuff and want to hide it after the user clicks it, put:

myDialog.setVisible(false);

in your action listener.

But if you do that, if people type info in the fields. You'll have to manually reset the fields, otherwise the next time the dialog shows, the info from the previous time the dialog was shown, will still be present.

  • 0
  Winston said:

But if you do that, if people type info in the fields. You'll have to manually reset the fields, otherwise the next time the dialog shows, the info from the previous time the dialog was shown, will still be present.

Just have it reset them in the submit action listener. Either way you'll have to do some work, question is which kind. Resetting or setting a variable.

  • 0

The best solution is to make the dialog a singleton ... ie only one instance can ever be created. Its called the singleton pattern. Its design pattern, google it

heres a quick example

public class MyFrame extends JFrame {

   public static MyFrame instance;

   private MyFrame() {
	 super(); 
   }

   public static MyFrame getInstance() {
	  if (instance = null)
		  instance = new MyFrame();
	  return instance;
   }

   main() {

	 MyFrame.getInstance().setVisbile(true);
	 ... or
	 MyFrame frame = MyFrame.getInstance();
	 frame.setVisible(true);
   }

   public void cleanup() {
	 instance = null;
  }
}

you will only ever get this one dialog only one instance can every be created. Note: you will need to free the instance yourself as the JVM will not clean it up.

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Burrrrn. Bought COD WWII last month when it was on sale for PC. Oh well. Excellent game tho, and the PC version plays/looks amazing (and has it's own PC achievements). ...wondering if this is a lesson on waiting on sales. ...also hoping Rise of the Tomb Raider has it's own PC Achievements
    • Google Chrome 137.0.7151.120 (offline installer) by Razvan Serea The web browser is arguably the most important piece of software on your computer. You spend much of your time online inside a browser: when you search, chat, email, shop, bank, read the news, and watch videos online, you often do all this using a browser. Google Chrome is a browser that combines a minimal design with sophisticated technology to make the web faster, safer, and easier. Use one box for everything--type in the address bar and get suggestions for both search and Web pages. Thumbnails of your top sites let you access your favorite pages instantly with lightning speed from any new tab. Desktop shortcuts allow you to launch your favorite Web apps straight from your desktop. Chrome has many useful features built in, including automatic full-page translation and access to thousands of apps, extensions, and themes from the Chrome Web Store. Google Chrome is one of the best solutions for Internet browsing giving you high level of security, speed and great features. Important to know! The offline installer links do not include the automatic update feature. Google Chrome 137.0.7151.120 changelog: [$7000][420697404] High CVE-2025-6191: Integer overflow in V8. Reported by Shaheen Fazim on 2025-05-27 [$4000][421471016] High CVE-2025-6192: Use after free in Profiler. Reported by Chaoyuan Peng (@ret2happy) on 2025-05-31 [425443272] Various fixes from internal audits, fuzzing and other initiatives Download web installer: Google Chrome Web 32-bit | Google Chrome 64-bit | Freeware Download: Google Chrome Offline Installer 64-bit | 128.0 MB Download: Google Chrome Offline Installer 32-bit | 115.0 MB Download page: Google Chrome Portable Download: Google Chrome MSI Installers for Windows (automatic update) View: Chrome Website | Release Notes Get alerted to all of our Software updates on Twitter at @NeowinSoftware
    • -Drop the art style, it's cool but doesn't fit the franchise at all. -Make it a gritty single player game, like Halo -Include deathmatch and all that stuff, extraction can be a separate mode If they don't do that, it's dead on arrival IMO.
    • It's a shame because it's one of the best immersive sims ever made, even though it could have used a bit more monster variety IMO.
  • Recent Achievements

    • One Month Later
      Custom Greek Shirts earned a badge
      One Month Later
    • Week One Done
      Custom Greek Shirts earned a badge
      Week One Done
    • One Year In
      Custom Greek Shirts earned a badge
      One Year In
    • Week One Done
      topantidetectbrowser earned a badge
      Week One Done
    • Explorer
      Jdoe25 went up a rank
      Explorer
  • Popular Contributors

    1. 1
      +primortal
      672
    2. 2
      ATLien_0
      281
    3. 3
      Michael Scrip
      223
    4. 4
      +FloatingFatMan
      190
    5. 5
      Steven P.
      146
  • Tell a friend

    Love Neowin? Tell a friend!