• 0

Java: Prevent opening duplicate dialogs


Question

I'm working on a java project that it has a menu where you can click File > Login to pop out a dialog for user to enter their login info.

My problem is, when the login dialog is present, user and focus back to the main JFrame and select File > Login to pop out another dialog. I'm searching for a way to prevent this from happening. So far I thought about two solutions but I don't know which is the best way to go about solving this kind of issue:

Solution 1: In my customzied JFrame class, declare a boolean that holds the visibility of the login dialog. Whenever the user goes File > Login, it will first check to see if it's already visible or not, then open the dialog if it's not already opened.

Solution 2: Prevent user to set focus back to the main JFrame when the dialog box is opened.

If you were me, how would you approach this problem? And which one is more effective or a common practice?

8 answers to this question

Recommended Posts

  • 0

erm... make the dialog modal. that should fix it.

if you don't want a modal dialog, you can have a private static bool isOpened=false;

that when it's opened it sets that to true and sets back to false when its closed. and on the creator of that dialog it just fails if the isOpened is true :p

i'd _really_ recommend the modal approach :p

  • 0
  Menge said:

erm... make the dialog modal. that should fix it.

if you don't want a modal dialog, you can have a private static bool isOpened=false;

that when it's opened it sets that to true and sets back to false when its closed. and on the creator of that dialog it just fails if the isOpened is true :p

i'd _really_ recommend the modal approach :p

That's not necessary. Create just one instance of it (global in your class that you're showing it in) and just have it so it hides when it closes:

myDialog.setDefaultCloseOperation(WindowConstants.HIDE_ON_CLOSE);

which is the default action.

And to make it visible:

myDialog.setVisible(true);

And if you're having to do some custom listener stuff for buttons and stuff and want to hide it after the user clicks it, put:

myDialog.setVisible(false);

in your action listener.

Edited by kjordan2001
  • 0
  kjordan2001 said:

That's not necessary. Create just one instance of it (global in your class that you're showing it in) and just have it so it hides when it closes:

myDialog.setDefaultCloseOperation(WindowConstants.HIDE_ON_CLOSE);

which is the default action.

And to make it visible:

myDialog.setVisible(true);

And if you're having to do some custom listener stuff for buttons and stuff and want to hide it after the user clicks it, put:

myDialog.setVisible(false);

in your action listener.

But if you do that, if people type info in the fields. You'll have to manually reset the fields, otherwise the next time the dialog shows, the info from the previous time the dialog was shown, will still be present.

  • 0
  Winston said:

But if you do that, if people type info in the fields. You'll have to manually reset the fields, otherwise the next time the dialog shows, the info from the previous time the dialog was shown, will still be present.

Just have it reset them in the submit action listener. Either way you'll have to do some work, question is which kind. Resetting or setting a variable.

  • 0

The best solution is to make the dialog a singleton ... ie only one instance can ever be created. Its called the singleton pattern. Its design pattern, google it

heres a quick example

public class MyFrame extends JFrame {

   public static MyFrame instance;

   private MyFrame() {
	 super(); 
   }

   public static MyFrame getInstance() {
	  if (instance = null)
		  instance = new MyFrame();
	  return instance;
   }

   main() {

	 MyFrame.getInstance().setVisbile(true);
	 ... or
	 MyFrame frame = MyFrame.getInstance();
	 frame.setVisible(true);
   }

   public void cleanup() {
	 instance = null;
  }
}

you will only ever get this one dialog only one instance can every be created. Note: you will need to free the instance yourself as the JVM will not clean it up.

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Black Myth: Wukong hits Xbox this August, exactly a year after PlayStation launch by Pulasthi Ariyasinghe Developer Game Science delivered one of the biggest action games of all time last year, with Black Myth: Wukong going on to sell tens of millions in its launch month and winning a multitude of awards. However, the title skipped out on a platform it was originally announced to launch in: Xbox. Following a long string of reasons and delays, it seems the port is finally coming to the platform. Today, Game Science announced that the Xbox Series X|S version of Black Myth: Wukong now has a release date, with it landing on August 20, 2025. Pre-orders for the title will become available starting June 18. Interestingly, this Xbox release date is set exactly one year after the original release on PlayStation 5 and PC. Game Science originally stated that the delay was due to technical issues with Xbox consoles. However, Microsoft refuted that claim quickly and alluded that the delay was due to some sort of console exclusivity deal between Game Science and Sony. In today's announcement, Game Science once again says that the delay was due to its work on porting the game to Xbox and meeting its quality standards. "Bringing Black Myth: Wukong to Xbox Series X|S—and ensuring the experience met our internal quality standards—was no easy feat," said the studio today regarding the long delay on Xbox platforms. "Fortunately, we were able to complete this challenging task smoothly within the first year of the game's official release." "If you're an Xbox player who hasn't yet experienced the game on another platform, we're confident it will stand among the finest ARPGs available on Xbox," added Game Science. For those looking to jump into the game a little cheaper than usual, Game Science will be hosting Black Myth: Wukong's first-ever sale on June 18. The 20% off discount will be available across PC, PlayStation, and even the Microsoft Store for the Xbox Series X|S pre-order.
    • And where is "don't be evil"? Oh, yeah, they removed it, too.
    • YouTube isn't a monopoly, it's just the most popular video platform, but other options and competitors do exist. And I'm not defending YouTube here, I'm a subscriber to Geerling's channel and I like his content and YouTube clearly went too far with this, but they can't be considered a monopoly, IMO. https://www.captions.ai/blog-post/youtube-alternatives
    • Harmful to them because it affects their business. *Sigh*
  • Recent Achievements

    • Week One Done
      theevergreentree earned a badge
      Week One Done
    • Dedicated
      Fryer Tuck earned a badge
      Dedicated
    • Week One Done
      luxoxfurniture earned a badge
      Week One Done
    • First Post
      Uranus_enjoyer earned a badge
      First Post
    • Week One Done
      Uranus_enjoyer earned a badge
      Week One Done
  • Popular Contributors

    1. 1
      +primortal
      439
    2. 2
      +FloatingFatMan
      247
    3. 3
      snowy owl
      227
    4. 4
      ATLien_0
      212
    5. 5
      Xenon
      152
  • Tell a friend

    Love Neowin? Tell a friend!