• 0

Java: Prevent opening duplicate dialogs


Question

I'm working on a java project that it has a menu where you can click File > Login to pop out a dialog for user to enter their login info.

My problem is, when the login dialog is present, user and focus back to the main JFrame and select File > Login to pop out another dialog. I'm searching for a way to prevent this from happening. So far I thought about two solutions but I don't know which is the best way to go about solving this kind of issue:

Solution 1: In my customzied JFrame class, declare a boolean that holds the visibility of the login dialog. Whenever the user goes File > Login, it will first check to see if it's already visible or not, then open the dialog if it's not already opened.

Solution 2: Prevent user to set focus back to the main JFrame when the dialog box is opened.

If you were me, how would you approach this problem? And which one is more effective or a common practice?

8 answers to this question

Recommended Posts

  • 0

erm... make the dialog modal. that should fix it.

if you don't want a modal dialog, you can have a private static bool isOpened=false;

that when it's opened it sets that to true and sets back to false when its closed. and on the creator of that dialog it just fails if the isOpened is true :p

i'd _really_ recommend the modal approach :p

  • 0
  Menge said:

erm... make the dialog modal. that should fix it.

if you don't want a modal dialog, you can have a private static bool isOpened=false;

that when it's opened it sets that to true and sets back to false when its closed. and on the creator of that dialog it just fails if the isOpened is true :p

i'd _really_ recommend the modal approach :p

That's not necessary. Create just one instance of it (global in your class that you're showing it in) and just have it so it hides when it closes:

myDialog.setDefaultCloseOperation(WindowConstants.HIDE_ON_CLOSE);

which is the default action.

And to make it visible:

myDialog.setVisible(true);

And if you're having to do some custom listener stuff for buttons and stuff and want to hide it after the user clicks it, put:

myDialog.setVisible(false);

in your action listener.

Edited by kjordan2001
  • 0
  kjordan2001 said:

That's not necessary. Create just one instance of it (global in your class that you're showing it in) and just have it so it hides when it closes:

myDialog.setDefaultCloseOperation(WindowConstants.HIDE_ON_CLOSE);

which is the default action.

And to make it visible:

myDialog.setVisible(true);

And if you're having to do some custom listener stuff for buttons and stuff and want to hide it after the user clicks it, put:

myDialog.setVisible(false);

in your action listener.

But if you do that, if people type info in the fields. You'll have to manually reset the fields, otherwise the next time the dialog shows, the info from the previous time the dialog was shown, will still be present.

  • 0
  Winston said:

But if you do that, if people type info in the fields. You'll have to manually reset the fields, otherwise the next time the dialog shows, the info from the previous time the dialog was shown, will still be present.

Just have it reset them in the submit action listener. Either way you'll have to do some work, question is which kind. Resetting or setting a variable.

  • 0

The best solution is to make the dialog a singleton ... ie only one instance can ever be created. Its called the singleton pattern. Its design pattern, google it

heres a quick example

public class MyFrame extends JFrame {

   public static MyFrame instance;

   private MyFrame() {
	 super(); 
   }

   public static MyFrame getInstance() {
	  if (instance = null)
		  instance = new MyFrame();
	  return instance;
   }

   main() {

	 MyFrame.getInstance().setVisbile(true);
	 ... or
	 MyFrame frame = MyFrame.getInstance();
	 frame.setVisible(true);
   }

   public void cleanup() {
	 instance = null;
  }
}

you will only ever get this one dialog only one instance can every be created. Note: you will need to free the instance yourself as the JVM will not clean it up.

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Harmful to them because it affects their business. *Sigh*
    • TCL 75" 4K Smart TV hits lowest price, now less than £500 by Paul Hill Are you in the UK and looking for a massive 75-inch Ultra HD 4K HDR TV at a relatively affordable price? If so, check out this TCL (75P755K) 75-inch TV now because it’s at its lowest price of just £499.00, down 15% from £589.00. The model in question is slightly older, from 2024, but it’s still an excellent home entertainment upgrade given its feature set and aggressive price point. What you get: Features for the price The feature set of this model is definitely pretty impressive. It supports 4K HDR, wide colour gamut, and multiple HDR formats including HDR10+ and Dolby Vision. It also leverages MEMC (Motion Estimation & Motion Compensation), a proprietary algorithm from TCL that helps to reduce motion display blur and keep motion trails to a minimum. While MEMC will do heavy lifting to ensure the best picture, the TV only has a 60Hz refresh rate, but an effective rate of 120Hz thanks to efforts by TCL. This TCL model features Dolby Atmos 2.0 that immerses you more in whatever you’re watching on the TV. In terms of software, this TV comes with Google TV (based on Android) which is well-known and widely supported, ensuring you can use all the apps you depend on. It also supports Google Assistant, Chromecast, and voice control. The Chromecast support allows you to easily stream from your computer or phone to the TV to share what you’re watching to the people around you. The Google Assistant support can also be good if you have smart home devices around the house that can connect to it. The audio features for this TV are also good and mean you don’t need to buy a separate sound bar immediately. User experience and potential considerations According to What Hi-Fi, which reviewed the smaller 65-inch version of this TV, TCL’s TV delivers when it comes to HDR; gaming features such as low input lag, VRR, and Game Bar; wide colour gamut, and the operating system. What it didn’t like about the TV was the limited brightness, which degraded the HDR in bright rooms; the average motion handling; the lack of bass; the lack of local dimming; and the budget-oriented build quality. Making the smart buy decision If you can overlook its limitations, this TV could be a good pick if you need a new TV in the living room on a budget. If you are a serious gamer looking for a high refresh rate, or someone in a very bright room, then you will probably want to look elsewhere. Amazon is also offering free add-on services including wall mounting and unpack. If you do decide to pick up this TCL TV and find a fault with it, you have 30-days from getting the receipt to return it. TCL 75P755K 75-inch 4K TV: £499 (Amazon UK) - MSRP £589 / 15% off This Amazon deal is U.K. specific, and not available in other regions unless specified. If you don't like it or want to look at more options, check out the Amazon UK deals page here. Get Prime, Prime Video, Music Unlimited, Audible or Kindle Unlimited, free for the first 30 days As an Amazon Associate we earn from qualifying purchases.
    • I came here to post something similar, you beat me to it. Why on earth would somebody buy Windows again, even this shady grey-market cheap key, when they already have it and an upgrade from 10 to 11 is free?
    • I maintain that the Cybertruck was a social experiment.  "Can we convince the massively insecure petrol guzzling, Dodge Ram loving, right wing idiots to buy a poorly built, underpowered, underspecified, electric vehicle that they know everyone will laugh at them in"
  • Recent Achievements

    • Week One Done
      theevergreentree earned a badge
      Week One Done
    • Dedicated
      Fryer Tuck earned a badge
      Dedicated
    • Week One Done
      luxoxfurniture earned a badge
      Week One Done
    • First Post
      Uranus_enjoyer earned a badge
      First Post
    • Week One Done
      Uranus_enjoyer earned a badge
      Week One Done
  • Popular Contributors

    1. 1
      +primortal
      439
    2. 2
      +FloatingFatMan
      247
    3. 3
      snowy owl
      226
    4. 4
      ATLien_0
      212
    5. 5
      Xenon
      152
  • Tell a friend

    Love Neowin? Tell a friend!