• 0

Java: Prevent opening duplicate dialogs


Question

I'm working on a java project that it has a menu where you can click File > Login to pop out a dialog for user to enter their login info.

My problem is, when the login dialog is present, user and focus back to the main JFrame and select File > Login to pop out another dialog. I'm searching for a way to prevent this from happening. So far I thought about two solutions but I don't know which is the best way to go about solving this kind of issue:

Solution 1: In my customzied JFrame class, declare a boolean that holds the visibility of the login dialog. Whenever the user goes File > Login, it will first check to see if it's already visible or not, then open the dialog if it's not already opened.

Solution 2: Prevent user to set focus back to the main JFrame when the dialog box is opened.

If you were me, how would you approach this problem? And which one is more effective or a common practice?

8 answers to this question

Recommended Posts

  • 0

erm... make the dialog modal. that should fix it.

if you don't want a modal dialog, you can have a private static bool isOpened=false;

that when it's opened it sets that to true and sets back to false when its closed. and on the creator of that dialog it just fails if the isOpened is true :p

i'd _really_ recommend the modal approach :p

  • 0
  Menge said:

erm... make the dialog modal. that should fix it.

if you don't want a modal dialog, you can have a private static bool isOpened=false;

that when it's opened it sets that to true and sets back to false when its closed. and on the creator of that dialog it just fails if the isOpened is true :p

i'd _really_ recommend the modal approach :p

That's not necessary. Create just one instance of it (global in your class that you're showing it in) and just have it so it hides when it closes:

myDialog.setDefaultCloseOperation(WindowConstants.HIDE_ON_CLOSE);

which is the default action.

And to make it visible:

myDialog.setVisible(true);

And if you're having to do some custom listener stuff for buttons and stuff and want to hide it after the user clicks it, put:

myDialog.setVisible(false);

in your action listener.

Edited by kjordan2001
  • 0
  kjordan2001 said:

That's not necessary. Create just one instance of it (global in your class that you're showing it in) and just have it so it hides when it closes:

myDialog.setDefaultCloseOperation(WindowConstants.HIDE_ON_CLOSE);

which is the default action.

And to make it visible:

myDialog.setVisible(true);

And if you're having to do some custom listener stuff for buttons and stuff and want to hide it after the user clicks it, put:

myDialog.setVisible(false);

in your action listener.

But if you do that, if people type info in the fields. You'll have to manually reset the fields, otherwise the next time the dialog shows, the info from the previous time the dialog was shown, will still be present.

  • 0
  Winston said:

But if you do that, if people type info in the fields. You'll have to manually reset the fields, otherwise the next time the dialog shows, the info from the previous time the dialog was shown, will still be present.

Just have it reset them in the submit action listener. Either way you'll have to do some work, question is which kind. Resetting or setting a variable.

  • 0

The best solution is to make the dialog a singleton ... ie only one instance can ever be created. Its called the singleton pattern. Its design pattern, google it

heres a quick example

public class MyFrame extends JFrame {

   public static MyFrame instance;

   private MyFrame() {
	 super(); 
   }

   public static MyFrame getInstance() {
	  if (instance = null)
		  instance = new MyFrame();
	  return instance;
   }

   main() {

	 MyFrame.getInstance().setVisbile(true);
	 ... or
	 MyFrame frame = MyFrame.getInstance();
	 frame.setVisible(true);
   }

   public void cleanup() {
	 instance = null;
  }
}

you will only ever get this one dialog only one instance can every be created. Note: you will need to free the instance yourself as the JVM will not clean it up.

This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • It's cheaper to let their 3rd party sales people do more than supporting thousands in-house. Sucks for those who lost a job but these tech and entertainment companies overstaffed with the lockdown and the huge boost in demand they got when everyone was stuck at home.
    • The Xbox game bar says hi. It's been able to show you CPU, RAM, GPU and FPS for as long as I can remember.
    • WinSCP 6.5.2 by Razvan Serea  WinSCP is an open source free SFTP client, FTP client, WebDAV client and SCP client for Windows. Its main function is file transfer between a local and a remote computer. Beyond this, WinSCP offers scripting and basic file manager functionality. WinSCP features: Graphical user interface Translated into several languages Integration with Windows (drag&drop, URL, shortcut icons) U3 support All common operations with files Support for SFTP and SCP protocols over SSH-1 and SSH-2 and plain old FTP protocol Batch file scripting and command-line interface Directory synchronization in several semi or fully automatic ways Integrated text editor Support for SSH password, keyboard-interactive, public key and Kerberos (GSS) authentication Integrates with Pageant (PuTTY authentication agent) for full support of public key authentication with SSH Explorer and Commander interfaces Optionally stores session information Optionally supports portable operation using a configuration file in place of registry entries, suitable for operation from removable media WinSCP 6.5.2 changelog: Thumbnail view in file panels. Three selectable sizes of toolbar icons, showing slightly larger size by default. Switching to Segoe UI font with slightly larger size. Improvements to Synchronization checklist window, including resolving file moves and pushing synchronization to background queue. Ongoing local delete operation can be moved to a background queue. Optimized working with large local directories. Compatibility with new OneDrive WebDAV interface. Dark theme for session tabs. Improvements to S3 support, including more options to authentication and display and modification of S3 file/object tags. List of all changes. Download: WinSCP 6.5.2 | 11.6 MB (Open Source) Download: WinSCP MSI | 28.7 MB Download: Standalone Executable | 8.4 MB Link: WinSCP Home page | Screenshot Get alerted to all of our Software updates on Twitter at @NeowinSoftware
    • QOwnNotes 25.6.2 by Razvan Serea QOwnNotes is a open source (GPL) plain-text file notepad with markdown support and todo list manager for GNU/Linux, Mac OS X and Windows, that (optionally) works together with the notes application of ownCloud (or Nextcloud). So you are able to write down your thoughts with QOwnNotes and edit or search for them later from your mobile device (like with CloudNotes) or the ownCloud web-service. The notes are stored as plain text files and you can sync them with your ownCloud sync client. Of course other software, like Dropbox, Syncthing, Seafile or BitTorrent Sync can be used too. Features: the notes folder can be freely chosen (multiple note folders can be used) sub-string searching of notes is possible and search results are highlighted in the notes application can be operated with customizable keyboard shortcuts external changes of note files are watched (notes or note list are reloaded) older versions of your notes can be restored from your ownCloud server trashed notes can be restored from your ownCloud server differences between current note and externally changed note are showed in a dialog markdown highlighting of notes and a markdown preview mode notes are getting their name from the first line of the note text (just like in the ownCloud notes web-application) and the note text files are automatically renamed, if the the first line changes compatible with the notes web-application of ownCloud and mobile ownCloud notes applications compatible with ownCloud's selective sync feature by supporting an unlimited amount of note folders with the ability to choose the respective folder on your server manage your ownCloud todo lists (ownCloud tasks or Tasks Plus / Calendar Plus) or use an other CalDAV server to sync your tasks to encryption of notes (AES-256 is built in or you can use custom encryption methods like Keybase.io (encryption-keybase.qml) or PGP (encryption-pgp.qml)) dark mode theme support theming support for the markdown syntax highlighting all panels can be placed wherever you want, they can even float or stack (fully dockable) support for freedesktop theme icons, you can use QOwnNotes with your native desktop icons and with your favorite dark desktop theme support for hierarchical note tagging and note subfolders support for sharing notes on your ownCloud server portable mode for carrying QOwnNotes around on USB sticks Evernote import QOwnNotes is available in many different languages like English, German, French, Polish, Chinese, Japanese, Russian, Portuguese, Hungarian, Dutch and Spanish Changes in QOwnNotes 25.6.2: The Find action dialog is now working again (for #3294) Added more French translation (thank you, jd-develop) Download: QOwnNotes 25.6.2 | 37.3 MB (Open Source) Download: QOwnNotes for Other Operating Systems View: QOwnNotes Home Page | Screenshot Get alerted to all of our Software updates on Twitter at @NeowinSoftware
  • Recent Achievements

    • First Post
      Fuzz_c earned a badge
      First Post
    • First Post
      TIGOSS earned a badge
      First Post
    • Week One Done
      slackerzz earned a badge
      Week One Done
    • Week One Done
      vivetool earned a badge
      Week One Done
    • Reacting Well
      pnajbar earned a badge
      Reacting Well
  • Popular Contributors

    1. 1
      +primortal
      704
    2. 2
      ATLien_0
      279
    3. 3
      Michael Scrip
      209
    4. 4
      +FloatingFatMan
      197
    5. 5
      Steven P.
      130
  • Tell a friend

    Love Neowin? Tell a friend!