C# Coding Problem

[The Grasshopper]

Ok. I am not a programmer and am in school for this (yeah, yeah, at my age..I know).

I do not have a c# book and it's an online class and the instructor does not go that far into detail. example for this homework was all done in "text" and no numbers..integers...etc.

i have had to figure this much out on my own. Not very good anyway.

could anyone help me to find what is wrong with this code? I can't covert the last line..or the lblResults box. It's a simple calculator. I have had one VB class but I don't think it's helping.

Thanks in advance

using System;
using System.Configuration;
using System.Data;
using System.Linq;
using System.Collections.Generic;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.HtmlControls;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Xml.Linq;
public partial class _Default : System.Web.UI.Page
{
    protected void Page_Load(object sender, EventArgs e)
    {
        //this is the time
        lblOut.Text = DateTime.Now.ToString();
    }


    protected void btnSubmit_Click(object sender, EventArgs e)
    {
        //Setting the text to the stxt box by default
        string sText = "";
        sText = lblResults.Text;

        //Checking for a length in the name box
        if (txtBoxName.Text.Length == 0)
        {
            lblResults.Text = "Enter Your Name";

            return;
        }
        if (txtBoxEarnings.Text.Length == 0)
        {
            lblResults.Text = "Please enter Your Earnings";

            return;
        }
        if (txtBoxHealth.Text.Length == 0)
        {
            lblResults.Text = "Please enter your Health Deductions";

            return;
        }
        if (txtBox401K.Text.Length == 0)
        {
            lblResults.Text = "Please enter your 410k deduction";

            return;
        }

             //setting the values of radio buttons.

   {        int rad1 =  8;
            int rad2 =  52;
            int rad3 =  12;
            string sResult; 


        if (rdoInterval1.Checked == true)
             sResult = "txtBoxEarnings.Text * rad1";
        else if (rdoInterval2.Checked == true)
             sResult = "txtBoxEarnings.Text * rad2";
        else if (rdoInterval3.Checked == true)
             sResult = "txtBoxEarnings.Text * rad3";
        else
             lblResults.Text = "please select a button";

       // trying to add the health and 401k together
         int fourK =  12;
         int Health = 12;

         string strEarnings;
         string strHealth;
         string str401k;


         strHealth = "txtBoxHealth.Text * Health";
         str401k = "txtBox401K.Text * fourK";
         strEarnings = "txtBoxEarnings.Text";
       // getting the results
        lblResults = Convert.ToInt32("strEarnings + sResult + strHealth + str401k");
   }
    }

}

[Commodore Max]

That's just package importing. Theoretically there shouldn't be anything wrong with that code unless you're missing some libraries.

[Banjo]

When you use a variable, don't put quotes around it. They give you a literal string. For example:

a = 2

b = 3

a + b gives you 5, but

"a + b" gives you the text "a + b"

That's just package importing. Theoretically there shouldn't be anything wrong with that code unless you're missing some libraries.

Scroll down

[The Grasshopper]

When you use a variable, don't put quotes around it. They give you a literal string. For example:

a = 2

b = 3

a + b gives you 5, but

"a + b" gives you the text "a + b"

Scroll down

but when i put any of the code without the "Quotes" that i want to add/multiply..it says it can't covert string to int and/or the other way around.

[Banjo]

Well, another thing with this line is that you missed the .text after lblResults. Currently, it's trying to change the label itself to a number, when you want to change the text property of the label

lblResults = Convert.ToInt32("strEarnings + sResult + strHealth + str401k");

Try this:

lblResults.Text = Convert.ToInt32(strEarnings + sResult + strHealth + str401k);

You should also switch your variables to integers, as they are for storing numbers. Strings are for text

[The Grasshopper]

That's just package importing. Theoretically there shouldn't be anything wrong with that code unless you're missing some libraries.

I thought it looked good, but i couldn't get it to compile for debugging.

the argument says: "Error 5 Cannot implicitly convert type 'int' to 'System.Web.UI.WebControls.Label'

Well, another thing with this line is that you missed the .text after lblResults. Currently, it's trying to change the label itself to a number, when you want to change the text property of the label

lblResults = Convert.ToInt32("strEarnings + sResult + strHealth + str401k");

Try this:

lblResults.text = Convert.ToInt32(strEarnings + sResult + strHealth + str401k);

You should also switch your variables to integers, as they are for storing numbers. Strings are for text

Fixed that..thanks.

but now it says this:

Error 4 Cannot implicitly convert type 'int' to 'string' C:\Users\John\Documents\Cincinnati State\IT5283

You should also switch your variables to integers, as they are for storing numbers. Strings are for text

I don't know where to change them and exactly how to make them work.

[Banjo]

Every variable has a function called ToString() that converts it into a string representation. What you might want to do is something like this:

intSum = intEarnings + intResult + intHealth + int401k;
lblResults.Text = intSum.ToString();

Don't forget to fix the variables in quotes on your other lines.

Also, when you read a number from a textbox, it is stored as a string. To do any math with it, it has to be an integer. So when you read, do something like this:

intValue = Convert.ToInt32(txtUsersValue.Text);

[GreenMartian]

As Banjo said, you got them the other way round. You should convert all the textbox values to Int to be able to perform math operations on them. When you want to stick the result back to another textbox, you THEN convert the result back to string.

For example, THIS:

string strEarnings;
string strHealth;
string str401k;

strHealth = "txtBoxHealth.Text * Health";
str401k = "txtBox401K.Text * fourK";
strEarnings = "txtBoxEarnings.Text";
// getting the results
lblResults = Convert.ToInt32("strEarnings + sResult + strHealth + str401k");

Should've looked more like this:

int iEarnings;
int iHealth;
int i401k;

iHealth = Convert.ToInt32(txtBoxHealth.Text) * Health;
i401k = Convert.ToInt32(txtBox401K.Text) * fourK;
iEarnings = Convert.ToInt32(txtBoxEarnings.Text);
// getting the results
lblResults.Text = (iEarnings + iResult + iHealth + i401k).ToString();

I leave the exercise of fixing the iResult calculation to you.

[Banjo]

I don't know where to change them and exactly how to make them work.

string sResult;

string strEarnings;

string strHealth;

string str401k;

All of these variables are variables that you're using for numbers, so they should be something like this:

int intResult;

int intEarnings;

int intHealth;

int int401k;

See my previous post about reading from textboxes

[The Grasshopper]

Every variable has a function called ToString() that converts it into a string representation. What you might want to do is something like this:

intSum = intEarnings + intResult + intHealth + int401k;
lblResults.Text = intSum.ToString();

Don't forget to fix the variables in quotes on your other lines.

Also, when you read a number from a textbox, it is stored as a string. To do any math with it, it has to be an integer. So when you read, do something like this:

intValue = Convert.ToInt32(txtUsersValue.Text);

I am currently rewriting all of the strings that have numbers.

Thanks everyone for your help!

will be right back to post what i have

[The Grasshopper]

thanks everyone.

i changed all the strings that were to be used from text boxes to numbers except one. my radio buttons. since i changed out the string...i don't know what to do about the problem. it says:Error 4 Use of unassigned local variable 'iResult'

how do i changed that so i can multiply with it later.

what am i doing wrong here? i have been working on this since 2pm yesterday...and man..i am about to pass out!

using System;
using System.Configuration;
using System.Data;
using System.Linq;
using System.Collections.Generic;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.HtmlControls;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Xml.Linq;
public partial class _Default : System.Web.UI.Page
{
    protected void Page_Load(object sender, EventArgs e)
    {
        //this is the time
        lblOut.Text = DateTime.Now.ToString();
    }


    protected void btnSubmit_Click(object sender, EventArgs e)
    {
        //Setting the text to the stxt box by default
        string sText = "";
        sText = lblResults.Text;

        //Checking for a length in the name box
        if (txtBoxName.Text.Length == 0)
        {
            lblResults.Text = "Enter Your Name";

            return;
        }
        if (txtBoxEarnings.Text.Length == 0)
        {
            lblResults.Text = "Please enter Your Earnings";

            return;
        }
        if (txtBoxHealth.Text.Length == 0)
        {
            lblResults.Text = "Please enter your Health Deductions";

            return;
        }
        if (txtBox401K.Text.Length == 0)
        {
            lblResults.Text = "Please enter your 410k deduction";

            return;
        }

             //setting the values of radio buttons.

   {        int rad1 =  8;
            int rad2 =  52;
            int rad3 =  12;
            int iResult; [b]THIS IS UNSIGNED LOCAL VARIABLE?[/b]


        if (rdoInterval1.Checked == true)
             iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad1;
        else if (rdoInterval2.Checked == true)
            iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad2;
        else if (rdoInterval3.Checked == true)
            iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad3;
        else
             lblResults.Text = "please select a button";

       // trying to add the health and 401k together
         int fourK =  12;
         int Health = 12;


         int intHealth = Convert.ToInt32(txtBoxHealth.Text);
         int int401k   = Convert.ToInt32(txtBox401K.Text);

         int iEarnings;
         int iHealth;
         int i401k;

         iHealth = Convert.ToInt32(txtBoxHealth.Text) * Health;
         i401k = Convert.ToInt32(txtBox401K.Text) * fourK;
         iEarnings = Convert.ToInt32(txtBoxEarnings.Text);
         // getting the results
         lblResults.Text = (iEarnings + iResult + iHealth + i401k).ToString();

        }
    }

}

[Banjo]

That means that you are trying to do something with the value of a variable you have never set. If you want to add, subtract, multiply or whatever with a variable, you must have given it a value already.

if (rdoInterval1.Checked == true)
iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad1;
else if (rdoInterval2.Checked == true)
iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad2;
else if (rdoInterval3.Checked == true)
iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad3;
else
lblResults.Text = "please select a button"; //------------------------You code is going to here.

In that case, it doesn't give a value to iResult like the other else if statements do. This is a case where your program should stop as soon as it encounters this error, so you should leave the function right away and stop calculating stuff. Try this:

if (rdoInterval1.Checked == true)
iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad1;
else if (rdoInterval2.Checked == true)
iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad2;
else if (rdoInterval3.Checked == true)
iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad3;
else
{
lblResults.Text = "please select a button";
return;
}

If there's an error, it will never get to the line where it uses iResult's value, so it doesn't matter that it is unassigned.

[The Grasshopper]

How do i get iResult to be added to the sum for this line:

lblResults.Text = Convert.ToDecimal(iEarnings +iResult+ iHealth + i401k).ToString();

this is my radio buttons. this is why i was playing with strings, because i don't know what to do with it as an int.

int rad1 = 8;

int rad2 = 52;

int rad3 = 12;

int iResult;

if (rdoInterval1.Checked == true)

iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad1;

else if (rdoInterval2.Checked == true)

iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad2;

else if (rdoInterval3.Checked == true)

iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad3;

else

lblResults.Text = "please select a button";

[The Grasshopper]

That means that you are trying to do something with the value of a variable you have never set. If you want to add, subtract, multiply or whatever with a variable, you must have given it a value already.

if (rdoInterval1.Checked == true)
iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad1;
else if (rdoInterval2.Checked == true)
iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad2;
else if (rdoInterval3.Checked == true)
iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad3;
else
lblResults.Text = "please select a button"; //------------------------You code is going to here.

In that case, it doesn't give a value to iResult like the other else if statements do. This is a case where your program should stop as soon as it encounters this error, so you should leave the function right away and stop calculating stuff. Try this:

if (rdoInterval1.Checked == true)
iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad1;
else if (rdoInterval2.Checked == true)
iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad2;
else if (rdoInterval3.Checked == true)
iResult = Convert.ToInt32(txtBoxEarnings.Text) * rad3;
else
{
lblResults.Text = "please select a button";
return;
}

If there's an error, it will never get to the line where it uses iResult's value, so it doesn't matter that it is unassigned.

EXCELLENT! that worked!!!

one more if you don't mind...how do i make this covert to currency?

No wonder Neowin is my favorite place to go to...i mean that too!

[Banjo]

What do you mean by currency? Like displaying it in the form "$2.00" or something like that?

You could try changing

lblResults.Text = (iEarnings + iResult + iHealth + i401k).ToString();

to

lblResults.Text = string.Format("{0:C}", (iEarnings + iResult + iHealth + i401k));

See here

[GreenMartian]

Oh wait, we're dealing with currency here? does that mean your textboxes may contain decimals?

In that case, all those Convert.ToInt32 may need to be changed to Convert.ToDouble.

And to format it as currency in the result box, you can change your ToString() to ToString("C")

[The Grasshopper]

What do you mean by currency? Like displaying it in the form "$2.00" or something like that?

You could try changing

lblResults.Text = (iEarnings + iResult + iHealth + i401k).ToString();

to

lblResults.Text = string.Format("{0:C}", (iEarnings + iResult + iHealth + i401k));

See here

That Worked!

steveX has a good website too! I will use his website a lot.

Oh wait, we're dealing with currency here? does that mean your textboxes may contain decimals?

In that case, all those Convert.ToInt32 may need to be changed to Convert.ToDouble.

And to format it as currency in the result box, you can change your ToString() to ToString("C")

I don't have to do that yet. but now that i am aware of it..thanks

[Banjo]

GreenMartian has a good point, too. If cents matter in your calculations, you'll want to switch everything from integers to doubles. I don't know if that matters for your assignment though. Integers, of course, hold whole numbers and doubles hold decimal numbers with a certain degree of precision.

[The Grasshopper]

I am sure i will have this in the future so i will keep an eye out for it.

thanks again and if you don't mind, i added you to my friends list.

would love to visit canada someday. always wanted to.

[Banjo]

Yes, it's very nice, but very cold :p

I've been to Ohio before, but not as far as Cincinnati

[The Grasshopper]

I just looked at the assignment requirements and i overlooked a string that i have to add...need to concatenate the name and the lblresults.

if i want the code: lblResults.Text = string.Format("{0:C}", (iEarnings + iResult + iHealth + i401k));

to string with Name..

isn't it something like:

string sText = "txtBoxName.Text";

string strResult = lblResults.Text = string.Format("{0:C}", (iEarnings + iResult + iHealth + i401k));

sText + strResult

or

lblResults.Text = string.Format("{0:C}", (iEarnings + iResult + iHealth + i401k)) & "sText";

or

lblResults.Text = "sText" & string.Format("{0:C}", (iEarnings + iResult + iHealth + i401k))

do i have to add another label box? I don't even remember how to string them together in vb.

Edited November 23, 2008 by The Grasshopper

[Banjo]

string.Format makes it very easy to do:

lblResults.Text = string.Format("{0:C}", (iEarnings + iResult + iHealth + i401k));

The bolded part states that you want to place a variable into your string, and the 0 states that it should be the next parameter. In this case, it's (iEarnings + iResult + iHealth + i401k). If you add another variable to the string, it's {1}, another and it's {2}, etc.

To get the name, since it's already a string, you can do this (remember to not put quotes when using variables):

string sText = txtBoxName.Text;

So to add another variable to the label, you can do this:

lblResults.Text = string.Format("{0} {1:C}", sText, (iEarnings + iResult + iHealth + i401k));

Note how the sText variable is {0} since it comes first and your money value moves up to {1}. The ":C" parts means formatting it as currency.

Alternatively, and more simply, you can use the plus sign to concatenate two string variables. Eg:

part1 = "Blah blah";

part2 = "Whatever";

part1 + part2 gives you "Blah blahWhatever"

Remember that both variables have to be strings. It won't work if one is a string and one is an integer, etc.

[The Grasshopper]

string.Format makes it very easy to do:

lblResults.Text = string.Format("{0:C}", (iEarnings + iResult + iHealth + i401k));

The bolded part states that you want to place a variable into your string, and the 0 states that it should be the next parameter. In this case, it's (iEarnings + iResult + iHealth + i401k). If you add another variable to the string, it's {1}, another and it's {2}, etc.

To get the name, since it's already a string, you can do this (remember to not put quotes when using variables):

string sText = txtBoxName.Text;

So to add another variable to the label, you can do this:

lblResults.Text = string.Format("{0} {1:C}", sText, (iEarnings + iResult + iHealth + i401k));

Note how the sText variable is {0} since it comes first and your money value moves up to {1}. The ":C" parts means formatting it as currency.

Alternatively, and more simply, you can use the plus sign to concatenate two string variables. Eg:

part1 = "Blah blah";

part2 = "Whatever";

part1 + part2 gives you "Blah blahWhatever"

Remember that both variables have to be strings. It won't work if one is a string and one is an integer, etc.

this didn't work, probably because they way i used stext as a string. i used lbltext as the string. i have result as the label name and also in the field. should i leave it blank when i load it. nevermind. i changed the label name "blank" in asp page but it didn't work.

Edited November 23, 2008 by The Grasshopper