• 0

[ASP.NET] I have a function that returns a dataset


Question

Hello,

So I have a function that returns a DataSet. When do I close the databse connection? Can I close it before returning the DataSet?

Example:

	public static DataSet Addresses_for_a_Client_by_ID(string cID)
	{
		/* snipped */

		SqlDataAdapter da = new SqlDataAdapter();
		da.SelectCommand = cmd;
		DataSet ds = new DataSet();
		da.Fill(ds, "ClientAddresses");

		// Can I do: connection.Close(); here? 
		return ds;
	}

4 answers to this question

Recommended Posts

  • 0

Yep. You can close the connection before returning the dataset. Ideally you would want to do "da.Dispose()" between "da.Fill(...)" and "return ds;" The dataset holds the results of the query in its own data structure, so once you've got the data, you don't need to be connected to the database anymore.

  • 0
  Majesticmerc said:
Yep. You can close the connection before returning the dataset. Ideally you would want to do "da.Dispose()" between "da.Fill(...)" and "return ds;" The dataset holds the results of the query in its own data structure, so once you've got the data, you don't need to be connected to the database anymore.

DataSet.Dispose doesn't really do anything, its an inherited member from a lower level of the abstraction tree.

  • 0
  Antaris said:
DataSet.Dispose doesn't really do anything, its an inherited member from a lower level of the abstraction tree.

Ah fair enough. Cheers :)

Edited by Majesticmerc
This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Posts

    • Sounds like a good time to do a fresh install of Windows. WTF people...
    • It only includes Russia. All other territories come at an additional cost of $20/pm/per territory you want to use it in.
    • From cars to cosmos: Honda's experimental rocket aces first landing test by Paul Hill Image via Honda Watch your back SpaceX, the Japanese company Honda has just performed a successful first launch of its experimental reusable rocket. The 6.3 meter rocket, which weighs 900kg, reached a modest altitude of 271.4 meters, but managed to land within 37cm of its target (1.2 feet), which is certainly pretty close. The rocket took off from a Honda facility in Taiki Town, Hokkaido, a growing space town in Japan. The flight time was also modest, coming in at just 56.6 seconds, but in that time, Honda was able to demonstrate key reusability technologies such as flight stability and landing capability. This marks a significant milestone for Honda’s space R&D department, which began work just four years ago. If you remember the tests SpaceX was performing around 2012 with Grasshopper, well Honda is at about the same stage with its reusable rocket. Why Honda is building rockets: Beyond cars and motorcycles Honda said that it wants to leverage core technologies it already works on for offering space services. It said that reusable rockets are a key part of sustainable space transportation. By 2029, the company wants to be able to perform suborbital launches, and while commercialization hasn’t been decided yet, it sees itself launching remote-sensing and wide-area communication satellites in the future. The Japanese car maker sees growing demand for satellite launches and wants to be involved by developing reusable rockets which could help it perform such launches economically. If it does end up finding customers, it will add more competition to the rocket launch sector. While the company hasn’t confirmed this, by developing its own launch system, it could eventually be in a position to launch its own satellites that could provide services to its cars to add value for customers. The competitive landscape and Japan's space ambitions Honda is just the latest company to join the growing list of companies trying to develop reusable rocket technology. The most famous companies doing this are SpaceX and Blue Origin, but there are also lots of other companies around the world also developing this technology. Honda is still taking baby steps compared to SpaceX, but it shows that the company is taking a focused, step-by-step approach, and achieving successes as noted by this launch. Hopefully, the company ends up providing tough competition against SpaceX, Blue Origin, and other companies so that it can help to drive down prices and spur on innovation.
    • Does that subscription include international data roaming, inclusive of Russia?
    • If you're stupid enough to try and get one, each and every headache along the way is on you. I can only hope that these roadblocks on a pre-order are enough to dissuade people.
  • Recent Achievements

    • Reacting Well
      pnajbar earned a badge
      Reacting Well
    • Week One Done
      TBithoney earned a badge
      Week One Done
    • First Post
      xuxlix earned a badge
      First Post
    • First Post
      Tomek Święcicki earned a badge
      First Post
    • One Year In
      carlitin86 earned a badge
      One Year In
  • Popular Contributors

    1. 1
      +primortal
      680
    2. 2
      ATLien_0
      288
    3. 3
      Michael Scrip
      223
    4. 4
      +FloatingFatMan
      193
    5. 5
      Steven P.
      145
  • Tell a friend

    Love Neowin? Tell a friend!